You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/02/05 15:44:00 UTC
[GitHub] [rocketmq] pjfanning opened a new pull request #3820: remove unused log4j dependency
pjfanning opened a new pull request #3820:
URL: https://github.com/apache/rocketmq/pull/3820
https://github.com/apache/rocketmq/issues/3819
**Make sure set the target branch to `develop`**
## What is the purpose of the change
Trying to remove the dependency on log4jv1
## Brief changelog
pom change
## Verifying this change
CI build
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] pjfanning closed pull request #3820: remove unused log4j dependency
Posted by GitBox <gi...@apache.org>.
pjfanning closed pull request #3820:
URL: https://github.com/apache/rocketmq/pull/3820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] pjfanning commented on pull request #3820: remove unused log4j dependency
Posted by GitBox <gi...@apache.org>.
pjfanning commented on pull request #3820:
URL: https://github.com/apache/rocketmq/pull/3820#issuecomment-1030648196
log4jv1 is still in use in some subprojects
```
[ERROR] The project org.apache.rocketmq:rocketmq-logappender:4.9.3-SNAPSHOT (/home/travis/build/apache/rocketmq/logappender/pom.xml) has 1 error
[ERROR] 'dependencies.dependency.version' for log4j:log4j:jar is missing. @ org.apache.rocketmq:rocketmq-logappender:[unknown-version], /home/travis/build/apache/rocketmq/logappender/pom.xml, line 35, column 21
[ERROR]
[ERROR] The project org.apache.rocketmq:rocketmq-test:4.9.3-SNAPSHOT (/home/travis/build/apache/rocketmq/test/pom.xml) has 1 error
[ERROR] 'dependencies.dependency.version' for log4j:log4j:jar is missing. @ org.apache.rocketmq:rocketmq-test:[unknown-version], /home/travis/build/apache/rocketmq/test/pom.xml, line 31, column 21
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org