You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Chris Riccomini <cr...@apache.org> on 2014/04/18 05:15:13 UTC
Review Request 20475: SAMZA-202 (alternative)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20475/
-----------------------------------------------------------
Review request for samza.
Repository: samza
Description
-------
add some javadocs. give in to the dark side, and populate empty system map using lispy goodness.
remove comment
270k msgs/sec
turn on cms for test classes
200k msgs/sec
130k msgs/sec
Diffs
-----
build.gradle b54cee6cfc99aea78f5acc04dc13c1989682c4b2
samza-api/src/main/java/org/apache/samza/system/SystemConsumer.java a92e30147b366275fd7d4eb7828dae8ec362ab15
samza-api/src/main/java/org/apache/samza/system/SystemStreamPartitionIterator.java 62a5eb7493786f22b95bae1cc39f6cacaa0e9097
samza-api/src/main/java/org/apache/samza/util/BlockingEnvelopeMap.java 7171088d6e0e7999fdb55c8635145d5abf16d110
samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala bbbacb59866c2374853052f7cc11826552f5fb01
samza-core/src/main/scala/org/apache/samza/system/chooser/RoundRobinChooser.scala 537412114105ee9124a32e7bda4ef95139612ec8
samza-test/src/test/scala/org/apache/samza/test/performance/TestSamzaContainerPerformance.scala 3dc263011b955cfccac83e71384b865f8fc2b722
Diff: https://reviews.apache.org/r/20475/diff/
Testing
-------
Thanks,
Chris Riccomini
Re: Review Request 20475: SAMZA-245
Posted by Jakob Homan <jg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20475/#review48111
-----------------------------------------------------------
samza-api/src/main/java/org/apache/samza/system/SystemConsumer.java
<https://reviews.apache.org/r/20475/#comment84410>
Need to update javadoc.
samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala
<https://reviews.apache.org/r/20475/#comment84411>
emptySystemStreamPartitionsBySystem ++=
unprocessedMessages
.keySet
.groupBy(_.getSystem)
?
- Jakob Homan
On April 21, 2014, 9:55 a.m., Chris Riccomini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20475/
> -----------------------------------------------------------
>
> (Updated April 21, 2014, 9:55 a.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> add some javadocs. give in to the dark side, and populate empty system map using lispy goodness.
>
>
> remove comment
>
>
> 270k msgs/sec
>
>
> turn on cms for test classes
>
>
> 200k msgs/sec
>
>
> 130k msgs/sec
>
>
> Diffs
> -----
>
> build.gradle b54cee6cfc99aea78f5acc04dc13c1989682c4b2
> samza-api/src/main/java/org/apache/samza/system/SystemConsumer.java a92e30147b366275fd7d4eb7828dae8ec362ab15
> samza-api/src/main/java/org/apache/samza/system/SystemStreamPartitionIterator.java 62a5eb7493786f22b95bae1cc39f6cacaa0e9097
> samza-api/src/main/java/org/apache/samza/util/BlockingEnvelopeMap.java 7171088d6e0e7999fdb55c8635145d5abf16d110
> samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala bbbacb59866c2374853052f7cc11826552f5fb01
> samza-core/src/main/scala/org/apache/samza/system/chooser/RoundRobinChooser.scala 537412114105ee9124a32e7bda4ef95139612ec8
> samza-test/src/test/scala/org/apache/samza/test/performance/TestSamzaContainerPerformance.scala 3dc263011b955cfccac83e71384b865f8fc2b722
>
> Diff: https://reviews.apache.org/r/20475/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris Riccomini
>
>
Re: Review Request 20475: SAMZA-245
Posted by Chris Riccomini <cr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20475/
-----------------------------------------------------------
(Updated April 21, 2014, 4:55 p.m.)
Review request for samza.
Summary (updated)
-----------------
SAMZA-245
Repository: samza
Description
-------
add some javadocs. give in to the dark side, and populate empty system map using lispy goodness.
remove comment
270k msgs/sec
turn on cms for test classes
200k msgs/sec
130k msgs/sec
Diffs
-----
build.gradle b54cee6cfc99aea78f5acc04dc13c1989682c4b2
samza-api/src/main/java/org/apache/samza/system/SystemConsumer.java a92e30147b366275fd7d4eb7828dae8ec362ab15
samza-api/src/main/java/org/apache/samza/system/SystemStreamPartitionIterator.java 62a5eb7493786f22b95bae1cc39f6cacaa0e9097
samza-api/src/main/java/org/apache/samza/util/BlockingEnvelopeMap.java 7171088d6e0e7999fdb55c8635145d5abf16d110
samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala bbbacb59866c2374853052f7cc11826552f5fb01
samza-core/src/main/scala/org/apache/samza/system/chooser/RoundRobinChooser.scala 537412114105ee9124a32e7bda4ef95139612ec8
samza-test/src/test/scala/org/apache/samza/test/performance/TestSamzaContainerPerformance.scala 3dc263011b955cfccac83e71384b865f8fc2b722
Diff: https://reviews.apache.org/r/20475/diff/
Testing
-------
Thanks,
Chris Riccomini
Re: Review Request 20475: SAMZA-220 (alternative)
Posted by Chris Riccomini <cr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20475/
-----------------------------------------------------------
(Updated April 18, 2014, 3:32 a.m.)
Review request for samza.
Summary (updated)
-----------------
SAMZA-220 (alternative)
Repository: samza
Description
-------
add some javadocs. give in to the dark side, and populate empty system map using lispy goodness.
remove comment
270k msgs/sec
turn on cms for test classes
200k msgs/sec
130k msgs/sec
Diffs
-----
build.gradle b54cee6cfc99aea78f5acc04dc13c1989682c4b2
samza-api/src/main/java/org/apache/samza/system/SystemConsumer.java a92e30147b366275fd7d4eb7828dae8ec362ab15
samza-api/src/main/java/org/apache/samza/system/SystemStreamPartitionIterator.java 62a5eb7493786f22b95bae1cc39f6cacaa0e9097
samza-api/src/main/java/org/apache/samza/util/BlockingEnvelopeMap.java 7171088d6e0e7999fdb55c8635145d5abf16d110
samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala bbbacb59866c2374853052f7cc11826552f5fb01
samza-core/src/main/scala/org/apache/samza/system/chooser/RoundRobinChooser.scala 537412114105ee9124a32e7bda4ef95139612ec8
samza-test/src/test/scala/org/apache/samza/test/performance/TestSamzaContainerPerformance.scala 3dc263011b955cfccac83e71384b865f8fc2b722
Diff: https://reviews.apache.org/r/20475/diff/
Testing
-------
Thanks,
Chris Riccomini