You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/09 06:35:47 UTC

[GitHub] [apisix] spacewander commented on a change in pull request #4014: fix(prometheus): collect nginx_status and return the body

spacewander commented on a change in pull request #4014:
URL: https://github.com/apache/apisix/pull/4014#discussion_r610380177



##########
File path: t/cli/test_prometheus.sh
##########
@@ -35,6 +35,11 @@ if [ ! $code -eq 200 ]; then
     exit 1
 fi
 
+if ! curl -i http://127.0.0.1:9091/apisix/prometheus/metrics | grep "apisix_nginx_http_current_connections" > /dev/null; then
+    echo "failed: should listen default prometheus address"
+    exit 1
+fi
+
 make stop
 
 echo "passed: should listen default prometheus address"

Review comment:
       @jbampton 
   Applied. Thanks!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org