You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2017/09/13 02:57:03 UTC
[kudu-CR] KUDU-2135 (part 1): add persistent disk states
Andrew Wong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/8048
Change subject: KUDU-2135 (part 1): add persistent disk states
......................................................................
KUDU-2135 (part 1): add persistent disk states
This patch introduces a new format for PathInstanceMetadataFiles that
includes a disk health and path for each data directory, and a timestamp
that the path instance file was last updated.
These additions will be necessary to ensure failed disks will not be
used and that data is where expect it to be (which will be increasingly
important as we begin to supporting removal/addition/replacement of
disks).
The expected usage of the new format would enforce startup restrictions
on the server (e.g. to not use a failed disk, to not use data if it is
on a different disk than expected, etc.) and tooling does not yet exist
to work around these restrictions. As such, this patch will upgrade and
maintain the new path sets as necessary, persisting disk health when
disks fail, but will not apply the mentioned restrictions at startup.
A test is added to data_dirs-test to ensure the path instance files get
updated/upgraded appropriately.
Change-Id: Ia7ea6418f6190d7d0c6d5a1aaca4ca592c49ce41
---
M src/kudu/fs/block_manager_util-test.cc
M src/kudu/fs/block_manager_util.cc
M src/kudu/fs/block_manager_util.h
M src/kudu/fs/data_dirs-test.cc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/data_dirs.h
M src/kudu/fs/fs.proto
7 files changed, 467 insertions(+), 76 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/8048/1
--
To view, visit http://gerrit.cloudera.org:8080/8048
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia7ea6418f6190d7d0c6d5a1aaca4ca592c49ce41
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] KUDU-2135 (part 1): add persistent disk states
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has abandoned this change. ( http://gerrit.cloudera.org:8080/8048 )
Change subject: KUDU-2135 (part 1): add persistent disk states
......................................................................
Abandoned
no longer in scope for disk failure handling
--
To view, visit http://gerrit.cloudera.org:8080/8048
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia7ea6418f6190d7d0c6d5a1aaca4ca592c49ce41
Gerrit-Change-Number: 8048
Gerrit-PatchSet: 7
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-2135 (part 1): add persistent disk states
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8048
to look at the new patch set (#7).
Change subject: KUDU-2135 (part 1): add persistent disk states
......................................................................
KUDU-2135 (part 1): add persistent disk states
This patch introduces a new format for PathInstanceMetadataFiles that
includes a health state and path for each data directory, and a
timestamp that the path instance file was last updated.
These additions will be necessary to ensure that failed disks will not
be used and that data is where it is expected be (which will be
increasingly important as we begin to supporting addition, and
replacement of disks).
The expected usage of the new format would enforce startup restrictions
on the server (e.g. to never use a previously failed disk, to not use
data if it is on a different disk than expected, etc.) and tooling does
not yet exist to work around these restrictions. As such, this patch
will upgrade and maintain the new path sets as necessary, persisting
disk health when disks fail, but will not apply the mentioned
restrictions at startup.
Additionally, since DataDirManager::Open() has grown a bit large, it
has been structured into more comprehensible parts, loosely:
1. Open all instance files, creating in-memory DataDirs for them
2. Check the integrity of the instances
3. Create the in-memory mappings for the directories
4. Update the on-disk instances that need updating/upgrading
Tests are added to data_dirs-test to ensure the path instance files get
updated and upgraded appropriately.
Change-Id: Ia7ea6418f6190d7d0c6d5a1aaca4ca592c49ce41
---
M src/kudu/fs/block_manager_util-test.cc
M src/kudu/fs/block_manager_util.cc
M src/kudu/fs/block_manager_util.h
M src/kudu/fs/data_dirs-test.cc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/data_dirs.h
M src/kudu/fs/fs.proto
7 files changed, 540 insertions(+), 126 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/8048/7
--
To view, visit http://gerrit.cloudera.org:8080/8048
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia7ea6418f6190d7d0c6d5a1aaca4ca592c49ce41
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] KUDU-2135 (part 1): add persistent disk states
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change.
Change subject: KUDU-2135 (part 1): add persistent disk states
......................................................................
Patch Set 2:
Ah, Adar mentioned it'd be a good idea to decompose DataDirManager::Open() since it's so long. I'll do that now (but for the most part, this is reviewable)
--
To view, visit http://gerrit.cloudera.org:8080/8048
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7ea6418f6190d7d0c6d5a1aaca4ca592c49ce41
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] KUDU-2135 (part 1): add persistent disk states
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8048
to look at the new patch set (#4).
Change subject: KUDU-2135 (part 1): add persistent disk states
......................................................................
KUDU-2135 (part 1): add persistent disk states
This patch introduces a new format for PathInstanceMetadataFiles that
includes a health state and path for each data directory, and a
timestamp that the path instance file was last updated.
These additions will be necessary to ensure that failed disks will not
be used and that data is where it is expected be (which will be
increasingly important as we begin to supporting removal, addition, and
replacement of disks).
The expected usage of the new format would enforce startup restrictions
on the server (e.g. to never use a previously failed disk, to not use
data if it is on a different disk than expected, etc.) and tooling does
not yet exist to work around these restrictions. As such, this patch
will upgrade and maintain the new path sets as necessary, persisting
disk health when disks fail, but will not apply the mentioned
restrictions at startup.
Tests are added to data_dirs-test to ensure the path instance files get
updated and upgraded appropriately.
Change-Id: Ia7ea6418f6190d7d0c6d5a1aaca4ca592c49ce41
---
M src/kudu/fs/block_manager_util-test.cc
M src/kudu/fs/block_manager_util.cc
M src/kudu/fs/block_manager_util.h
M src/kudu/fs/data_dirs-test.cc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/data_dirs.h
M src/kudu/fs/fs.proto
7 files changed, 540 insertions(+), 129 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/8048/4
--
To view, visit http://gerrit.cloudera.org:8080/8048
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia7ea6418f6190d7d0c6d5a1aaca4ca592c49ce41
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2135 (part 1): add persistent disk states
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8048
to look at the new patch set (#3).
Change subject: KUDU-2135 (part 1): add persistent disk states
......................................................................
KUDU-2135 (part 1): add persistent disk states
This patch introduces a new format for PathInstanceMetadataFiles that
includes a health state and path for each data directory, and a
timestamp that the path instance file was last updated.
These additions will be necessary to ensure that failed disks will not
be used and that data is where it is expected be (which will be
increasingly important as we begin to supporting removal, addition, and
replacement of disks).
The expected usage of the new format would enforce startup restrictions
on the server (e.g. to never use a previously failed disk, to not use
data if it is on a different disk than expected, etc.) and tooling does
not yet exist to work around these restrictions. As such, this patch
will upgrade and maintain the new path sets as necessary, persisting
disk health when disks fail, but will not apply the mentioned
restrictions at startup.
Tests are added to data_dirs-test to ensure the path instance files get
updated and upgraded appropriately.
Change-Id: Ia7ea6418f6190d7d0c6d5a1aaca4ca592c49ce41
---
M src/kudu/fs/block_manager_util-test.cc
M src/kudu/fs/block_manager_util.cc
M src/kudu/fs/block_manager_util.h
M src/kudu/fs/data_dirs-test.cc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/data_dirs.h
M src/kudu/fs/fs.proto
7 files changed, 473 insertions(+), 76 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/8048/3
--
To view, visit http://gerrit.cloudera.org:8080/8048
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia7ea6418f6190d7d0c6d5a1aaca4ca592c49ce41
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2135 (part 1): add persistent disk states
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: KUDU-2135 (part 1): add persistent disk states
......................................................................
Patch Set 7:
(14 comments)
I think Todd should review this.
http://gerrit.cloudera.org:8080/#/c/8048/7//COMMIT_MSG
Commit Message:
PS7, Line 11: that
"for when" instead? Not sure, that doesn't sound great either.
http://gerrit.cloudera.org:8080/#/c/8048/7/src/kudu/fs/data_dirs-test.cc
File src/kudu/fs/data_dirs-test.cc:
Line 448: CHECK_OK(pb_util::ReadPBContainerFromPath(env_, instance_filename, pb.get()));
Can't use ASSERT_OK here?
Line 474: TEST_F(DataDirManagerTest, TestUpdateInstanceFiles) {
Suspiciously similar test name as TestUpgradeInstanceFiles. Perhaps rename one or the other (or both)?
http://gerrit.cloudera.org:8080/#/c/8048/7/src/kudu/fs/data_dirs.cc
File src/kudu/fs/data_dirs.cc:
Line 437: // Load the directory for all data dirs specified by the user.
This comment seems misplaced, and perhaps even confused. What does "Load the directory..." mean? We're loading an instance file and creating a DataDir.
Line 441: // Open and lock the data dir's metadata instance file.
Nit: trim so this complements the comment on L452 better (i.e. don't need to mention locking here).
PS7, Line 533: LOG(ERROR) << Substitute("Could not write $0 new instance files; filesystem opened in "
: "read-only mode", updated_instances.size());
Why is this an error? If the very first interaction I have with this new code is via the kudu CLI, I'll probably be in read-only mode, and that doesn't seem like an error to me.
PS7, Line 546: // From this point onwards, the in-memory maps and on-disk instances must be
: // consistent with the main path set.
Why is this important to note? Is it significant for initializing the "fullness" status?
Line 599: int max_data_dirs = block_manager_type_ == "file" ? (1 << 16) - 1 : kuint32max;
Maybe declare this at the top of the function as "const kMaxDataDirs" to emphasize that it's unchanging state?
Alternatively, fold it into the condition on L617. Either way, there's a little less state to worry about while reading through this function.
PS7, Line 675: path_set_.all_paths(uuid_idx)
Nit: pull this out into a cref variable local to the for loop.
PS7, Line 960: path_set_.mutable_all_paths(uuid_idx)
Nit: pull out into a local cref.
PS7, Line 966: LOG(WARNING) << "Directory health states cannot be written; filesystem is "
: "opened read-only mode";
Does it make sense for this to be a WARNING and not INFO, given that the kudu CLI tool is generally read-only?
Line 991: std::lock_guard<Mutex> lock(write_instance_mutex_);
Should add a comment explaining why serialization of WritePathHealthStates is important.
http://gerrit.cloudera.org:8080/#/c/8048/7/src/kudu/fs/data_dirs.h
File src/kudu/fs/data_dirs.h:
Line 439: // Returns the instances in the order of the main path set's 'all_paths'.
Why is this important? Seems like we could cut down on some complexity if we didn't provide this (and if the IndexDirs caller didn't need to use it).
If this is to satisfy the input requirements of UpdateInstanceFiles; perhaps we could perform the reordering there? Then there'll be less coupling between these functions.
PS7, Line 440: IndexDirs
Maybe InitDataDirMaps or InitDataDirIndexes instead? That emphasizes that this is an initialization function, which elsewhere in the Kudu codebase implies it only runs at startup time.
--
To view, visit http://gerrit.cloudera.org:8080/8048
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7ea6418f6190d7d0c6d5a1aaca4ca592c49ce41
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2135 (part 1): add persistent disk states
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8048
to look at the new patch set (#5).
Change subject: KUDU-2135 (part 1): add persistent disk states
......................................................................
KUDU-2135 (part 1): add persistent disk states
This patch introduces a new format for PathInstanceMetadataFiles that
includes a health state and path for each data directory, and a
timestamp that the path instance file was last updated.
These additions will be necessary to ensure that failed disks will not
be used and that data is where it is expected be (which will be
increasingly important as we begin to supporting removal, addition, and
replacement of disks).
The expected usage of the new format would enforce startup restrictions
on the server (e.g. to never use a previously failed disk, to not use
data if it is on a different disk than expected, etc.) and tooling does
not yet exist to work around these restrictions. As such, this patch
will upgrade and maintain the new path sets as necessary, persisting
disk health when disks fail, but will not apply the mentioned
restrictions at startup.
Additionally, since DataDirManager::Open() has grown a bit large, it
has been structured into more comprehensible parts, loosely:
1. Open all instance files, creating in-memory DataDirs for them
2. Check the integrity of the instances
3. Create the in-memory mappings for the directories
4. Update on-disk the instances that need updating/upgrading
Tests are added to data_dirs-test to ensure the path instance files get
updated and upgraded appropriately.
Change-Id: Ia7ea6418f6190d7d0c6d5a1aaca4ca592c49ce41
---
M src/kudu/fs/block_manager_util-test.cc
M src/kudu/fs/block_manager_util.cc
M src/kudu/fs/block_manager_util.h
M src/kudu/fs/data_dirs-test.cc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/data_dirs.h
M src/kudu/fs/fs.proto
7 files changed, 540 insertions(+), 129 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/8048/5
--
To view, visit http://gerrit.cloudera.org:8080/8048
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia7ea6418f6190d7d0c6d5a1aaca4ca592c49ce41
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] KUDU-2135 (part 1): add persistent disk states
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8048 )
Change subject: KUDU-2135 (part 1): add persistent disk states
......................................................................
Patch Set 7:
(2 comments)
Should this be abandoned? I think it was re-posted elsewhere or made obsolete by design changes?
(apparently I also had some draft comments on this which are going to be posted with the above question, feel free to ignore them)
http://gerrit.cloudera.org:8080/#/c/8048/7//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/8048/7//COMMIT_MSG@13
PS7, Line 13: failed disks will not
: be used and that data is where it is expected be (which will be
: increasingly important as we begin to supporting addition, and
: replacement of disks).
Can you expand on this a bit in the commit message? I'm not entirely sure I understand what "data is where it is expected to be" means. For example, imagine I have disks mounted at /data/{1,2,3}/ and on reboot for some reason the disks are re-assigned such that the mount point /data/1 refers to the data that used to be on /data/3/. Is that prevented by this?
FWIW the above isn't that out-of-the-ordinary -- the assignment of /dev/sd{a,b,c} at boot time can be non-deterministic in some setups (or at least it was when I last did some ops stuff). Best practice is to use "UUID=" mappings in /etc/fstab so that the disks show up in consistent spots but I'm not sure everyone does this, so would be a good idea to know ahead of time what would happen.
Similarly, what if for some reason I decided that instead of mounting at /data/{1,2,3} I wanted to mount at /data/{1,2,3}/kudu or something (i.e change the paths but keep the same blocks in the same dirs). Would that be allowed or prohibited? Why?
Again the above isn't that crazy of a scenario, eg if someone starts with using a disk just for Kudu and then decides they also want to install HDFS and thus moves all the kudu data into a subdir.
http://gerrit.cloudera.org:8080/#/c/8048/7//COMMIT_MSG@19
PS7, Line 19: to never use a previously failed disk,
I think I've been confused about this several times but still can't quite remember the reasoning here. Why is it bad to re-attempt to open a previously-failed disk?
--
To view, visit http://gerrit.cloudera.org:8080/8048
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7ea6418f6190d7d0c6d5a1aaca4ca592c49ce41
Gerrit-Change-Number: 8048
Gerrit-PatchSet: 7
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 05 Apr 2018 05:13:38 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2135 (part 1): add persistent disk states
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change.
Change subject: KUDU-2135 (part 1): add persistent disk states
......................................................................
Patch Set 7:
(1 comment)
There is a tidywarning but this is reviewable.
http://gerrit.cloudera.org:8080/#/c/8048/4/src/kudu/fs/data_dirs.h
File src/kudu/fs/data_dirs.h:
Line 438: //
> warning: parameter 'data_dirs' is const-qualified in the function declarati
Done
--
To view, visit http://gerrit.cloudera.org:8080/8048
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7ea6418f6190d7d0c6d5a1aaca4ca592c49ce41
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2135 (part 1): add persistent disk states
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8048
to look at the new patch set (#2).
Change subject: KUDU-2135 (part 1): add persistent disk states
......................................................................
KUDU-2135 (part 1): add persistent disk states
This patch introduces a new format for PathInstanceMetadataFiles that
includes a disk health and path for each data directory, and a timestamp
that the path instance file was last updated.
These additions will be necessary to ensure failed disks will not be
used and that data is where expect it to be (which will be increasingly
important as we begin to supporting removal/addition/replacement of
disks).
The expected usage of the new format would enforce startup restrictions
on the server (e.g. to not use a failed disk, to not use data if it is
on a different disk than expected, etc.) and tooling does not yet exist
to work around these restrictions. As such, this patch will upgrade and
maintain the new path sets as necessary, persisting disk health when
disks fail, but will not apply the mentioned restrictions at startup.
A test is added to data_dirs-test to ensure the path instance files get
updated/upgraded appropriately.
Change-Id: Ia7ea6418f6190d7d0c6d5a1aaca4ca592c49ce41
---
M src/kudu/fs/block_manager_util-test.cc
M src/kudu/fs/block_manager_util.cc
M src/kudu/fs/block_manager_util.h
M src/kudu/fs/data_dirs-test.cc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/data_dirs.h
M src/kudu/fs/fs.proto
7 files changed, 470 insertions(+), 76 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/8048/2
--
To view, visit http://gerrit.cloudera.org:8080/8048
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia7ea6418f6190d7d0c6d5a1aaca4ca592c49ce41
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins