You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jojy Varghese <jo...@mesosphere.io> on 2015/11/01 16:28:08 UTC
Re: Review Request 38579: Refactored registry client
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38579/
-----------------------------------------------------------
(Updated Nov. 1, 2015, 3:28 p.m.)
Review request for mesos, Ben Mahler and Timothy Chen.
Changes
-------
rebased.
Repository: mesos
Description
-------
- Cleanup and broke big methods into smaller chunks.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp ad57d8592c5f9df5115b575855ed2e99a0597359
src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c
src/tests/containerizer/provisioner_docker_tests.cpp 99c2af7d06dd7908e8d77e1bfb3e20622fb3eb4c
Diff: https://reviews.apache.org/r/38579/diff/
Testing
-------
make check.
Thanks,
Jojy Varghese
Re: Review Request 38579: Refactored registry client: split large
methods.
Posted by Timothy Chen <tn...@apache.org>.
> On Nov. 6, 2015, 2:54 a.m., Timothy Chen wrote:
> > src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp, line 529
> > <https://reviews.apache.org/r/38579/diff/16/?file=1116952#file1116952line529>
> >
> > Can you use the new .status == http::Status::OK and simliar checks here?
Never mind let's worry about this later.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38579/#review105352
-----------------------------------------------------------
On Nov. 5, 2015, 7:17 p.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38579/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2015, 7:17 p.m.)
>
>
> Review request for mesos, Ben Mahler and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> - Cleanup and broke big methods into smaller chunks.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp ad57d8592c5f9df5115b575855ed2e99a0597359
> src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c
> src/tests/containerizer/provisioner_docker_tests.cpp 8d90894410cd834edf49a2814d1b616718798fe8
>
> Diff: https://reviews.apache.org/r/38579/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 38579: Refactored registry client: split large
methods.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38579/#review105352
-----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 276)
<https://reviews.apache.org/r/38579/#comment163908>
Remove redundant check from above.
src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 291)
<https://reviews.apache.org/r/38579/#comment163909>
None of our onXXXXX callbacks with futures should return anything, since it has no effect!
Just remove this onDiscard if you're not really doing anything here.
src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 445)
<https://reviews.apache.org/r/38579/#comment163910>
Can you use the new .status == http::Status::OK and simliar checks here?
- Timothy Chen
On Nov. 5, 2015, 7:17 p.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38579/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2015, 7:17 p.m.)
>
>
> Review request for mesos, Ben Mahler and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> - Cleanup and broke big methods into smaller chunks.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp ad57d8592c5f9df5115b575855ed2e99a0597359
> src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c
> src/tests/containerizer/provisioner_docker_tests.cpp 8d90894410cd834edf49a2814d1b616718798fe8
>
> Diff: https://reviews.apache.org/r/38579/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 38579: Refactored registry client: split large
methods.
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38579/
-----------------------------------------------------------
(Updated Nov. 6, 2015, 6:57 a.m.)
Review request for mesos, Ben Mahler and Timothy Chen.
Changes
-------
review comments
Repository: mesos
Description
-------
- Cleanup and broke big methods into smaller chunks.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp ad57d8592c5f9df5115b575855ed2e99a0597359
src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c
src/tests/containerizer/provisioner_docker_tests.cpp 8d90894410cd834edf49a2814d1b616718798fe8
Diff: https://reviews.apache.org/r/38579/diff/
Testing
-------
make check.
Thanks,
Jojy Varghese
Re: Review Request 38579: Refactored registry client: split large
methods.
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38579/
-----------------------------------------------------------
(Updated Nov. 5, 2015, 7:17 p.m.)
Review request for mesos, Ben Mahler and Timothy Chen.
Changes
-------
rebased
Repository: mesos
Description
-------
- Cleanup and broke big methods into smaller chunks.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp ad57d8592c5f9df5115b575855ed2e99a0597359
src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c
src/tests/containerizer/provisioner_docker_tests.cpp 8d90894410cd834edf49a2814d1b616718798fe8
Diff: https://reviews.apache.org/r/38579/diff/
Testing
-------
make check.
Thanks,
Jojy Varghese
Re: Review Request 38579: Refactored registry client: split large
methods.
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38579/
-----------------------------------------------------------
(Updated Nov. 5, 2015, 5:57 p.m.)
Review request for mesos, Ben Mahler and Timothy Chen.
Summary (updated)
-----------------
Refactored registry client: split large methods.
Repository: mesos
Description
-------
- Cleanup and broke big methods into smaller chunks.
Diffs
-----
src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp ad57d8592c5f9df5115b575855ed2e99a0597359
src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c
src/tests/containerizer/provisioner_docker_tests.cpp 8d90894410cd834edf49a2814d1b616718798fe8
Diff: https://reviews.apache.org/r/38579/diff/
Testing
-------
make check.
Thanks,
Jojy Varghese
Re: Review Request 38579: Refactored registry client: split large
methods.
Posted by Jojy Varghese <jo...@mesosphere.io>.
> On Nov. 5, 2015, 5:54 p.m., Timothy Chen wrote:
> > Can you update the title to something more specific of what this patch does?
updated.
- Jojy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38579/#review105271
-----------------------------------------------------------
On Nov. 5, 2015, 5:57 p.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38579/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2015, 5:57 p.m.)
>
>
> Review request for mesos, Ben Mahler and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> - Cleanup and broke big methods into smaller chunks.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp ad57d8592c5f9df5115b575855ed2e99a0597359
> src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c
> src/tests/containerizer/provisioner_docker_tests.cpp 8d90894410cd834edf49a2814d1b616718798fe8
>
> Diff: https://reviews.apache.org/r/38579/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 38579: Refactored registry client
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38579/#review105271
-----------------------------------------------------------
Can you update the title to something more specific of what this patch does?
- Timothy Chen
On Nov. 5, 2015, 4:03 p.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38579/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2015, 4:03 p.m.)
>
>
> Review request for mesos, Ben Mahler and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> - Cleanup and broke big methods into smaller chunks.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp ad57d8592c5f9df5115b575855ed2e99a0597359
> src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c
> src/tests/containerizer/provisioner_docker_tests.cpp 8d90894410cd834edf49a2814d1b616718798fe8
>
> Diff: https://reviews.apache.org/r/38579/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 38579: Refactored registry client
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38579/
-----------------------------------------------------------
(Updated Nov. 5, 2015, 4:03 p.m.)
Review request for mesos, Ben Mahler and Timothy Chen.
Changes
-------
rebased
Repository: mesos
Description
-------
- Cleanup and broke big methods into smaller chunks.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp ad57d8592c5f9df5115b575855ed2e99a0597359
src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c
src/tests/containerizer/provisioner_docker_tests.cpp 8d90894410cd834edf49a2814d1b616718798fe8
Diff: https://reviews.apache.org/r/38579/diff/
Testing
-------
make check.
Thanks,
Jojy Varghese
Re: Review Request 38579: Refactored registry client
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38579/
-----------------------------------------------------------
(Updated Nov. 4, 2015, 6:07 p.m.)
Review request for mesos, Ben Mahler and Timothy Chen.
Changes
-------
moved timeout semantics to the caller.
Repository: mesos
Description
-------
- Cleanup and broke big methods into smaller chunks.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp ad57d8592c5f9df5115b575855ed2e99a0597359
src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c
src/tests/containerizer/provisioner_docker_tests.cpp 8d90894410cd834edf49a2814d1b616718798fe8
Diff: https://reviews.apache.org/r/38579/diff/
Testing
-------
make check.
Thanks,
Jojy Varghese
Re: Review Request 38579: Refactored registry client
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38579/
-----------------------------------------------------------
(Updated Nov. 2, 2015, 10:45 p.m.)
Review request for mesos, Ben Mahler and Timothy Chen.
Changes
-------
rebased.
Repository: mesos
Description
-------
- Cleanup and broke big methods into smaller chunks.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp ad57d8592c5f9df5115b575855ed2e99a0597359
src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c
src/tests/containerizer/provisioner_docker_tests.cpp 99c2af7d06dd7908e8d77e1bfb3e20622fb3eb4c
Diff: https://reviews.apache.org/r/38579/diff/
Testing
-------
make check.
Thanks,
Jojy Varghese