You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/11/16 13:03:51 UTC
[GitHub] [incubator-nuttx] pussuw opened a new pull request, #7607: mm/shm: Implement shmem drivers for risc-v target
pussuw opened a new pull request, #7607:
URL: https://github.com/apache/incubator-nuttx/pull/7607
## Summary
Implements up_shmat and up_shmdt for risc-v target
## Impact
None, if CONFIG_MM_SHM is not enabled
## Testing
icicle:knsh (example config file update will follow later)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] hartmannathan commented on a diff in pull request #7607: mm/shm: Implement shmem drivers for risc-v target
Posted by GitBox <gi...@apache.org>.
hartmannathan commented on code in PR #7607:
URL: https://github.com/apache/incubator-nuttx/pull/7607#discussion_r1024226515
##########
mm/shm/shm_initialize.c:
##########
@@ -25,6 +25,7 @@
#include <nuttx/config.h>
#include <assert.h>
+#include <debug.h>
Review Comment:
Interestingly I was getting an error for `minfo()` even with `#include <debug.h>`. I was trying to build sama5d4-ek:knsh with `MM_SHM` enabled and was having problems. Not sure why I had problems but I ran out of time for today because of other work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #7607: mm/shm: Implement shmem drivers for risc-v target
Posted by GitBox <gi...@apache.org>.
pussuw commented on code in PR #7607:
URL: https://github.com/apache/incubator-nuttx/pull/7607#discussion_r1024356378
##########
mm/shm/shm_initialize.c:
##########
@@ -25,6 +25,7 @@
#include <nuttx/config.h>
#include <assert.h>
+#include <debug.h>
Review Comment:
This:
https://github.com/apache/incubator-nuttx/blob/master/arch/arm/src/armv7-a/arm_addrenv_shm.c
File seems to be missing #include <debug.h> as well, maybe adding it there will fix your issue?
I tested compiling for riscv target only, which obviously works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] hartmannathan commented on a diff in pull request #7607: mm/shm: Implement shmem drivers for risc-v target
Posted by GitBox <gi...@apache.org>.
hartmannathan commented on code in PR #7607:
URL: https://github.com/apache/incubator-nuttx/pull/7607#discussion_r1024094235
##########
mm/shm/shmat.c:
##########
@@ -26,6 +26,7 @@
#include <sys/shm.h>
#include <assert.h>
+#include <debug.h>
Review Comment:
Ditto
##########
mm/shm/shm_initialize.c:
##########
@@ -25,6 +25,7 @@
#include <nuttx/config.h>
#include <assert.h>
+#include <debug.h>
Review Comment:
Why `#include <debug.h>` is needed here?
##########
mm/shm/shmget.c:
##########
@@ -28,6 +28,7 @@
#include <sys/ipc.h>
#include <unistd.h>
#include <string.h>
+#include <debug.h>
Review Comment:
Ditto
##########
mm/shm/shmctl.c:
##########
@@ -31,6 +31,7 @@
#include <time.h>
#include <errno.h>
#include <assert.h>
+#include <debug.h>
Review Comment:
Ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #7607: mm/shm: Implement shmem drivers for risc-v target
Posted by GitBox <gi...@apache.org>.
pussuw commented on code in PR #7607:
URL: https://github.com/apache/incubator-nuttx/pull/7607#discussion_r1024198370
##########
mm/shm/shm_initialize.c:
##########
@@ -25,6 +25,7 @@
#include <nuttx/config.h>
#include <assert.h>
+#include <debug.h>
Review Comment:
You get a link time error due to missing symbol for each call to shmerr(..); Which expands to merr(...) -> _err(...)
So this fixes the dependency list
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7607: mm/shm: Implement shmem drivers for risc-v target
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7607:
URL: https://github.com/apache/incubator-nuttx/pull/7607
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org