You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by se...@apache.org on 2018/04/23 04:44:54 UTC
[02/17] flink git commit: [hotfix] [core] Fix checkstyle in
org.apache.flink.api.common.time
[hotfix] [core] Fix checkstyle in org.apache.flink.api.common.time
Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/deba8dc0
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/deba8dc0
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/deba8dc0
Branch: refs/heads/release-1.5
Commit: deba8dc0081c0484932bd27936c9e879c0188f0a
Parents: e244088
Author: Stephan Ewen <se...@apache.org>
Authored: Tue Apr 17 18:39:36 2018 +0200
Committer: Stephan Ewen <se...@apache.org>
Committed: Sun Apr 22 22:42:14 2018 +0200
----------------------------------------------------------------------
.../java/org/apache/flink/api/common/time/Deadline.java | 3 +++
.../main/java/org/apache/flink/api/common/time/Time.java | 9 +++++----
tools/maven/suppressions-core.xml | 2 +-
3 files changed, 9 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flink/blob/deba8dc0/flink-core/src/main/java/org/apache/flink/api/common/time/Deadline.java
----------------------------------------------------------------------
diff --git a/flink-core/src/main/java/org/apache/flink/api/common/time/Deadline.java b/flink-core/src/main/java/org/apache/flink/api/common/time/Deadline.java
index 2db6579..042c1e1 100644
--- a/flink-core/src/main/java/org/apache/flink/api/common/time/Deadline.java
+++ b/flink-core/src/main/java/org/apache/flink/api/common/time/Deadline.java
@@ -15,6 +15,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
+
package org.apache.flink.api.common.time;
import org.apache.flink.annotation.Internal;
@@ -26,6 +27,8 @@ import java.time.Duration;
*/
@Internal
public class Deadline {
+
+ /** The deadline, relative to {@link System#nanoTime()}. */
private final long timeNanos;
private Deadline(Duration time) {
http://git-wip-us.apache.org/repos/asf/flink/blob/deba8dc0/flink-core/src/main/java/org/apache/flink/api/common/time/Time.java
----------------------------------------------------------------------
diff --git a/flink-core/src/main/java/org/apache/flink/api/common/time/Time.java b/flink-core/src/main/java/org/apache/flink/api/common/time/Time.java
index 8883ddb..3063452 100644
--- a/flink-core/src/main/java/org/apache/flink/api/common/time/Time.java
+++ b/flink-core/src/main/java/org/apache/flink/api/common/time/Time.java
@@ -22,22 +22,23 @@ import org.apache.flink.annotation.PublicEvolving;
import java.io.Serializable;
import java.util.concurrent.TimeUnit;
+
import static org.apache.flink.util.Preconditions.checkNotNull;
/**
- * The definition of a time interval.
+ * The definition of a time interval. Similar to a simpler version of {@link java.time.Duration}.
*
- * Note: This class should replace org.apache.flink.streaming.api.windowing.time.Time in Flink 2.0
+ * <p>Note: This class will fully replace org.apache.flink.streaming.api.windowing.time.Time in Flink 2.0
*/
@PublicEvolving
public final class Time implements Serializable {
private static final long serialVersionUID = -350254188460915999L;
- /** The time unit for this policy's time interval */
+ /** The time unit for this policy's time interval. */
private final TimeUnit unit;
- /** The size of the windows generated by this policy */
+ /** The size of the windows generated by this policy. */
private final long size;
/** Instantiation only via factory method. */
http://git-wip-us.apache.org/repos/asf/flink/blob/deba8dc0/tools/maven/suppressions-core.xml
----------------------------------------------------------------------
diff --git a/tools/maven/suppressions-core.xml b/tools/maven/suppressions-core.xml
index ff9c203..83f8b72 100644
--- a/tools/maven/suppressions-core.xml
+++ b/tools/maven/suppressions-core.xml
@@ -88,7 +88,7 @@ under the License.
checks="AvoidStarImport"/>
<suppress
- files="(.*)api[/\\]common[/\\](cache|distributions|restartstrategy|time)[/\\](.*)"
+ files="(.*)api[/\\]common[/\\](cache|distributions|restartstrategy)[/\\](.*)"
checks="NewlineAtEndOfFile|RegexpSingleline|TodoComment|RedundantImport|ImportOrder|RedundantModifier|JavadocMethod|JavadocParagraph|JavadocType|JavadocStyle|PackageName|TypeNameCheck|ConstantNameCheck|StaticVariableNameCheck|MemberNameCheck|MethodNameCheck|ParameterName|LocalFinalVariableName|LocalVariableName|LeftCurly|UpperEll|FallThrough|reliefPattern|SimplifyBooleanExpression|EmptyStatement|ModifierOrder|EmptyLineSeparator|WhitespaceAround|WhitespaceAfter|NoWhitespaceAfter|NoWhitespaceBefore|OperatorWrap|ParenPad"/>
<suppress