You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/10/08 12:05:05 UTC

[GitHub] [cloudstack-terraform-provider] harikrishna-patnala opened a new pull request #8: Fix resource egress rule to accept protocol type ALL

harikrishna-patnala opened a new pull request #8:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/8


   This PR fixes #3 
   
   Previously only protocol types icmp, tcp, udp are supported, with this fix we have added support for protocol type ALL.
   
   Tested by following steps
   1. Created a egress rule using below config and "terraform apply" created the new egress rule
        resource "cloudstack_egress_firewall" "default" {
        network_id = "2047d8a9-789d-41e6-8eba-a7fa597d0c92"
        rule {
              protocol  = "ALL"
         }
   2. Removed the above config from configuration file and "terraform apply" deleted the above created rule
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-terraform-provider] rhtyd merged pull request #8: Fix resource egress rule to accept protocol type ALL

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #8:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/8


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-terraform-provider] harikrishna-patnala commented on pull request #8: Fix resource egress rule to accept protocol type ALL

Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #8:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/8#issuecomment-939747437


   I've tested this PR manually doing crud operations on resource egress firewall with both protocol types "ALL" and "icmp".
   
   Yes adding .travis.yml for the basic testing for all other PRs is a good idea. I'll add it as a different PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-terraform-provider] rhtyd commented on pull request #8: Fix resource egress rule to accept protocol type ALL

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #8:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/8#issuecomment-938589148


   This needs testing, how was it tested @harikrishna-patnala (could be maybe integrate .travis.yml to do something?)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org