You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2021/02/03 01:26:37 UTC
[GitHub] [hadoop] tomscut opened a new pull request #2676: Make some parameters configurable for DataNodeDiskMetrics
tomscut opened a new pull request #2676:
URL: https://github.com/apache/hadoop/pull/2676
JIRA: https://issues.apache.org/jira/browse/HDFS-15814
For ease of use, especially for small clusters, we can change some parameters(MIN_OUTLIER_DETECTION_DISKS, SLOW_DISK_LOW_THRESHOLD_MS) configurable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] tomscut commented on pull request #2676: Make some parameters configurable for DataNodeDiskMetrics
Posted by GitBox <gi...@apache.org>.
tomscut commented on pull request #2676:
URL: https://github.com/apache/hadoop/pull/2676#issuecomment-772976198
Failed junit tests:
hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage
hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes
hadoop.hdfs.TestReconstructStripedFile
hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
Sorry. I didn't update those four unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] tomscut commented on a change in pull request #2676: HDFS-15814. Make some parameters configurable for DataNodeDiskMetrics
Posted by GitBox <gi...@apache.org>.
tomscut commented on a change in pull request #2676:
URL: https://github.com/apache/hadoop/pull/2676#discussion_r574257636
##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/metrics/DataNodeDiskMetrics.java
##########
@@ -61,11 +61,26 @@
// code, status should not be overridden by daemon thread.
private boolean overrideStatus = true;
- public DataNodeDiskMetrics(DataNode dn, long diskOutlierDetectionIntervalMs) {
+ /**
+ * Minimum number of disks to run outlier detection.
+ */
+ private final long minOutlierDetectionDisks;
+ /**
+ * Threshold in milliseconds below which a disk is definitely not slow.
+ */
+ private final long lowThresholdMs;
+
+ public DataNodeDiskMetrics(DataNode dn, long diskOutlierDetectionIntervalMs, Configuration conf) {
this.dn = dn;
this.detectionInterval = diskOutlierDetectionIntervalMs;
- slowDiskDetector = new OutlierDetector(MIN_OUTLIER_DETECTION_DISKS,
- SLOW_DISK_LOW_THRESHOLD_MS);
Review comment:
Yeah, do we need to change anything else?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] tomscut commented on pull request #2676: Make some parameters configurable for DataNodeDiskMetrics
Posted by GitBox <gi...@apache.org>.
tomscut commented on pull request #2676:
URL: https://github.com/apache/hadoop/pull/2676#issuecomment-776398915
> The change looks pretty good to me. Please file an Apache jira.
>
> The failed tests look unrelated to your change.
Thank you for your review!
This is the Apache jira: https://issues.apache.org/jira/browse/HDFS-15814
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] tomscut commented on pull request #2676: HDFS-15814. Make some parameters configurable for DataNodeDiskMetrics
Posted by GitBox <gi...@apache.org>.
tomscut commented on pull request #2676:
URL: https://github.com/apache/hadoop/pull/2676#issuecomment-778719985
> Can you look at the 5 checkstyle warnings flagged above whether they were introduced by the patch?
Hi, Arpit. Thank you for your advice. I fixed the checkstyle warnings. And the failed test (hadoop.hdfs.TestRollingUpgrade ) is unrelated to the change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] arp7 commented on pull request #2676: HDFS-15814. Make some parameters configurable for DataNodeDiskMetrics
Posted by GitBox <gi...@apache.org>.
arp7 commented on pull request #2676:
URL: https://github.com/apache/hadoop/pull/2676#issuecomment-778285608
Can you look at the 5 checkstyle warnings flagged above whether they were introduced by the patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] tomscut commented on pull request #2676: HDFS-15814. Make some parameters configurable for DataNodeDiskMetrics
Posted by GitBox <gi...@apache.org>.
tomscut commented on pull request #2676:
URL: https://github.com/apache/hadoop/pull/2676#issuecomment-778772628
Thanks @arp7 and @dineshchitlangia .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] arp7 commented on pull request #2676: Make some parameters configurable for DataNodeDiskMetrics
Posted by GitBox <gi...@apache.org>.
arp7 commented on pull request #2676:
URL: https://github.com/apache/hadoop/pull/2676#issuecomment-776033576
The change looks pretty good to me. Please file an Apache jira.
The failed tests look unrelated to your change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] tomscut commented on a change in pull request #2676: HDFS-15814. Make some parameters configurable for DataNodeDiskMetrics
Posted by GitBox <gi...@apache.org>.
tomscut commented on a change in pull request #2676:
URL: https://github.com/apache/hadoop/pull/2676#discussion_r574258014
##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/metrics/DataNodeDiskMetrics.java
##########
@@ -61,11 +61,26 @@
// code, status should not be overridden by daemon thread.
private boolean overrideStatus = true;
- public DataNodeDiskMetrics(DataNode dn, long diskOutlierDetectionIntervalMs) {
+ /**
+ * Minimum number of disks to run outlier detection.
+ */
+ private final long minOutlierDetectionDisks;
+ /**
+ * Threshold in milliseconds below which a disk is definitely not slow.
+ */
+ private final long lowThresholdMs;
+
+ public DataNodeDiskMetrics(DataNode dn, long diskOutlierDetectionIntervalMs, Configuration conf) {
this.dn = dn;
this.detectionInterval = diskOutlierDetectionIntervalMs;
- slowDiskDetector = new OutlierDetector(MIN_OUTLIER_DETECTION_DISKS,
- SLOW_DISK_LOW_THRESHOLD_MS);
Review comment:
If the code is merged, the unused parameters will be removed. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] tomscut commented on a change in pull request #2676: HDFS-15814. Make some parameters configurable for DataNodeDiskMetrics
Posted by GitBox <gi...@apache.org>.
tomscut commented on a change in pull request #2676:
URL: https://github.com/apache/hadoop/pull/2676#discussion_r574257636
##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/metrics/DataNodeDiskMetrics.java
##########
@@ -61,11 +61,26 @@
// code, status should not be overridden by daemon thread.
private boolean overrideStatus = true;
- public DataNodeDiskMetrics(DataNode dn, long diskOutlierDetectionIntervalMs) {
+ /**
+ * Minimum number of disks to run outlier detection.
+ */
+ private final long minOutlierDetectionDisks;
+ /**
+ * Threshold in milliseconds below which a disk is definitely not slow.
+ */
+ private final long lowThresholdMs;
+
+ public DataNodeDiskMetrics(DataNode dn, long diskOutlierDetectionIntervalMs, Configuration conf) {
this.dn = dn;
this.detectionInterval = diskOutlierDetectionIntervalMs;
- slowDiskDetector = new OutlierDetector(MIN_OUTLIER_DETECTION_DISKS,
- SLOW_DISK_LOW_THRESHOLD_MS);
Review comment:
Yeah, do we need to change anything else?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2676: Make some parameters configurable for DataNodeDiskMetrics
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2676:
URL: https://github.com/apache/hadoop/pull/2676#issuecomment-772264655
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 1m 18s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 34m 49s | | trunk passed |
| +1 :green_heart: | compile | 1m 21s | | trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 1m 13s | | trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01 |
| +1 :green_heart: | checkstyle | 1m 12s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 19s | | trunk passed |
| +1 :green_heart: | shadedclient | 17m 34s | | branch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 55s | | trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 28s | | trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01 |
| +0 :ok: | spotbugs | 3m 13s | | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 3m 11s | | trunk passed |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 18s | | the patch passed |
| +1 :green_heart: | compile | 1m 17s | | the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javac | 1m 17s | | the patch passed |
| +1 :green_heart: | compile | 1m 8s | | the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01 |
| +1 :green_heart: | javac | 1m 8s | | the patch passed |
| -0 :warning: | checkstyle | 1m 4s | [/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2676/1/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt) | hadoop-hdfs-project/hadoop-hdfs: The patch generated 5 new + 611 unchanged - 2 fixed = 616 total (was 613) |
| +1 :green_heart: | mvnsite | 1m 15s | | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | | The patch has no ill-formed XML file. |
| +1 :green_heart: | shadedclient | 15m 27s | | patch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 49s | | the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 23s | | the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01 |
| +1 :green_heart: | findbugs | 3m 17s | | the patch passed |
|||| _ Other Tests _ |
| -1 :x: | unit | 215m 33s | [/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2676/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt) | hadoop-hdfs in the patch passed. |
| +1 :green_heart: | asflicense | 0m 37s | | The patch does not generate ASF License warnings. |
| | | 308m 54s | | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage |
| | hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes |
| | hadoop.hdfs.TestReconstructStripedFile |
| | hadoop.hdfs.server.namenode.TestNamenodeCapacityReport |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2676/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/2676 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml |
| uname | Linux 16c46c9927cc 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / f37bf651993 |
| Default Java | Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2676/1/testReport/ |
| Max. process+thread count | 2252 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2676/1/console |
| versions | git=2.25.1 maven=3.6.3 findbugs=4.0.6 |
| Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] tomscut commented on a change in pull request #2676: HDFS-15814. Make some parameters configurable for DataNodeDiskMetrics
Posted by GitBox <gi...@apache.org>.
tomscut commented on a change in pull request #2676:
URL: https://github.com/apache/hadoop/pull/2676#discussion_r574994811
##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/metrics/DataNodeDiskMetrics.java
##########
@@ -61,11 +61,26 @@
// code, status should not be overridden by daemon thread.
private boolean overrideStatus = true;
- public DataNodeDiskMetrics(DataNode dn, long diskOutlierDetectionIntervalMs) {
+ /**
+ * Minimum number of disks to run outlier detection.
+ */
+ private final long minOutlierDetectionDisks;
+ /**
+ * Threshold in milliseconds below which a disk is definitely not slow.
+ */
+ private final long lowThresholdMs;
+
+ public DataNodeDiskMetrics(DataNode dn, long diskOutlierDetectionIntervalMs, Configuration conf) {
this.dn = dn;
this.detectionInterval = diskOutlierDetectionIntervalMs;
- slowDiskDetector = new OutlierDetector(MIN_OUTLIER_DETECTION_DISKS,
- SLOW_DISK_LOW_THRESHOLD_MS);
Review comment:
Hi Arpit, I've removed these old constants. Is there anything else I need to change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] tomscut commented on pull request #2676: Make some parameters configurable for DataNodeDiskMetrics
Posted by GitBox <gi...@apache.org>.
tomscut commented on pull request #2676:
URL: https://github.com/apache/hadoop/pull/2676#issuecomment-775602310
@hanishakoneru
Hi Hanisha Koneru, could you please review the code for me? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] arp7 commented on a change in pull request #2676: HDFS-15814. Make some parameters configurable for DataNodeDiskMetrics
Posted by GitBox <gi...@apache.org>.
arp7 commented on a change in pull request #2676:
URL: https://github.com/apache/hadoop/pull/2676#discussion_r573465457
##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/metrics/DataNodeDiskMetrics.java
##########
@@ -61,11 +61,26 @@
// code, status should not be overridden by daemon thread.
private boolean overrideStatus = true;
- public DataNodeDiskMetrics(DataNode dn, long diskOutlierDetectionIntervalMs) {
+ /**
+ * Minimum number of disks to run outlier detection.
+ */
+ private final long minOutlierDetectionDisks;
+ /**
+ * Threshold in milliseconds below which a disk is definitely not slow.
+ */
+ private final long lowThresholdMs;
+
+ public DataNodeDiskMetrics(DataNode dn, long diskOutlierDetectionIntervalMs, Configuration conf) {
this.dn = dn;
this.detectionInterval = diskOutlierDetectionIntervalMs;
- slowDiskDetector = new OutlierDetector(MIN_OUTLIER_DETECTION_DISKS,
- SLOW_DISK_LOW_THRESHOLD_MS);
Review comment:
Let's remove these old constants since they should be unused now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2676: HDFS-15814. Make some parameters configurable for DataNodeDiskMetrics
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2676:
URL: https://github.com/apache/hadoop/pull/2676#issuecomment-778656166
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 24m 52s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 35m 2s | | trunk passed |
| +1 :green_heart: | compile | 1m 20s | | trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 1m 11s | | trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | checkstyle | 1m 9s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 22s | | trunk passed |
| +1 :green_heart: | shadedclient | 18m 23s | | branch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 53s | | trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 23s | | trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +0 :ok: | spotbugs | 3m 15s | | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 3m 13s | | trunk passed |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 14s | | the patch passed |
| +1 :green_heart: | compile | 1m 16s | | the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javac | 1m 16s | | the patch passed |
| +1 :green_heart: | compile | 1m 9s | | the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | javac | 1m 9s | | the patch passed |
| +1 :green_heart: | checkstyle | 1m 5s | | hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 612 unchanged - 2 fixed = 612 total (was 614) |
| +1 :green_heart: | mvnsite | 1m 13s | | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | | The patch has no ill-formed XML file. |
| +1 :green_heart: | shadedclient | 14m 54s | | patch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 48s | | the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 19s | | the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | findbugs | 3m 12s | | the patch passed |
|||| _ Other Tests _ |
| -1 :x: | unit | 213m 49s | [/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2676/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt) | hadoop-hdfs in the patch passed. |
| +1 :green_heart: | asflicense | 0m 35s | | The patch does not generate ASF License warnings. |
| | | 330m 25s | | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hdfs.TestRollingUpgrade |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2676/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/2676 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml |
| uname | Linux df5455cfa77e 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / f9a073c6c18 |
| Default Java | Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2676/2/testReport/ |
| Max. process+thread count | 2456 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2676/2/console |
| versions | git=2.25.1 maven=3.6.3 findbugs=4.0.6 |
| Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] dineshchitlangia merged pull request #2676: HDFS-15814. Make some parameters configurable for DataNodeDiskMetrics
Posted by GitBox <gi...@apache.org>.
dineshchitlangia merged pull request #2676:
URL: https://github.com/apache/hadoop/pull/2676
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] arp7 commented on a change in pull request #2676: HDFS-15814. Make some parameters configurable for DataNodeDiskMetrics
Posted by GitBox <gi...@apache.org>.
arp7 commented on a change in pull request #2676:
URL: https://github.com/apache/hadoop/pull/2676#discussion_r575331330
##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/metrics/DataNodeDiskMetrics.java
##########
@@ -61,11 +61,26 @@
// code, status should not be overridden by daemon thread.
private boolean overrideStatus = true;
- public DataNodeDiskMetrics(DataNode dn, long diskOutlierDetectionIntervalMs) {
+ /**
+ * Minimum number of disks to run outlier detection.
+ */
+ private final long minOutlierDetectionDisks;
+ /**
+ * Threshold in milliseconds below which a disk is definitely not slow.
+ */
+ private final long lowThresholdMs;
+
+ public DataNodeDiskMetrics(DataNode dn, long diskOutlierDetectionIntervalMs, Configuration conf) {
this.dn = dn;
this.detectionInterval = diskOutlierDetectionIntervalMs;
- slowDiskDetector = new OutlierDetector(MIN_OUTLIER_DETECTION_DISKS,
- SLOW_DISK_LOW_THRESHOLD_MS);
Review comment:
Ah I missed that. The change LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org