You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/10/24 01:35:59 UTC

[GitHub] [incubator-devlake] keon94 commented on a diff in pull request #3532: fix: fix lake crushed when pipeline.beginAt is nil

keon94 commented on code in PR #3532:
URL: https://github.com/apache/incubator-devlake/pull/3532#discussion_r1002816718


##########
services/pipeline_runner.go:
##########
@@ -122,7 +122,10 @@ func runPipeline(pipelineId uint64) errors.Error {
 	// finished, update database
 	finishedAt := time.Now()
 	pipeline.FinishedAt = &finishedAt

Review Comment:
   In my opinion we should avoid a nil BeganAt value altogether, and fix the logic here instead:
   https://github.com/apache/incubator-devlake/blob/7853386b27f68ebba7eb266b854a731f60db6d76/services/pipeline_helper.go#L39
   
   We should set the BeganAt field on DbPipeline when we create it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org