[GitHub] [calcite] FaxianZhao commented on a change in pull request #1188: [CALCITE-3034] CSV test case description does not match it's code logic

[GitBox <gi...@apache.org>]

FaxianZhao commented on a change in pull request #1188: [CALCITE-3034] CSV test case description does not match it's code logic
URL: https://github.com/apache/calcite/pull/1188#discussion_r279316235
 
 

 ##########
 File path: example/csv/src/main/java/org/apache/calcite/adapter/csv/CsvFilterableTable.java
 ##########
 @@ -63,7 +63,11 @@ public String toString() {
   }
 
   private boolean addFilter(RexNode filter, Object[] filterValues) {
-    if (filter.isA(SqlKind.EQUALS)) {
+    if (filter.isA(SqlKind.AND)) {
 
 Review comment:
   I think `OR` is useless for generating `filterValues`. When o.a.c.a.c.CsvEnumerator#moveNext read rows from source, it will filter the rows which isn't match `filterValues`.
   If we do, the rows are suited for others operands of `OR` will be filtered by `filterValues`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services