[GitHub] [spark] cloud-fan commented on a change in pull request #26717: [SPARK-30077][SQL] Create TEMPORARY VIEW USING should look up catalog/table like v2 commands

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #26717: [SPARK-30077][SQL] Create TEMPORARY VIEW USING should look up catalog/table like v2 commands
URL: https://github.com/apache/spark/pull/26717#discussion_r353597331
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statements.scala
 ##########
 @@ -101,6 +101,17 @@ case class CreateViewStatement(
     replace: Boolean,
     viewType: ViewType) extends ParsedStatement
 
+/**
+ * A CREATE TEMP VIEW USING statement, as parsed from SQL.
+ */
+case class CreateTempViewUsingStatement(
 
 Review comment:
   I'm not sure we need it. We use statements for commands that have both v1 and v2 versions, and we need to pick one in the analyzer.
   
   temp view is managed by Spark itself, so we only have one command for CREATE TEMP VIEW USING. We should just reuse the existing `CreateTempViewUsing` command.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org