You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/01/03 03:53:30 UTC

[GitHub] sijie opened a new pull request #937: Issue 935: Issue 915: Part 3 - Make circe-checksum module work for both java 8 and java 9

sijie opened a new pull request #937: Issue 935: Issue 915: Part 3 - Make circe-checksum module work for both java 8 and java 9
URL: https://github.com/apache/bookkeeper/pull/937
 
 
   Descriptions of the changes in this PR:
   
       - switch from jmockit to mockito, and from testng to junit. make testing and mocking framework consistent across modules.
       - skip `-Werror` check in circe-checksum since `finalize` is deprecated at java 9
       - change CRC32CDigestManager to use `circe-checksum` module
       - fix shading to include `circe-checksum`
   
   This change is based #917 . Gitsha 73049f8 contains the changes to make circe-checksum module work for both java8 and java9.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services