[GitHub] [iceberg] rdblue commented on a change in pull request #2228: Hive: Implement multi-table inserts

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #2228:
URL: https://github.com/apache/iceberg/pull/2228#discussion_r597882573



##########
File path: mr/src/main/java/org/apache/iceberg/mr/InputFormatConfig.java
##########
@@ -58,8 +58,11 @@ private InputFormatConfig() {
   public static final String LOCATION_PROVIDER = "iceberg.mr.location.provider";
   public static final String ENCRYPTION_MANAGER = "iceberg.mr.encription.manager";
 
-  public static final String COMMIT_THREAD_POOL_SIZE = "iceberg.mr.commit.thread.pool.size";
-  public static final int COMMIT_THREAD_POOL_SIZE_DEFAULT = 10;
+  public static final String OUTPUT_TABLES = "iceberg.mr.output.tables";
+  public static final String COMMIT_TABLE_THREAD_POOL_SIZE = "iceberg.mr.commit.table.thread.pool.size";

Review comment:
       Why not use the same thread pool? And why use a thread pool at all? This could be done serially.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org