You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/06 21:32:35 UTC
[GitHub] [beam] ryanthompson591 opened a new pull request, #21728: Create template for failing tests.
ryanthompson591 opened a new pull request, #21728:
URL: https://github.com/apache/beam/pull/21728
This is a template for when tests are red and makes creating failing test issues easier.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Add a link to the appropriate issue in your description, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #21728: Create template for failing tests.
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21728:
URL: https://github.com/apache/beam/pull/21728#issuecomment-1322404807
> I think I fixed the merge problem. Have a look. One of the problems I have, is I don't have a good way to test this change to see if it works. Do you know how to do that?
If you merge it into master of your repo, you can try creating issues and validate that it does the right thing (that should give you the template).
If you don't want to do that in your main repo, you can copy the templates and labeler actions config to a test repo, that's a little more work but keeps your fork clean
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ryanthompson591 commented on a diff in pull request #21728: Create template for failing tests.
Posted by GitBox <gi...@apache.org>.
ryanthompson591 commented on code in PR #21728:
URL: https://github.com/apache/beam/pull/21728#discussion_r1028311323
##########
.github/ISSUE_TEMPLATE/failing_test.yml:
##########
@@ -0,0 +1,45 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Failing Test
+description: Report a failing test
+title: "[Failing Test]: "
+labels: ["bug", "awaiting triage", "test-failures", "P1"]
+assignees:
+ - octocat
+body:
+ - type: markdown
+ attributes:
+ value: |
+ Thanks for taking the time to report this test failure!
+ - type: textarea
+ id: what-happened
+ attributes:
+ label: What happened?
+ description: Please name which test is failing.
+ placeholder: |
+ If possible include: when the test started failing, a jenkins link, and any initial debugging you've done.
+
+ If this isn't a bug and you have a question or support request, please email user@apache.beam.com with a description of the problem instead of opening this issue.
+ - type: dropdown
+ id: flakey
+ attributes:
+ label: Issue Component
Review Comment:
I think this comment is resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #21728: Create template for failing tests.
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #21728:
URL: https://github.com/apache/beam/pull/21728#discussion_r891254693
##########
.github/ISSUE_TEMPLATE/failing_test.yml:
##########
@@ -0,0 +1,45 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Failing Test
+description: Report a failing test
+title: "[Failing Test]: "
+labels: ["bug", "awaiting triage", "test-failures", "P1"]
+assignees:
+ - octocat
+body:
+ - type: markdown
+ attributes:
+ value: |
+ Thanks for taking the time to report this test failure!
+ - type: textarea
+ id: what-happened
+ attributes:
+ label: What happened?
+ description: Please name which test is failing.
+ placeholder: |
+ If possible include: when the test started failing, a jenkins link, and any initial debugging you've done.
+
+ If this isn't a bug and you have a question or support request, please email user@apache.beam.com with a description of the problem instead of opening this issue.
+ - type: dropdown
+ id: flakey
+ attributes:
+ label: Issue Component
Review Comment:
This should probably be something like "Is this test flaky or consistently failing?"
##########
.github/ISSUE_TEMPLATE/failing_test.yml:
##########
@@ -0,0 +1,45 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Failing Test
+description: Report a failing test
+title: "[Failing Test]: "
+labels: ["bug", "awaiting triage", "test-failures", "P1"]
+assignees:
+ - octocat
+body:
+ - type: markdown
+ attributes:
+ value: |
+ Thanks for taking the time to report this test failure!
+ - type: textarea
+ id: what-happened
+ attributes:
+ label: What happened?
+ description: Please name which test is failing.
+ placeholder: |
+ If possible include: when the test started failing, a jenkins link, and any initial debugging you've done.
+
+ If this isn't a bug and you have a question or support request, please email user@apache.beam.com with a description of the problem instead of opening this issue.
+ - type: dropdown
+ id: flakey
+ attributes:
+ label: Issue Component
+ options:
+ - "flakey"
+ - "red"
Review Comment:
```suggestion
- "Test is flaky"
- "Test is consistently failing"
```
Then in the tagging config we can search for the string "Test is flaky" and add the flaky label.
Also prefer spelling flaky instead of flakey for consistency with existing labels
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ryanthompson591 commented on pull request #21728: Create template for failing tests.
Posted by GitBox <gi...@apache.org>.
ryanthompson591 commented on PR #21728:
URL: https://github.com/apache/beam/pull/21728#issuecomment-1322549454
I tried this out in my repo and it worked fine. It's a good thing I tested this first because I needed a small change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #21728: Create template for failing tests.
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #21728:
URL: https://github.com/apache/beam/pull/21728#discussion_r891330757
##########
.github/ISSUE_TEMPLATE/failing_test.yml:
##########
@@ -0,0 +1,45 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Failing Test
+description: Report a failing test
+title: "[Failing Test]: "
+labels: ["bug", "awaiting triage", "test-failures", "P1"]
+assignees:
+ - octocat
+body:
+ - type: markdown
+ attributes:
+ value: |
+ Thanks for taking the time to report this test failure!
+ - type: textarea
+ id: what-happened
+ attributes:
+ label: What happened?
+ description: Please name which test is failing.
+ placeholder: |
+ If possible include: when the test started failing, a jenkins link, and any initial debugging you've done.
+
+ If this isn't a bug and you have a question or support request, please email user@apache.beam.com with a description of the problem instead of opening this issue.
+ - type: dropdown
+ id: flakey
+ attributes:
+ label: Issue Component
+ options:
+ - "flakey"
+ - "red"
Review Comment:
Could you also update the wording to something like "Test is consistently failing"/"Test is flaky"? A newer contributor might not grok the difference between red and flaky (because a flaky test is sometimes red), **and** that gives us a string to search for in our labeler config.
Second, would you mind adding:
```
- contains: 'Test is flaky' # (or whatever string you decide on)
addLabels: ['flaky']
```
to the rules in [.github/issue-rules.yml](https://github.com/apache/beam/blob/master/.github/issue-rules.yml)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #21728: Create template for failing tests.
Posted by GitBox <gi...@apache.org>.
aaltay commented on PR #21728:
URL: https://github.com/apache/beam/pull/21728#issuecomment-1159352790
What is the next step on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #21728: Create template for failing tests.
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21728:
URL: https://github.com/apache/beam/pull/21728#issuecomment-1322305494
Looks like you got a weird merge, merging in beam/master might fix though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ryanthompson591 commented on a diff in pull request #21728: Create template for failing tests.
Posted by GitBox <gi...@apache.org>.
ryanthompson591 commented on code in PR #21728:
URL: https://github.com/apache/beam/pull/21728#discussion_r891280719
##########
.github/ISSUE_TEMPLATE/failing_test.yml:
##########
@@ -0,0 +1,45 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Failing Test
+description: Report a failing test
+title: "[Failing Test]: "
+labels: ["bug", "awaiting triage", "test-failures", "P1"]
+assignees:
+ - octocat
+body:
+ - type: markdown
+ attributes:
+ value: |
+ Thanks for taking the time to report this test failure!
+ - type: textarea
+ id: what-happened
+ attributes:
+ label: What happened?
+ description: Please name which test is failing.
+ placeholder: |
+ If possible include: when the test started failing, a jenkins link, and any initial debugging you've done.
+
+ If this isn't a bug and you have a question or support request, please email user@apache.beam.com with a description of the problem instead of opening this issue.
+ - type: dropdown
+ id: flakey
+ attributes:
+ label: Issue Component
+ options:
+ - "flakey"
+ - "red"
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ryanthompson591 commented on a diff in pull request #21728: Create template for failing tests.
Posted by GitBox <gi...@apache.org>.
ryanthompson591 commented on code in PR #21728:
URL: https://github.com/apache/beam/pull/21728#discussion_r890661761
##########
.github/ISSUE_TEMPLATE/failing_test.yml:
##########
@@ -0,0 +1,39 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Bug Report
+description: File a bug report
Review Comment:
Done.
##########
.github/ISSUE_TEMPLATE/failing_test.yml:
##########
@@ -0,0 +1,39 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Bug Report
+description: File a bug report
+title: "[Failing Test]: "
+labels: ["bug", "awaiting triage", "Component: test-failures", "Priority: 1"]
+assignees:
+ - octocat
+body:
+ - type: markdown
+ attributes:
+ value: |
+ Thanks for taking the time to fill out this bug report!
+ - type: textarea
+ id: what-happened
+ attributes:
+ label: What happened?
+ description: Please name which test is failing.
+ placeholder: |
+ If possible include: when the test started failing, a jenkins link, and any initial debugging you've done.
+
+ If this isn't a bug and you have a question or support request, please email user@apache.beam.com with a description of the problem instead of opening this issue.
+ validations:
+ required: true
Review Comment:
Looks like no checkboxes yet.
https://github.com/damccorm/tag-ur-it/issues/21
How about a dropdown with an option to mark flakey or red.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21728: Create template for failing tests.
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21728:
URL: https://github.com/apache/beam/pull/21728#issuecomment-1147953904
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21728: Create template for failing tests.
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21728:
URL: https://github.com/apache/beam/pull/21728#issuecomment-1147953902
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #21728: Create template for failing tests.
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #21728:
URL: https://github.com/apache/beam/pull/21728#discussion_r890594391
##########
.github/ISSUE_TEMPLATE/failing_test.yml:
##########
@@ -0,0 +1,39 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Bug Report
+description: File a bug report
+title: "[Failing Test]: "
+labels: ["bug", "awaiting triage", "Component: test-failures", "Priority: 1"]
Review Comment:
```suggestion
labels: ["bug", "awaiting triage", "test-failures", "P1"]
```
The component is used by automation to identify the label, but its not part of the label itself (same with Priority)
##########
.github/ISSUE_TEMPLATE/failing_test.yml:
##########
@@ -0,0 +1,39 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Bug Report
+description: File a bug report
+title: "[Failing Test]: "
+labels: ["bug", "awaiting triage", "Component: test-failures", "Priority: 1"]
+assignees:
+ - octocat
+body:
+ - type: markdown
+ attributes:
+ value: |
+ Thanks for taking the time to fill out this bug report!
Review Comment:
```suggestion
Thanks for taking the time to report this test failure!
```
##########
.github/ISSUE_TEMPLATE/failing_test.yml:
##########
@@ -0,0 +1,39 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Bug Report
+description: File a bug report
Review Comment:
These probably need to be changed to something like "Failing Test"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #21728: Create template for failing tests.
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #21728:
URL: https://github.com/apache/beam/pull/21728#discussion_r890597964
##########
.github/ISSUE_TEMPLATE/failing_test.yml:
##########
@@ -0,0 +1,39 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Bug Report
+description: File a bug report
+title: "[Failing Test]: "
+labels: ["bug", "awaiting triage", "Component: test-failures", "Priority: 1"]
+assignees:
+ - octocat
+body:
+ - type: markdown
+ attributes:
+ value: |
+ Thanks for taking the time to fill out this bug report!
+ - type: textarea
+ id: what-happened
+ attributes:
+ label: What happened?
+ description: Please name which test is failing.
+ placeholder: |
+ If possible include: when the test started failing, a jenkins link, and any initial debugging you've done.
+
+ If this isn't a bug and you have a question or support request, please email user@apache.beam.com with a description of the problem instead of opening this issue.
+ validations:
+ required: true
Review Comment:
Might be good to add a check box as well that asks something along the lines of "Is this a known flaky test?"
I expect someone reporting a flaky test would be reasonably likely to choose this template, so it would be good to cover that one. You could even add an entry to this file - https://github.com/apache/beam/blob/3c623abd631b493c8a71d05fe591065754c75d0c/.github/issue-rules.yml#L17 - so that it automatically gets labeled "flaky" (docs on how that file works are here - https://github.com/damccorm/tag-ur-it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm merged pull request #21728: Create template for failing tests.
Posted by GitBox <gi...@apache.org>.
damccorm merged PR #21728:
URL: https://github.com/apache/beam/pull/21728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #21728: Create template for failing tests.
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #21728:
URL: https://github.com/apache/beam/pull/21728#discussion_r1028325706
##########
.github/ISSUE_TEMPLATE/failing_test.yml:
##########
@@ -0,0 +1,171 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Failing Test
+description: Report a failing test
+title: "[Failing Test]: "
+labels: ["bug", "awaiting triage", "test-failures"]
Review Comment:
```suggestion
labels: ["bug", "awaiting triage", "failing test"]
```
We switched this label
##########
.github/ISSUE_TEMPLATE/failing_test.yml:
##########
@@ -0,0 +1,171 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Failing Test
+description: Report a failing test
+title: "[Failing Test]: "
+labels: ["bug", "awaiting triage", "test-failures"]
+assignees:
+ - octocat
+body:
+ - type: markdown
+ attributes:
+ value: |
+ Thanks for taking the time to report this test failure! Once you've created an issue, you can self-assign by commenting `.take-issue` and you can close by commenting `.close-issue`.
Review Comment:
Could you please match the sentences in https://github.com/apache/beam/blob/aa4c076b6253028ca795dd7b25e4088f9334a023/.github/ISSUE_TEMPLATE/bug.yml
##########
.github/ISSUE_TEMPLATE/failing_test.yml:
##########
@@ -0,0 +1,171 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Failing Test
+description: Report a failing test
+title: "[Failing Test]: "
+labels: ["bug", "awaiting triage", "test-failures"]
+assignees:
+ - octocat
+body:
+ - type: markdown
+ attributes:
+ value: |
+ Thanks for taking the time to report this test failure! Once you've created an issue, you can self-assign by commenting `.take-issue` and you can close by commenting `.close-issue`.
+ - type: textarea
+ id: what-happened
+ attributes:
+ label: What happened?
+ description: Please name which test is failing.
+ placeholder: |
+ If possible include: when the test started failing, a jenkins link, and any initial debugging you've done.
+
+ If this isn't a bug and you have a question or support request, please email user@apache.beam.com with a description of the problem instead of opening this issue.
+ - type: dropdown
+ id: failure
+ attributes:
+ label: Issue Failure
+ options:
+ - "Test is flaky"
+ - "Test is continually failing"
+ required: true
Review Comment:
```suggestion
validations:
required: true
```
##########
.github/ISSUE_TEMPLATE/failing_test.yml:
##########
@@ -0,0 +1,171 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Failing Test
+description: Report a failing test
+title: "[Failing Test]: "
+labels: ["bug", "awaiting triage", "test-failures"]
+assignees:
+ - octocat
+body:
+ - type: markdown
+ attributes:
+ value: |
+ Thanks for taking the time to report this test failure! Once you've created an issue, you can self-assign by commenting `.take-issue` and you can close by commenting `.close-issue`.
+ - type: textarea
+ id: what-happened
+ attributes:
+ label: What happened?
+ description: Please name which test is failing.
+ placeholder: |
+ If possible include: when the test started failing, a jenkins link, and any initial debugging you've done.
+
+ If this isn't a bug and you have a question or support request, please email user@apache.beam.com with a description of the problem instead of opening this issue.
+ - type: dropdown
+ id: failure
+ attributes:
+ label: Issue Failure
+ options:
+ - "Test is flaky"
+ - "Test is continually failing"
Review Comment:
```suggestion
- "Failure: Test is flaky"
- "Failure: Test is continually failing"
```
This will allow the bot to pick it up since your config is:
```
- valueFor: 'Failure'
contains: 'Test is flaky'
addLabels: ['flaky', 'tests']
- valueFor: 'Failure'
contains: 'Test is continually failing'
addLabels: ['permared', 'failing test', 'tests']
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ryanthompson591 commented on a diff in pull request #21728: Create template for failing tests.
Posted by GitBox <gi...@apache.org>.
ryanthompson591 commented on code in PR #21728:
URL: https://github.com/apache/beam/pull/21728#discussion_r1028443552
##########
.github/ISSUE_TEMPLATE/failing_test.yml:
##########
@@ -0,0 +1,171 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Failing Test
+description: Report a failing test
+title: "[Failing Test]: "
+labels: ["bug", "awaiting triage", "test-failures"]
+assignees:
+ - octocat
+body:
+ - type: markdown
+ attributes:
+ value: |
+ Thanks for taking the time to report this test failure! Once you've created an issue, you can self-assign by commenting `.take-issue` and you can close by commenting `.close-issue`.
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #21728: Create template for failing tests.
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #21728:
URL: https://github.com/apache/beam/pull/21728#issuecomment-1148090574
# [Codecov](https://codecov.io/gh/apache/beam/pull/21728?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21728](https://codecov.io/gh/apache/beam/pull/21728?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3c623ab) into [master](https://codecov.io/gh/apache/beam/commit/3c623abd631b493c8a71d05fe591065754c75d0c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3c623ab) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 3c623ab differs from pull request most recent head fa6e0c6. Consider uploading reports for the commit fa6e0c6 to get more accurate results
```diff
@@ Coverage Diff @@
## master #21728 +/- ##
=======================================
Coverage 74.03% 74.03%
=======================================
Files 698 698
Lines 92131 92131
=======================================
Hits 68208 68208
Misses 22672 22672
Partials 1251 1251
```
| Flag | Coverage Δ | |
|---|---|---|
| go | `50.95% <0.00%> (ø)` | |
| python | `83.62% <0.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/21728?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/21728?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3c623ab...fa6e0c6](https://codecov.io/gh/apache/beam/pull/21728?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #21728: Create template for failing tests.
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #21728:
URL: https://github.com/apache/beam/pull/21728#discussion_r891841089
##########
.github/issue-rules.yml:
##########
@@ -344,6 +344,12 @@ rules:
- valueFor: 'Component'
contains: 'sdk-typescript'
addLabels: ['sdk-typescript']
+- valueFor: 'Component'
+ contains: 'Test is flaky'
+ addLabels: ['flaky']
+- valueFor: 'Component'
+ contains: 'Test is continually failing'
+ addLabels: ['failing']
Review Comment:
I'd cut this label or make it `permared` (or something similar). We're already applying the `test-failures` label, so this doesn't add much
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #21728: Create template for failing tests.
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #21728:
URL: https://github.com/apache/beam/pull/21728#discussion_r902524572
##########
.github/ISSUE_TEMPLATE/failing_test.yml:
##########
@@ -0,0 +1,45 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Failing Test
+description: Report a failing test
+title: "[Failing Test]: "
+labels: ["bug", "awaiting triage", "test-failures", "P1"]
+assignees:
+ - octocat
+body:
+ - type: markdown
+ attributes:
+ value: |
+ Thanks for taking the time to report this test failure!
Review Comment:
```suggestion
Thanks for taking the time to report this test failure! Once you've created an issue, you can self-assign by commenting `.take-issue` and you can close by commenting `.close-issue`.
```
We recently added this to the other templates
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org