[GitHub] spark pull request #14773: [SPARK-17203][SQL] data source options should alw...

[clockfly <gi...@git.apache.org>]

Github user clockfly commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14773#discussion_r77294893
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ddl.scala ---
    @@ -90,17 +90,31 @@ case class RefreshResource(path: String)
     /**
      * Builds a map in which keys are case insensitive
      */
    -class CaseInsensitiveMap(map: Map[String, String]) extends Map[String, String]
    +class CaseInsensitiveMap[T] private(baseMap: Map[String, T]) extends Map[String, T]
       with Serializable {
     
    -  val baseMap = map.map(kv => kv.copy(_1 = kv._1.toLowerCase))
    +  override def get(k: String): Option[T] = baseMap.get(k.toLowerCase)
     
    -  override def get(k: String): Option[String] = baseMap.get(k.toLowerCase)
    +  override def + [B1 >: T](kv: (String, B1)): Map[String, B1] =
    +    new CaseInsensitiveMap(baseMap + kv.copy(_1 = kv._1.toLowerCase))
     
    -  override def + [B1 >: String](kv: (String, B1)): Map[String, B1] =
    -    baseMap + kv.copy(_1 = kv._1.toLowerCase)
    +  override def iterator: Iterator[(String, T)] = baseMap.iterator
     
    -  override def iterator: Iterator[(String, String)] = baseMap.iterator
    +  override def -(key: String): Map[String, T] =
    +    new CaseInsensitiveMap(baseMap - key.toLowerCase)
    +}
     
    -  override def -(key: String): Map[String, String] = baseMap - key.toLowerCase
    +object CaseInsensitiveMap {
    +  def apply[T](map: Map[String, T]): CaseInsensitiveMap[T] = {
    +    val lowercaseKeys = map.keys.map(_.toLowerCase)
    +    if (lowercaseKeys.toSet.size != map.size) {
    +      val duplicatedKeys = lowercaseKeys.groupBy(identity).collect {
    +        case (x, ys) if ys.size > 1 => x
    +      }
    +      throw new AnalysisException(
    --- End diff --
    
    Why it is a AnalysisException? This class is only supposed to be used at driver?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org