You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "NihalJain (via GitHub)" <gi...@apache.org> on 2025/03/11 20:13:43 UTC
[PR] [WIP] Add a jetty 12 module with EE8 [hbase-thirdparty]
NihalJain opened a new pull request, #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2760539366
> Should we move `org.eclipse.jetty:jetty-security`, `org.eclipse.jetty:jetty-session`, `org.eclipse.jetty:jetty-ee` and `org.eclipse.jetty:jetty-xml` also into core? Shared by both EEs!
Yes, that sounds like a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#discussion_r2016518779
##########
hbase-shaded-jetty-ee8/pom.xml:
##########
@@ -0,0 +1,262 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+ <!--
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+ ON MVN COMPILE NOT WORKING
Review Comment:
Do we need to copy this headed, this file is copy of original jetty module
##########
hbase-shaded-jetty-ee8/pom.xml:
##########
@@ -0,0 +1,262 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+ <!--
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+ ON MVN COMPILE NOT WORKING
Review Comment:
Do we need to copy this header? this file is copy of original jetty module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2758018435
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 13s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 47s | master passed |
| +1 :green_heart: | compile | 0m 12s | master passed |
| +1 :green_heart: | javadoc | 0m 7s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 0m 46s | the patch passed |
| +1 :green_heart: | compile | 0m 19s | the patch passed |
| +1 :green_heart: | javac | 0m 19s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 0m 11s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-ee8 in the patch passed. |
| +1 :green_heart: | unit | 0m 32s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. |
| | | 4m 42s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/3/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/131 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux eee7f8587bf5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 5bb7b54 |
| Default Java | Temurin-1.8.0_442-b06 |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/3/testReport/ |
| Max. process+thread count | 405 (vs. ulimit of 1000) |
| modules | C: hbase-shaded-jetty-ee8 . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/3/console |
| versions | git=2.43.0 maven=3.9.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#discussion_r2067941056
##########
pom.xml:
##########
@@ -139,6 +141,7 @@
<error_prone_annotations.version>2.36.0</error_prone_annotations.version>
<gson.version>2.11.0</gson.version>
<jetty.version>9.4.56.v20240826</jetty.version>
+ <jetty-12-plus.version>12.0.18</jetty-12-plus.version>
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2761171995
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 56s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 52s | master passed |
| +1 :green_heart: | compile | 0m 13s | master passed |
| +1 :green_heart: | javadoc | 0m 6s | master passed |
| -0 :warning: | patch | 1m 15s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 8s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 1s | the patch passed |
| +1 :green_heart: | compile | 0m 28s | the patch passed |
| +1 :green_heart: | javac | 0m 28s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 0m 22s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch passed. |
| +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch passed. |
| +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-ee9 in the patch passed. |
| +1 :green_heart: | unit | 0m 43s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 19s | The patch does not generate ASF License warnings. |
| | | 5m 34s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/9/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/131 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux a92ed8cd4c05 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 5bb7b54 |
| Default Java | Temurin-1.8.0_442-b06 |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/9/testReport/ |
| Max. process+thread count | 394 (vs. ulimit of 1000) |
| modules | C: hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 hbase-shaded-jetty-12-plus-ee9 . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/9/console |
| versions | git=2.43.0 maven=3.9.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#discussion_r2016849459
##########
hbase-shaded-jetty-12-plus/pom.xml:
##########
@@ -0,0 +1,307 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+ <!--
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+ ON MVN COMPILE NOT WORKING
+
+ If you wondering why 'mvn compile' does not work building HBase
+ (in particular, if you are doing it for the first time), instead do
+ 'mvn package'. If you are interested in the full story, see
+ https://issues.apache.org/jira/browse/HBASE-6795.
+
+-->
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.hbase.thirdparty</groupId>
+ <artifactId>hbase-thirdparty</artifactId>
+ <version>${revision}</version>
+ <relativePath>..</relativePath>
+ </parent>
+ <artifactId>hbase-shaded-jetty-12-plus</artifactId>
+ <name>Apache HBase Relocated (Shaded) Jetty 12+ Libs</name>
+ <description>Pulls down Jetty, relocates it and makes a far jar.</description>
+ <dependencies>
+ <dependency>
+ <groupId>org.eclipse.jetty</groupId>
+ <artifactId>jetty-server</artifactId>
+ <version>${jetty12.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.eclipse.jetty</groupId>
+ <artifactId>jetty-http</artifactId>
+ <version>${jetty12.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.eclipse.jetty</groupId>
+ <artifactId>jetty-util</artifactId>
+ <version>${jetty12.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.eclipse.jetty</groupId>
+ <artifactId>jetty-io</artifactId>
+ <version>${jetty12.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.eclipse.jetty</groupId>
+ <artifactId>jetty-jmx</artifactId>
+ <version>${jetty12.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.eclipse.jetty</groupId>
+ <artifactId>jetty-util-ajax</artifactId>
+ <version>${jetty12.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.eclipse.jetty.ee8</groupId>
+ <artifactId>jetty-ee8-servlet</artifactId>
+ <version>${jetty12.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.eclipse.jetty</groupId>
+ <artifactId>servlet-api</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.eclipse.jetty.ee8</groupId>
+ <artifactId>jetty-ee8-security</artifactId>
+ <version>${jetty12.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.eclipse.jetty.ee8</groupId>
+ <artifactId>jetty-ee8-nested</artifactId>
+ <version>${jetty12.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.eclipse.jetty.ee8</groupId>
+ <artifactId>jetty-ee8-webapp</artifactId>
+ <version>${jetty12.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+
+ <!-- TODO Drop before merge, added here just for testing purpose -->
Review Comment:
Added this to to test out hbase with EE8 + EE9 in a single jar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2758338736
> So we could maintain a single [hbase-shaded-netty-whatever](https://issues.apache.org/jira/browse/HBASE-shaded-netty-whatever) package, that includes ee8 for now, and we can add ee9 later (while retaining ee8 for older hbase branches).
Updated PR with both EE8 + EE9 changes, will rerun UTs locally and update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2840980922
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 27s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 51s | master passed |
| +1 :green_heart: | compile | 0m 16s | master passed |
| +1 :green_heart: | javadoc | 0m 9s | master passed |
| -0 :warning: | patch | 1m 21s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 2s | the patch passed |
| +1 :green_heart: | compile | 0m 28s | the patch passed |
| +1 :green_heart: | javac | 0m 28s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 0m 18s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 6s | hbase-shaded-jetty-12-plus-core in the patch passed. |
| +1 :green_heart: | unit | 0m 6s | hbase-shaded-jetty-12-plus-ee8 in the patch passed. |
| +1 :green_heart: | unit | 0m 54s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 19s | The patch does not generate ASF License warnings. |
| | | 5m 20s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/17/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/131 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux 4aab8c9ded0f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / e545fe1 |
| Default Java | Temurin-1.8.0_452-b09 |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/17/testReport/ |
| Max. process+thread count | 397 (vs. ulimit of 1000) |
| modules | C: hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/17/console |
| versions | git=2.43.0 maven=3.9.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2760405565
My trick here is to make the ee modules depend on the core one, and add core as a provided dependency.
That should take care of all duplicate depedencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2760529144
> My trick here is to make the ee modules depend on the core one, and add core as a provided dependency. That should take care of all duplicate dependencies.
Done! Update tree:
```
[INFO] ----< org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-core >-----
[INFO] Building Apache HBase Relocated (Shaded) Jetty 12+ Libs: Core 4.1.11-SNAPSHOT [8/14]
[INFO] from hbase-shaded-jetty-12-plus-core/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- dependency:3.6.0:tree (default-cli) @ hbase-shaded-jetty-12-plus-core ---
[INFO] org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-core:jar:4.1.11-SNAPSHOT
[INFO] +- org.eclipse.jetty:jetty-server:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-http:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-util:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-io:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-jmx:jar:12.0.18:compile
[INFO] \- org.eclipse.jetty:jetty-util-ajax:jar:12.0.18:compile
[INFO]
[INFO] -----< org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-ee8 >-----
[INFO] Building Apache HBase Relocated (Shaded) Jetty 12+ Libs: EE8 4.1.11-SNAPSHOT [9/14]
[INFO] from hbase-shaded-jetty-12-plus-ee8/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- dependency:3.6.0:tree (default-cli) @ hbase-shaded-jetty-12-plus-ee8 ---
[INFO] org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-ee8:jar:4.1.11-SNAPSHOT
[INFO] +- org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-core:jar:4.1.11-SNAPSHOT:compile
[INFO] | +- org.eclipse.jetty:jetty-server:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-http:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-util:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-io:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-jmx:jar:12.0.18:compile
[INFO] | \- org.eclipse.jetty:jetty-util-ajax:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty.ee8:jetty-ee8-servlet:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty.ee8:jetty-ee8-security:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty.ee8:jetty-ee8-nested:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-security:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-session:jar:12.0.18:compile
[INFO] | \- org.eclipse.jetty.toolchain:jetty-servlet-api:jar:4.0.6:compile
[INFO] \- org.eclipse.jetty.ee8:jetty-ee8-webapp:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-ee:jar:12.0.18:compile
[INFO] \- org.eclipse.jetty:jetty-xml:jar:12.0.18:compile
[INFO]
[INFO] -----< org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-ee9 >-----
[INFO] Building Apache HBase Relocated (Shaded) Jetty 12+ Libs: EE9 4.1.11-SNAPSHOT [10/14]
[INFO] from hbase-shaded-jetty-12-plus-ee9/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- dependency:3.6.0:tree (default-cli) @ hbase-shaded-jetty-12-plus-ee9 ---
[INFO] org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-ee9:jar:4.1.11-SNAPSHOT
[INFO] +- org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-core:jar:4.1.11-SNAPSHOT:compile
[INFO] | +- org.eclipse.jetty:jetty-server:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-http:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-util:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-io:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-jmx:jar:12.0.18:compile
[INFO] | \- org.eclipse.jetty:jetty-util-ajax:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty.ee9:jetty-ee9-servlet:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty.ee9:jetty-ee9-security:jar:12.0.18:compile
[INFO] | \- org.eclipse.jetty:jetty-security:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty.ee9:jetty-ee9-nested:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-session:jar:12.0.18:compile
[INFO] | \- org.eclipse.jetty.toolchain:jetty-jakarta-servlet-api:jar:5.0.2:compile
[INFO] \- org.eclipse.jetty.ee9:jetty-ee9-webapp:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-ee:jar:12.0.18:compile
[INFO] \- org.eclipse.jetty:jetty-xml:jar:12.0.18:compile
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2760693852
Updated PR description!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#discussion_r2081502634
##########
pom.xml:
##########
@@ -139,6 +141,7 @@
<error_prone_annotations.version>2.36.0</error_prone_annotations.version>
<gson.version>2.11.0</gson.version>
<jetty.version>9.4.56.v20240826</jetty.version>
+ <jetty-12-plus.version>12.0.19</jetty-12-plus.version>
Review Comment:
bump to latest before merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2760363052
If you agree, then I think updating it now would let the others see what our current best approach is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2760555621
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 5s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 49s | master passed |
| +1 :green_heart: | compile | 0m 12s | master passed |
| +1 :green_heart: | javadoc | 0m 7s | master passed |
| -0 :warning: | patch | 1m 13s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 17s | the patch passed |
| +1 :green_heart: | compile | 0m 28s | the patch passed |
| +1 :green_heart: | javac | 0m 28s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 0m 20s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-core in the patch passed. |
| +1 :green_heart: | unit | 0m 32s | root in the patch passed. |
| +1 :green_heart: | unit | 0m 6s | hbase-shaded-jetty-12-plus-ee8 in the patch passed. |
| +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-ee9 in the patch passed. |
| +1 :green_heart: | asflicense | 0m 19s | The patch does not generate ASF License warnings. |
| | | 5m 47s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/5/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/131 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux 170b3b6c03fe 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 5bb7b54 |
| Default Java | Temurin-1.8.0_442-b06 |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/5/testReport/ |
| Max. process+thread count | 405 (vs. ulimit of 1000) |
| modules | C: hbase-shaded-jetty-12-plus-core . hbase-shaded-jetty-12-plus-ee8 hbase-shaded-jetty-12-plus-ee9 U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/5/console |
| versions | git=2.43.0 maven=3.9.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#discussion_r2018146604
##########
hbase-shaded-jetty-12-plus-ee9/pom.xml:
##########
@@ -0,0 +1,196 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+ <!--
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+ ON MVN COMPILE NOT WORKING
+
+ If you wondering why 'mvn compile' does not work building HBase
+ (in particular, if you are doing it for the first time), instead do
+ 'mvn package'. If you are interested in the full story, see
+ https://issues.apache.org/jira/browse/HBASE-6795.
+
+-->
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.hbase.thirdparty</groupId>
+ <artifactId>hbase-thirdparty</artifactId>
+ <version>${revision}</version>
+ <relativePath>..</relativePath>
+ </parent>
+ <artifactId>hbase-shaded-jetty-12-plus-ee9</artifactId>
+ <name>Apache HBase Relocated (Shaded) Jetty 12+ Libs: EE9</name>
+ <description>Pulls down Jetty EE9, relocates it and makes a far jar.</description>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.hbase.thirdparty</groupId>
+ <artifactId>hbase-shaded-jetty-12-plus-core</artifactId>
+ <version>${project.version}</version>
Review Comment:
Ah yes, I realized the same, hence removed comment. Still won't help as we now get.
```
[INFO] Building Apache HBase Relocated (Shaded) Jetty 12+ Libs: EE8 4.1.11-SNAPSHOT [9/14]
[INFO] from hbase-shaded-jetty-12-plus-ee8/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- dependency:3.6.0:tree (default-cli) @ hbase-shaded-jetty-12-plus-ee8 ---
[INFO] org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-ee8:jar:4.1.11-SNAPSHOT
[INFO] +- org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-core:jar:4.1.11-SNAPSHOT:provided
[INFO] | +- org.eclipse.jetty:jetty-server:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-http:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-util:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-io:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-jmx:jar:12.0.18:provided
[INFO] | \- org.eclipse.jetty:jetty-util-ajax:jar:12.0.18:provided
[INFO] +- org.eclipse.jetty.ee8:jetty-ee8-servlet:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty.ee8:jetty-ee8-security:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty.ee8:jetty-ee8-nested:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-security:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-session:jar:12.0.18:compile
[INFO] | \- org.eclipse.jetty.toolchain:jetty-servlet-api:jar:4.0.6:compile
[INFO] \- org.eclipse.jetty.ee8:jetty-ee8-webapp:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-ee:jar:12.0.18:compile
[INFO] \- org.eclipse.jetty:jetty-xml:jar:12.0.18:compile
``
I think an exclude during shading works better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#discussion_r2018182716
##########
hbase-shaded-jetty-12-plus-ee9/pom.xml:
##########
@@ -0,0 +1,196 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+ <!--
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+ ON MVN COMPILE NOT WORKING
+
+ If you wondering why 'mvn compile' does not work building HBase
+ (in particular, if you are doing it for the first time), instead do
+ 'mvn package'. If you are interested in the full story, see
+ https://issues.apache.org/jira/browse/HBASE-6795.
+
+-->
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.hbase.thirdparty</groupId>
+ <artifactId>hbase-thirdparty</artifactId>
+ <version>${revision}</version>
+ <relativePath>..</relativePath>
+ </parent>
+ <artifactId>hbase-shaded-jetty-12-plus-ee9</artifactId>
+ <name>Apache HBase Relocated (Shaded) Jetty 12+ Libs: EE9</name>
+ <description>Pulls down Jetty EE9, relocates it and makes a far jar.</description>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.hbase.thirdparty</groupId>
+ <artifactId>hbase-shaded-jetty-12-plus-core</artifactId>
+ <version>${project.version}</version>
Review Comment:
The tree looks good (apart from the slf4j dependency) .
My problem with exclusions is that if for example, a new dependency is added to jetty-http, then it won't get excluded autmatically, and the exclusion list has to be updated manually.
If we add jetty-http as a provided dependency, then both it and its transitive dependenies are excluded, even if those change in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2760304606
Do you think it would make sense to split this up, so that we have a base shaded jetty package, and an separate jee8 and jee9 shaded packages ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2829441488
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 34s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 5s | master passed |
| +1 :green_heart: | compile | 0m 15s | master passed |
| +1 :green_heart: | javadoc | 0m 7s | master passed |
| -0 :warning: | patch | 1m 32s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 0m 55s | the patch passed |
| +1 :green_heart: | compile | 0m 24s | the patch passed |
| +1 :green_heart: | javac | 0m 24s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 0m 17s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-core in the patch passed. |
| +1 :green_heart: | unit | 0m 6s | hbase-shaded-jetty-12-plus-ee8 in the patch passed. |
| +1 :green_heart: | unit | 0m 40s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. |
| | | 5m 11s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/14/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/131 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux 85aa033cb36c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 5bb7b54 |
| Default Java | Temurin-1.8.0_442-b06 |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/14/testReport/ |
| Max. process+thread count | 388 (vs. ulimit of 1000) |
| modules | C: hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/14/console |
| versions | git=2.43.0 maven=3.9.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2830625935
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 3s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 3s | master passed |
| +1 :green_heart: | compile | 0m 22s | master passed |
| +1 :green_heart: | javadoc | 0m 11s | master passed |
| -0 :warning: | patch | 1m 41s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 19s | the patch passed |
| +1 :green_heart: | compile | 0m 38s | the patch passed |
| +1 :green_heart: | javac | 0m 38s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 0m 24s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 7s | hbase-shaded-jetty-12-plus-core in the patch passed. |
| +1 :green_heart: | unit | 0m 8s | hbase-shaded-jetty-12-plus-ee8 in the patch passed. |
| +1 :green_heart: | unit | 0m 51s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 22s | The patch does not generate ASF License warnings. |
| | | 6m 52s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/15/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/131 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux 236c5f739ca2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 5bb7b54 |
| Default Java | Temurin-1.8.0_442-b06 |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/15/testReport/ |
| Max. process+thread count | 384 (vs. ulimit of 1000) |
| modules | C: hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/15/console |
| versions | git=2.43.0 maven=3.9.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2840930799
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 6s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 59s | master passed |
| +1 :green_heart: | compile | 0m 16s | master passed |
| +1 :green_heart: | javadoc | 0m 9s | master passed |
| -0 :warning: | patch | 1m 29s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 1s | the patch passed |
| +1 :green_heart: | compile | 0m 28s | the patch passed |
| +1 :green_heart: | javac | 0m 28s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 0m 19s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 6s | hbase-shaded-jetty-12-plus-core in the patch passed. |
| +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch passed. |
| +1 :green_heart: | unit | 0m 53s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 17s | The patch does not generate ASF License warnings. |
| | | 6m 9s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/16/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/131 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux b14f490c4cc5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / e545fe1 |
| Default Java | Temurin-1.8.0_452-b09 |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/16/testReport/ |
| Max. process+thread count | 384 (vs. ulimit of 1000) |
| modules | C: hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/16/console |
| versions | git=2.43.0 maven=3.9.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2758000250
I am not sure about the name, but jetty12 wouldn't be great either.
Whether to use the same package for relocation is another question.
I guess that importing two different relocated jetty versions is not something that we want support, so re-using the package name is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2758017042
> I am not sure about the name, but jetty12 wouldn't be great either.
Yes hence thought to create env specific names.
> I guess that importing two different relocated jetty versions is not something that we want support, so re-using the package name is fine
Yes this is a fair concern. Although, we would not want to have shaded jetty9 in our classpath if with have jetty12-eeX, but I am afraid what if hadoop timeline service or something else brings it in indirectly.?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2760614634
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 27s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 34s | master passed |
| +1 :green_heart: | compile | 0m 12s | master passed |
| +1 :green_heart: | javadoc | 0m 6s | master passed |
| -0 :warning: | patch | 0m 56s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 6s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 3s | the patch passed |
| +1 :green_heart: | compile | 0m 28s | the patch passed |
| +1 :green_heart: | javac | 0m 28s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 0m 21s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-core in the patch passed. |
| +1 :green_heart: | unit | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch passed. |
| +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-ee9 in the patch passed. |
| +1 :green_heart: | unit | 0m 33s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 19s | The patch does not generate ASF License warnings. |
| | | 4m 34s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/6/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/131 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux 2d53c08e1138 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 5bb7b54 |
| Default Java | Temurin-1.8.0_442-b06 |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/6/testReport/ |
| Max. process+thread count | 400 (vs. ulimit of 1000) |
| modules | C: hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 hbase-shaded-jetty-12-plus-ee9 . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/6/console |
| versions | git=2.43.0 maven=3.9.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#discussion_r2018173243
##########
hbase-shaded-jetty-12-plus-ee9/pom.xml:
##########
@@ -0,0 +1,196 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+ <!--
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+ ON MVN COMPILE NOT WORKING
+
+ If you wondering why 'mvn compile' does not work building HBase
+ (in particular, if you are doing it for the first time), instead do
+ 'mvn package'. If you are interested in the full story, see
+ https://issues.apache.org/jira/browse/HBASE-6795.
+
+-->
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.hbase.thirdparty</groupId>
+ <artifactId>hbase-thirdparty</artifactId>
+ <version>${revision}</version>
+ <relativePath>..</relativePath>
+ </parent>
+ <artifactId>hbase-shaded-jetty-12-plus-ee9</artifactId>
+ <name>Apache HBase Relocated (Shaded) Jetty 12+ Libs: EE9</name>
+ <description>Pulls down Jetty EE9, relocates it and makes a far jar.</description>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.hbase.thirdparty</groupId>
+ <artifactId>hbase-shaded-jetty-12-plus-core</artifactId>
+ <version>${project.version}</version>
Review Comment:
Does it look better now? With provided it still included most of the classes
Now switched to excludes during shading, we are not bundling any of core jars in eeX now. The dependency tree would not change, just that we won't shade these jars now.
```
[INFO] ----< org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-core >-----
[INFO] Building Apache HBase Relocated (Shaded) Jetty 12+ Libs: Core 4.1.11-SNAPSHOT [8/14]
[INFO] from hbase-shaded-jetty-12-plus-core/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- dependency:3.6.0:tree (default-cli) @ hbase-shaded-jetty-12-plus-core ---
[INFO] org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-core:jar:4.1.11-SNAPSHOT
[INFO] +- org.eclipse.jetty:jetty-server:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-http:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-util:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-io:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-jmx:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-util-ajax:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-security:jar:12.0.18:compile
[INFO] | \- org.slf4j:slf4j-api:jar:2.0.16:compile
[INFO] +- org.eclipse.jetty:jetty-session:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-ee:jar:12.0.18:compile
[INFO] \- org.eclipse.jetty:jetty-xml:jar:12.0.18:compile
[INFO]
[INFO] -----< org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-ee8 >-----
[INFO] Building Apache HBase Relocated (Shaded) Jetty 12+ Libs: EE8 4.1.11-SNAPSHOT [9/14]
[INFO] from hbase-shaded-jetty-12-plus-ee8/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- dependency:3.6.0:tree (default-cli) @ hbase-shaded-jetty-12-plus-ee8 ---
[INFO] org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-ee8:jar:4.1.11-SNAPSHOT
[INFO] +- org.eclipse.jetty.ee8:jetty-ee8-servlet:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty.ee8:jetty-ee8-security:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty.ee8:jetty-ee8-nested:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-http:jar:12.0.18:compile
[INFO] | | +- org.eclipse.jetty:jetty-io:jar:12.0.18:compile
[INFO] | | \- org.eclipse.jetty:jetty-util:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-security:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-server:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-session:jar:12.0.18:compile
[INFO] | \- org.eclipse.jetty.toolchain:jetty-servlet-api:jar:4.0.6:compile
[INFO] \- org.eclipse.jetty.ee8:jetty-ee8-webapp:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-ee:jar:12.0.18:compile
[INFO] \- org.eclipse.jetty:jetty-xml:jar:12.0.18:compile
[INFO]
[INFO] -----< org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-ee9 >-----
[INFO] Building Apache HBase Relocated (Shaded) Jetty 12+ Libs: EE9 4.1.11-SNAPSHOT [10/14]
[INFO] from hbase-shaded-jetty-12-plus-ee9/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- dependency:3.6.0:tree (default-cli) @ hbase-shaded-jetty-12-plus-ee9 ---
[INFO] org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-ee9:jar:4.1.11-SNAPSHOT
[INFO] +- org.eclipse.jetty.ee9:jetty-ee9-servlet:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty.ee9:jetty-ee9-security:jar:12.0.18:compile
[INFO] | \- org.eclipse.jetty:jetty-security:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty.ee9:jetty-ee9-nested:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-http:jar:12.0.18:compile
[INFO] | | +- org.eclipse.jetty:jetty-io:jar:12.0.18:compile
[INFO] | | \- org.eclipse.jetty:jetty-util:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-server:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-session:jar:12.0.18:compile
[INFO] | \- org.eclipse.jetty.toolchain:jetty-jakarta-servlet-api:jar:5.0.2:compile
[INFO] \- org.eclipse.jetty.ee9:jetty-ee9-webapp:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-ee:jar:12.0.18:compile
[INFO] \- org.eclipse.jetty:jetty-xml:jar:12.0.18:compile
[INFO]
```
EE8 shaded jar:
<img width="560" alt="Screenshot 2025-03-28 at 2 23 35 PM" src="https://github.com/user-attachments/assets/7164bfcb-6def-4001-8ec5-31876442606f" />
EE9 shaded jar:
<img width="571" alt="Screenshot 2025-03-28 at 2 23 43 PM" src="https://github.com/user-attachments/assets/aa353dbc-f098-43e3-a478-a032fb409731" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2760360169
> > My use case would be for example:
> >
> > * Hbase 3.0 uses ee8, so we don't need the ee10 modules
> > * HBase 3.1 uses ee10, so we don't need the ee8 modules.
> >
> > Not a huge deal either way, but saves a bit on the assembly size.
>
> Ah yes we could definitely save a few MBs here and avoid bundling redundant code. Just to be clear, we are suggesting to break into modules as below:
>
> * Jetty-12-plus
> * Jetty-12-plus-EE8
> * Jetty-12-plus-EE10 etc
>
> So basically fall back to the initial approach of this PR, but maybe a new module for base? Right?
Right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2760408422
> My trick here is to make the ee modules depend on the core one, and add core as a provided dependency. That should take care of all duplicate depedencies.
Ah yes !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2768331074
> One more doubt: Do we weant to add the ee9 module now ? ee8 is enough for now, maybe we can hold off on ee9/ee10 until the first phase is done ?
Fixed, removed EE9 from the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#discussion_r2081508741
##########
pom.xml:
##########
@@ -139,6 +141,7 @@
<error_prone_annotations.version>2.36.0</error_prone_annotations.version>
<gson.version>2.11.0</gson.version>
<jetty.version>9.4.56.v20240826</jetty.version>
+ <jetty-12-plus.version>12.0.19</jetty-12-plus.version>
Review Comment:
sure let me merge this right away
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2866453865
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 0s | Docker mode activated. |
| -1 :x: | patch | 0m 3s | https://github.com/apache/hbase-thirdparty/pull/131 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/131 |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/19/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2866510723
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 26s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 33s | master passed |
| +1 :green_heart: | compile | 0m 13s | master passed |
| +1 :green_heart: | javadoc | 0m 6s | master passed |
| -0 :warning: | patch | 0m 56s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 6s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 0m 50s | the patch passed |
| +1 :green_heart: | compile | 0m 23s | the patch passed |
| +1 :green_heart: | javac | 0m 23s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 0m 16s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-core in the patch passed. |
| +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch passed. |
| +1 :green_heart: | unit | 0m 43s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. |
| | | 4m 11s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/21/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/131 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux 0f3072bbe0d5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / e545fe1 |
| Default Java | Temurin-1.8.0_452-b09 |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/21/testReport/ |
| Max. process+thread count | 400 (vs. ulimit of 1000) |
| modules | C: hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/21/console |
| versions | git=2.43.0 maven=3.9.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain merged PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2828322662
Oops!! fix snapshot related commit which was used to push code to artifactory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2758398842
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 3s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 48s | master passed |
| +1 :green_heart: | compile | 0m 12s | master passed |
| +1 :green_heart: | javadoc | 0m 7s | master passed |
| -0 :warning: | patch | 1m 11s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 0m 49s | the patch passed |
| +1 :green_heart: | compile | 0m 18s | the patch passed |
| +1 :green_heart: | javac | 0m 18s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 0m 11s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus in the patch passed. |
| +1 :green_heart: | unit | 0m 33s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. |
| | | 4m 38s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/4/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/131 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux 89b6c9ca48e1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 5bb7b54 |
| Default Java | Temurin-1.8.0_442-b06 |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/4/testReport/ |
| Max. process+thread count | 406 (vs. ulimit of 1000) |
| modules | C: hbase-shaded-jetty-12-plus . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/4/console |
| versions | git=2.43.0 maven=3.9.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#discussion_r2018204708
##########
hbase-shaded-jetty-12-plus-ee8/pom.xml:
##########
@@ -0,0 +1,312 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+ <!--
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+ ON MVN COMPILE NOT WORKING
+
+ If you wondering why 'mvn compile' does not work building HBase
+ (in particular, if you are doing it for the first time), instead do
+ 'mvn package'. If you are interested in the full story, see
+ https://issues.apache.org/jira/browse/HBASE-6795.
+
+-->
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.hbase.thirdparty</groupId>
+ <artifactId>hbase-thirdparty</artifactId>
+ <version>${revision}</version>
+ <relativePath>..</relativePath>
+ </parent>
+ <artifactId>hbase-shaded-jetty-12-plus-ee8</artifactId>
+ <name>Apache HBase Relocated (Shaded) Jetty 12+ Libs: EE8</name>
+ <description>Pulls down Jetty EE8, relocates it and makes a far jar.</description>
+ <dependencies>
+ <dependency>
+ <groupId>org.eclipse.jetty.ee8</groupId>
+ <artifactId>jetty-ee8-servlet</artifactId>
+ <version>${jetty12.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.eclipse.jetty</groupId>
+ <artifactId>servlet-api</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.eclipse.jetty.ee8</groupId>
+ <artifactId>jetty-ee8-security</artifactId>
+ <version>${jetty12.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.eclipse.jetty.ee8</groupId>
+ <artifactId>jetty-ee8-nested</artifactId>
+ <version>${jetty12.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.eclipse.jetty.ee8</groupId>
+ <artifactId>jetty-ee8-webapp</artifactId>
+ <version>${jetty12.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <!-- List to dependencies which are part of core and we want to avoid bundling,
+ hence keeping as provided here -->
+ <dependency>
+ <groupId>org.eclipse.jetty</groupId>
+ <artifactId>jetty-server</artifactId>
+ <version>${jetty12.version}</version>
+ <scope>provided</scope>
+ <exclusions>
Review Comment:
We don't need the exclusions here, it may even be conter-productive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2760363558
> If you agree, then I think updating it now would let the others see what our current best approach is.
Sure let me update PR with the suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2763238337
One more doubt:
Do we weant to add the ee9 module now ?
ee8 is enough for now, maybe we can hold off on ee9/ee10 until the first phase is done ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#discussion_r2067937697
##########
pom.xml:
##########
@@ -139,6 +141,7 @@
<error_prone_annotations.version>2.36.0</error_prone_annotations.version>
<gson.version>2.11.0</gson.version>
<jetty.version>9.4.56.v20240826</jetty.version>
+ <jetty-12-plus.version>12.0.18</jetty-12-plus.version>
Review Comment:
latest jetty is 12.0.19 now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2828330243
Hi @stoty Should I go ahead and merge this one? Or should wait a few more days for more eyes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2827924592
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 46s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| -1 :x: | mvninstall | 0m 18s | root in master failed. |
| -1 :x: | compile | 0m 17s | root in master failed. |
| -1 :x: | javadoc | 0m 17s | root in master failed. |
| -0 :warning: | patch | 1m 11s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 30s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 18s | root in the patch failed. |
| -1 :x: | mvninstall | 0m 17s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | mvninstall | 0m 17s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | compile | 0m 18s | root in the patch failed. |
| -1 :x: | compile | 0m 17s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | compile | 0m 18s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javac | 0m 18s | root in the patch failed. |
| -1 :x: | javac | 0m 17s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javac | 0m 18s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. |
| -1 :x: | javadoc | 0m 17s | root in the patch failed. |
| -1 :x: | javadoc | 0m 17s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javadoc | 0m 18s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 17s | root in the patch failed. |
| -1 :x: | unit | 0m 18s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | unit | 0m 17s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| +0 :ok: | asflicense | 0m 52s | ASF License check generated no output? |
| | | 7m 56s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/11/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/131 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux 9bb8405f122e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 5bb7b54 |
| Default Java | Temurin-1.8.0_442-b06 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/11/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/11/artifact/yetus-precommit-check/output/branch-compile-root.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/11/artifact/yetus-precommit-check/output/branch-javadoc-root.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/11/artifact/yetus-precommit-check/output/patch-mvninstall-root.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/11/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-core.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/11/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-ee8.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/11/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/11/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/11/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/11/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/11/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/11/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/11/artifact/yetus-precommit-check/output/patch-javadoc-root.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/11/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-core.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/11/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-ee8.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/11/artifact/yetus-precommit-check/output/patch-unit-root.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/11/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-core.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/11/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-ee8.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/11/testReport/ |
| Max. process+thread count | 27 (vs. ulimit of 1000) |
| modules | C: . hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/11/console |
| versions | git=2.43.0 maven=3.9.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#discussion_r2018195750
##########
hbase-shaded-jetty-12-plus-ee9/pom.xml:
##########
@@ -0,0 +1,196 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+ <!--
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+ ON MVN COMPILE NOT WORKING
+
+ If you wondering why 'mvn compile' does not work building HBase
+ (in particular, if you are doing it for the first time), instead do
+ 'mvn package'. If you are interested in the full story, see
+ https://issues.apache.org/jira/browse/HBASE-6795.
+
+-->
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.hbase.thirdparty</groupId>
+ <artifactId>hbase-thirdparty</artifactId>
+ <version>${revision}</version>
+ <relativePath>..</relativePath>
+ </parent>
+ <artifactId>hbase-shaded-jetty-12-plus-ee9</artifactId>
+ <name>Apache HBase Relocated (Shaded) Jetty 12+ Libs: EE9</name>
+ <description>Pulls down Jetty EE9, relocates it and makes a far jar.</description>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.hbase.thirdparty</groupId>
+ <artifactId>hbase-shaded-jetty-12-plus-core</artifactId>
+ <version>${project.version}</version>
Review Comment:
> The tree looks good (apart from the slf4j dependency) .
> Can you try adding the same dependencies as core has, but with provided scope ?
Fixed slf4j and provided change.
Updated tree:
```
[INFO] ----< org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-core >-----
[INFO] Building Apache HBase Relocated (Shaded) Jetty 12+ Libs: Core 4.1.11-SNAPSHOT [8/14]
[INFO] from hbase-shaded-jetty-12-plus-core/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- dependency:3.6.0:tree (default-cli) @ hbase-shaded-jetty-12-plus-core ---
[INFO] org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-core:jar:4.1.11-SNAPSHOT
[INFO] +- org.eclipse.jetty:jetty-server:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-http:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-util:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-io:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-jmx:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-util-ajax:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-security:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-session:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-ee:jar:12.0.18:compile
[INFO] \- org.eclipse.jetty:jetty-xml:jar:12.0.18:compile
[INFO]
[INFO] -----< org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-ee8 >-----
[INFO] Building Apache HBase Relocated (Shaded) Jetty 12+ Libs: EE8 4.1.11-SNAPSHOT [9/14]
[INFO] from hbase-shaded-jetty-12-plus-ee8/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- dependency:3.6.0:tree (default-cli) @ hbase-shaded-jetty-12-plus-ee8 ---
[INFO] org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-ee8:jar:4.1.11-SNAPSHOT
[INFO] +- org.eclipse.jetty.ee8:jetty-ee8-servlet:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty.ee8:jetty-ee8-security:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty.ee8:jetty-ee8-nested:jar:12.0.18:compile
[INFO] | \- org.eclipse.jetty.toolchain:jetty-servlet-api:jar:4.0.6:compile
[INFO] +- org.eclipse.jetty.ee8:jetty-ee8-webapp:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-server:jar:12.0.18:provided
[INFO] +- org.eclipse.jetty:jetty-http:jar:12.0.18:provided
[INFO] +- org.eclipse.jetty:jetty-util:jar:12.0.18:provided
[INFO] +- org.eclipse.jetty:jetty-io:jar:12.0.18:provided
[INFO] +- org.eclipse.jetty:jetty-jmx:jar:12.0.18:provided
[INFO] +- org.eclipse.jetty:jetty-util-ajax:jar:12.0.18:provided
[INFO] +- org.eclipse.jetty:jetty-security:jar:12.0.18:provided
[INFO] +- org.eclipse.jetty:jetty-session:jar:12.0.18:provided
[INFO] +- org.eclipse.jetty:jetty-ee:jar:12.0.18:provided
[INFO] \- org.eclipse.jetty:jetty-xml:jar:12.0.18:provided
[INFO]
[INFO] -----< org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-ee9 >-----
[INFO] Building Apache HBase Relocated (Shaded) Jetty 12+ Libs: EE9 4.1.11-SNAPSHOT [10/14]
[INFO] from hbase-shaded-jetty-12-plus-ee9/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- dependency:3.6.0:tree (default-cli) @ hbase-shaded-jetty-12-plus-ee9 ---
[INFO] org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-ee9:jar:4.1.11-SNAPSHOT
[INFO] +- org.eclipse.jetty.ee9:jetty-ee9-servlet:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty.ee9:jetty-ee9-security:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty.ee9:jetty-ee9-nested:jar:12.0.18:compile
[INFO] | \- org.eclipse.jetty.toolchain:jetty-jakarta-servlet-api:jar:5.0.2:compile
[INFO] +- org.eclipse.jetty.ee9:jetty-ee9-webapp:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-server:jar:12.0.18:provided
[INFO] +- org.eclipse.jetty:jetty-http:jar:12.0.18:provided
[INFO] +- org.eclipse.jetty:jetty-util:jar:12.0.18:provided
[INFO] +- org.eclipse.jetty:jetty-io:jar:12.0.18:provided
[INFO] +- org.eclipse.jetty:jetty-jmx:jar:12.0.18:provided
[INFO] +- org.eclipse.jetty:jetty-util-ajax:jar:12.0.18:provided
[INFO] +- org.eclipse.jetty:jetty-security:jar:12.0.18:provided
[INFO] +- org.eclipse.jetty:jetty-session:jar:12.0.18:provided
[INFO] +- org.eclipse.jetty:jetty-ee:jar:12.0.18:provided
[INFO] \- org.eclipse.jetty:jetty-xml:jar:12.0.18:provided
```
File structure is same as before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#discussion_r2018207784
##########
hbase-shaded-jetty-12-plus-ee8/pom.xml:
##########
@@ -0,0 +1,312 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+ <!--
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+ ON MVN COMPILE NOT WORKING
+
+ If you wondering why 'mvn compile' does not work building HBase
+ (in particular, if you are doing it for the first time), instead do
+ 'mvn package'. If you are interested in the full story, see
+ https://issues.apache.org/jira/browse/HBASE-6795.
+
+-->
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.hbase.thirdparty</groupId>
+ <artifactId>hbase-thirdparty</artifactId>
+ <version>${revision}</version>
+ <relativePath>..</relativePath>
+ </parent>
+ <artifactId>hbase-shaded-jetty-12-plus-ee8</artifactId>
+ <name>Apache HBase Relocated (Shaded) Jetty 12+ Libs: EE8</name>
+ <description>Pulls down Jetty EE8, relocates it and makes a far jar.</description>
+ <dependencies>
+ <dependency>
+ <groupId>org.eclipse.jetty.ee8</groupId>
+ <artifactId>jetty-ee8-servlet</artifactId>
+ <version>${jetty12.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.eclipse.jetty</groupId>
+ <artifactId>servlet-api</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.eclipse.jetty.ee8</groupId>
+ <artifactId>jetty-ee8-security</artifactId>
+ <version>${jetty12.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.eclipse.jetty.ee8</groupId>
+ <artifactId>jetty-ee8-nested</artifactId>
+ <version>${jetty12.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.eclipse.jetty.ee8</groupId>
+ <artifactId>jetty-ee8-webapp</artifactId>
+ <version>${jetty12.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <!-- List to dependencies which are part of core and we want to avoid bundling,
+ hence keeping as provided here -->
+ <dependency>
+ <groupId>org.eclipse.jetty</groupId>
+ <artifactId>jetty-server</artifactId>
+ <version>${jetty12.version}</version>
+ <scope>provided</scope>
+ <exclusions>
Review Comment:
sure copy pasted, let me cleanup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#discussion_r2018146604
##########
hbase-shaded-jetty-12-plus-ee9/pom.xml:
##########
@@ -0,0 +1,196 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+ <!--
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+ ON MVN COMPILE NOT WORKING
+
+ If you wondering why 'mvn compile' does not work building HBase
+ (in particular, if you are doing it for the first time), instead do
+ 'mvn package'. If you are interested in the full story, see
+ https://issues.apache.org/jira/browse/HBASE-6795.
+
+-->
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.hbase.thirdparty</groupId>
+ <artifactId>hbase-thirdparty</artifactId>
+ <version>${revision}</version>
+ <relativePath>..</relativePath>
+ </parent>
+ <artifactId>hbase-shaded-jetty-12-plus-ee9</artifactId>
+ <name>Apache HBase Relocated (Shaded) Jetty 12+ Libs: EE9</name>
+ <description>Pulls down Jetty EE9, relocates it and makes a far jar.</description>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.hbase.thirdparty</groupId>
+ <artifactId>hbase-shaded-jetty-12-plus-core</artifactId>
+ <version>${project.version}</version>
Review Comment:
Ah yes, I realized the same, hence removed comment. Still won't help as we now get.
```
[INFO] Building Apache HBase Relocated (Shaded) Jetty 12+ Libs: EE8 4.1.11-SNAPSHOT [9/14]
[INFO] from hbase-shaded-jetty-12-plus-ee8/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- dependency:3.6.0:tree (default-cli) @ hbase-shaded-jetty-12-plus-ee8 ---
[INFO] org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-ee8:jar:4.1.11-SNAPSHOT
[INFO] +- org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-core:jar:4.1.11-SNAPSHOT:provided
[INFO] | +- org.eclipse.jetty:jetty-server:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-http:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-util:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-io:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-jmx:jar:12.0.18:provided
[INFO] | \- org.eclipse.jetty:jetty-util-ajax:jar:12.0.18:provided
[INFO] +- org.eclipse.jetty.ee8:jetty-ee8-servlet:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty.ee8:jetty-ee8-security:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty.ee8:jetty-ee8-nested:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-security:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-session:jar:12.0.18:compile
[INFO] | \- org.eclipse.jetty.toolchain:jetty-servlet-api:jar:4.0.6:compile
[INFO] \- org.eclipse.jetty.ee8:jetty-ee8-webapp:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-ee:jar:12.0.18:compile
[INFO] \- org.eclipse.jetty:jetty-xml:jar:12.0.18:compile
```
I think an exclude during shading works better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#discussion_r2018135583
##########
hbase-shaded-jetty-12-plus-ee9/pom.xml:
##########
@@ -0,0 +1,196 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+ <!--
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+ ON MVN COMPILE NOT WORKING
+
+ If you wondering why 'mvn compile' does not work building HBase
+ (in particular, if you are doing it for the first time), instead do
+ 'mvn package'. If you are interested in the full story, see
+ https://issues.apache.org/jira/browse/HBASE-6795.
+
+-->
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.hbase.thirdparty</groupId>
+ <artifactId>hbase-thirdparty</artifactId>
+ <version>${revision}</version>
+ <relativePath>..</relativePath>
+ </parent>
+ <artifactId>hbase-shaded-jetty-12-plus-ee9</artifactId>
+ <name>Apache HBase Relocated (Shaded) Jetty 12+ Libs: EE9</name>
+ <description>Pulls down Jetty EE9, relocates it and makes a far jar.</description>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.hbase.thirdparty</groupId>
+ <artifactId>hbase-shaded-jetty-12-plus-core</artifactId>
+ <version>${project.version}</version>
Review Comment:
This one should be <scope>provided</scope>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2768350708
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 7s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 50s | master passed |
| +1 :green_heart: | compile | 0m 12s | master passed |
| +1 :green_heart: | javadoc | 0m 6s | master passed |
| -0 :warning: | patch | 1m 13s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 0m 51s | the patch passed |
| +1 :green_heart: | compile | 0m 23s | the patch passed |
| +1 :green_heart: | javac | 0m 23s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 0m 16s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-core in the patch passed. |
| +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch passed. |
| +1 :green_heart: | unit | 0m 39s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. |
| | | 5m 9s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/10/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/131 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux 55e71db7741b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 5bb7b54 |
| Default Java | Temurin-1.8.0_442-b06 |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/10/testReport/ |
| Max. process+thread count | 388 (vs. ulimit of 1000) |
| modules | C: hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/10/console |
| versions | git=2.43.0 maven=3.9.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2768173337
> One more doubt: Do we weant to add the ee9 module now ? ee8 is enough for now, maybe we can hold off on ee9/ee10 until the first phase is done ?
Yes right, had added just for demonstration/testing purpose. Let me remove it now. We will add this back later (once we decide on ee9/ee10) as you rightly mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2758238036
> > > As bad a jetty12 would be a bad name, at least we're not tying it to the ee spec version. Maybe jetty-new ? or Jetty-b ?
> >
> >
> > I am not sure if I understand you correctly but we may need all versions of jetty to exist:
> >
> > * [hbase-shaded-jetty](https://issues.apache.org/jira/browse/HBASE-shaded-jetty): for <= branch-2.6
> > * [hbase-shaded-jetty-ee8](https://issues.apache.org/jira/browse/HBASE-shaded-jetty-ee8): possibly for branch-2, if we decide to backport retaining javax namespace
> > * [hbase-shaded-jetty-ee9](https://issues.apache.org/jira/browse/HBASE-shaded-jetty-ee9): For branch-3+ with jakarta namespace change
> >
> > Hence created a new module for ee8 as first step.
>
> AFAICT ee8 and ee9 does not have to be a separate project. IUC the different modules can co-exist because they are under different package names.
>
> So we could maintain a single [hbase-shaded-netty-whatever](https://issues.apache.org/jira/browse/HBASE-shaded-netty-whatever) package, that includes ee8 for now, and we can add ee9 later (while retaining ee8 for older hbase branches).
Okay got your point. Agreed, created 2 modules as we have a javax dependency inside thirdparty jetty (not sure why), copied same inside new module. If we can build without this bundled, then we should be good maybe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2758076312
> As bad a jetty12 would be a bad name, at least we're not tying it to the ee spec version. Maybe jetty-new ? or Jetty-b ?
I am not sure if I understand you correctly but we may need all versions of jetty to exist:
- hbase-shaded-jetty: for <= branch-2.6
- hbase-shaded-jetty-ee8: possibly for branch-2
- hbase-shaded-jetty-ee9: possibly for branch-3+
Hence created a new module for ee8 as first step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2866480152
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 59s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 46s | master passed |
| +1 :green_heart: | compile | 0m 11s | master passed |
| +1 :green_heart: | javadoc | 0m 7s | master passed |
| -0 :warning: | patch | 1m 10s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 0m 52s | the patch passed |
| +1 :green_heart: | compile | 0m 23s | the patch passed |
| +1 :green_heart: | javac | 0m 23s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 0m 16s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-core in the patch passed. |
| +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch passed. |
| +1 :green_heart: | unit | 0m 45s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. |
| | | 5m 6s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/20/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/131 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux c775745476df 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / e545fe1 |
| Default Java | Temurin-1.8.0_452-b09 |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/20/testReport/ |
| Max. process+thread count | 383 (vs. ulimit of 1000) |
| modules | C: hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/20/console |
| versions | git=2.43.0 maven=3.9.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#discussion_r2081506059
##########
pom.xml:
##########
@@ -139,6 +141,7 @@
<error_prone_annotations.version>2.36.0</error_prone_annotations.version>
<gson.version>2.11.0</gson.version>
<jetty.version>9.4.56.v20240826</jetty.version>
+ <jetty-12-plus.version>12.0.19</jetty-12-plus.version>
Review Comment:
We've agreed in principle on the mailing list, and it's been ready for weeks.
I think if the CI is OK with the latest version this is fine to merge.
3.0.0 is still some time off, if anything comes up, there's time to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#discussion_r2018278398
##########
pom.xml:
##########
@@ -139,6 +142,7 @@
<error_prone_annotations.version>2.36.0</error_prone_annotations.version>
<gson.version>2.11.0</gson.version>
<jetty.version>9.4.56.v20240826</jetty.version>
+ <jetty12.version>12.0.18</jetty12.version>
Review Comment:
rename to jetty-12-plus.version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#discussion_r2018179175
##########
hbase-shaded-jetty-12-plus-ee9/pom.xml:
##########
@@ -0,0 +1,196 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+ <!--
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+ ON MVN COMPILE NOT WORKING
+
+ If you wondering why 'mvn compile' does not work building HBase
+ (in particular, if you are doing it for the first time), instead do
+ 'mvn package'. If you are interested in the full story, see
+ https://issues.apache.org/jira/browse/HBASE-6795.
+
+-->
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.hbase.thirdparty</groupId>
+ <artifactId>hbase-thirdparty</artifactId>
+ <version>${revision}</version>
+ <relativePath>..</relativePath>
+ </parent>
+ <artifactId>hbase-shaded-jetty-12-plus-ee9</artifactId>
+ <name>Apache HBase Relocated (Shaded) Jetty 12+ Libs: EE9</name>
+ <description>Pulls down Jetty EE9, relocates it and makes a far jar.</description>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.hbase.thirdparty</groupId>
+ <artifactId>hbase-shaded-jetty-12-plus-core</artifactId>
+ <version>${project.version}</version>
Review Comment:
> I'm wary of exclude, as it tends to be fragile when module structure changes.
Agreed difficult to keep up with upgrades.
> Can you try adding the same dependencies as core has, but with provided scope ?
Sure let me update!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2760345334
My use case would be for example:
- Hbase 3.0 uses ee8, so we don't need the ee10 modules
- HBase 3.1 uses ee10, so we don't need the ee8 modules.
Not a huge deal either way, but saves a bit on the assembly size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#discussion_r2017997549
##########
pom.xml:
##########
@@ -139,7 +140,9 @@
<error_prone_annotations.version>2.36.0</error_prone_annotations.version>
<gson.version>2.11.0</gson.version>
<jetty.version>9.4.56.v20240826</jetty.version>
+ <jetty12.version>12.0.18</jetty12.version>
<servlet-api.version>3.1.0</servlet-api.version>
+ <servlet4-api.version>4.0.1</servlet4-api.version>
Review Comment:
unused, drop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2760354266
> * 3.0 uses ee8, so we don't need the ee10 modules
> * HBase 3.1 uses ee10, so we don't need the ee8 modu
Ah yes we could definitely save a few MBs here and avoid bundling redundant code. Just to clear, we are suggesting to break into modules as below:
- Jetty-12-plus
- Jetty-12-plus-EE8
- Jetty-12-plus-EE10 etc
So basically fall back to the initial approach of this PR, but maybe a new module for core? Right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2760389706
The eeX tends to transitively bring in few dependencies. Hence, breaking into core we might have duplicates of same into 2 jars. So we may have remove the transitive dependencies which are in the core from eeX or merge core + eeX as a single fat jar.
By just breaking into 3 modules with core, ee8 and ee9 specific dependencies in pom, result into as below.
```
[INFO] ----< org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-core >-----
[INFO] Building Apache HBase Relocated (Shaded) Jetty 12+ Libs: Core 4.1.11-SNAPSHOT [8/13]
[INFO] from hbase-shaded-jetty-12-plus-core/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- dependency:3.6.0:tree (default-cli) @ hbase-shaded-jetty-12-plus-core ---
[INFO] org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-core:jar:4.1.11-SNAPSHOT
[INFO] +- org.eclipse.jetty:jetty-server:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-http:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-util:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-io:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-jmx:jar:12.0.18:compile
[INFO] \- org.eclipse.jetty:jetty-util-ajax:jar:12.0.18:compile
[INFO]
[INFO] -----< org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-ee8 >-----
[INFO] Building Apache HBase Relocated (Shaded) Jetty 12+ Libs: EE8 4.1.11-SNAPSHOT [9/13]
[INFO] from hbase-shaded-jetty-12-plus-ee8/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- dependency:3.6.0:tree (default-cli) @ hbase-shaded-jetty-12-plus-ee8 ---
[INFO] org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-ee8:jar:4.1.11-SNAPSHOT
[INFO] +- org.eclipse.jetty.ee8:jetty-ee8-servlet:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty.ee8:jetty-ee8-security:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty.ee8:jetty-ee8-nested:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-http:jar:12.0.18:compile
[INFO] | | +- org.eclipse.jetty:jetty-io:jar:12.0.18:compile
[INFO] | | \- org.eclipse.jetty:jetty-util:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-security:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-server:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-session:jar:12.0.18:compile
[INFO] | \- org.eclipse.jetty.toolchain:jetty-servlet-api:jar:4.0.6:compile
[INFO] \- org.eclipse.jetty.ee8:jetty-ee8-webapp:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-ee:jar:12.0.18:compile
[INFO] \- org.eclipse.jetty:jetty-xml:jar:12.0.18:compile
[INFO]
[INFO] -----< org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-ee9 >-----
[INFO] Building Apache HBase Relocated (Shaded) Jetty 12+ Libs: EE9 4.1.11-SNAPSHOT [10/13]
[INFO] from hbase-shaded-jetty-12-plus-ee9/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- dependency:3.6.0:tree (default-cli) @ hbase-shaded-jetty-12-plus-ee9 ---
[INFO] org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-ee9:jar:4.1.11-SNAPSHOT
[INFO] +- org.eclipse.jetty.ee9:jetty-ee9-servlet:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty.ee9:jetty-ee9-security:jar:12.0.18:compile
[INFO] | \- org.eclipse.jetty:jetty-security:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty.ee9:jetty-ee9-nested:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-http:jar:12.0.18:compile
[INFO] | | +- org.eclipse.jetty:jetty-io:jar:12.0.18:compile
[INFO] | | \- org.eclipse.jetty:jetty-util:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-server:jar:12.0.18:compile
[INFO] | +- org.eclipse.jetty:jetty-session:jar:12.0.18:compile
[INFO] | \- org.eclipse.jetty.toolchain:jetty-jakarta-servlet-api:jar:5.0.2:compile
[INFO] \- org.eclipse.jetty.ee9:jetty-ee9-webapp:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-ee:jar:12.0.18:compile
[INFO] \- org.eclipse.jetty:jetty-xml:jar:12.0.18:compile
[INFO]
``
Which approach do you suggest?
- transitive removal in eeX which exist in core
- or core + eeX as a single fat for each X
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2828369779
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 26s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| -1 :x: | mvninstall | 0m 17s | root in master failed. |
| -1 :x: | compile | 0m 18s | root in master failed. |
| -1 :x: | javadoc | 0m 17s | root in master failed. |
| -0 :warning: | patch | 1m 10s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 31s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 17s | root in the patch failed. |
| -1 :x: | mvninstall | 0m 18s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | mvninstall | 0m 17s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | compile | 0m 18s | root in the patch failed. |
| -1 :x: | compile | 0m 17s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | compile | 0m 17s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javac | 0m 18s | root in the patch failed. |
| -1 :x: | javac | 0m 18s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javac | 0m 17s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 4s | The patch has no ill-formed XML file. |
| -1 :x: | javadoc | 0m 18s | root in the patch failed. |
| -1 :x: | javadoc | 0m 17s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javadoc | 0m 18s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 18s | root in the patch failed. |
| -1 :x: | unit | 0m 17s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | unit | 0m 17s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| +0 :ok: | asflicense | 0m 52s | ASF License check generated no output? |
| | | 7m 39s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/12/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/131 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux b33a8846f06b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 5bb7b54 |
| Default Java | Temurin-1.8.0_442-b06 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/12/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/12/artifact/yetus-precommit-check/output/branch-compile-root.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/12/artifact/yetus-precommit-check/output/branch-javadoc-root.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/12/artifact/yetus-precommit-check/output/patch-mvninstall-root.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/12/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-core.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/12/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-ee8.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/12/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/12/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/12/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/12/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/12/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/12/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/12/artifact/yetus-precommit-check/output/patch-javadoc-root.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/12/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-core.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/12/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-ee8.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/12/artifact/yetus-precommit-check/output/patch-unit-root.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/12/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-core.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/12/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-ee8.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/12/testReport/ |
| Max. process+thread count | 27 (vs. ulimit of 1000) |
| modules | C: . hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/12/console |
| versions | git=2.43.0 maven=3.9.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2866256581
Bumped to jetty 12.0.20, pending CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2760648558
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 28s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 47s | master passed |
| +1 :green_heart: | compile | 0m 13s | master passed |
| +1 :green_heart: | javadoc | 0m 7s | master passed |
| -0 :warning: | patch | 1m 12s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 4s | the patch passed |
| +1 :green_heart: | compile | 0m 30s | the patch passed |
| +1 :green_heart: | javac | 0m 30s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 0m 22s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-core in the patch passed. |
| +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch passed. |
| +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-ee9 in the patch passed. |
| +1 :green_heart: | unit | 0m 36s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 21s | The patch does not generate ASF License warnings. |
| | | 5m 4s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/7/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/131 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux 5260653248df 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 5bb7b54 |
| Default Java | Temurin-1.8.0_442-b06 |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/7/testReport/ |
| Max. process+thread count | 403 (vs. ulimit of 1000) |
| modules | C: hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 hbase-shaded-jetty-12-plus-ee9 . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/7/console |
| versions | git=2.43.0 maven=3.9.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2761145915
> +1 LGTM
>
> But let's wait what others have to say. (and the full tests)
Thank you so much @stoty for patiently reviewing this. Let me retrigger local UTs for hbase main with these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] Add a jetty 12 module with EE8 [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2715614147
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 1s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 48s | master passed |
| +1 :green_heart: | compile | 0m 14s | master passed |
| +1 :green_heart: | javadoc | 0m 8s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 0m 50s | the patch passed |
| +1 :green_heart: | compile | 0m 18s | the patch passed |
| +1 :green_heart: | javac | 0m 18s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 0m 11s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-ee8 in the patch passed. |
| +1 :green_heart: | unit | 0m 37s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. |
| | | 4m 42s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/1/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/131 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux 97571eb88e8f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 8eaa9c0 |
| Default Java | Temurin-1.8.0_442-b06 |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/1/testReport/ |
| Max. process+thread count | 403 (vs. ulimit of 1000) |
| modules | C: hbase-shaded-jetty-ee8 . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/1/console |
| versions | git=2.43.0 maven=3.9.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] Add a jetty 12 module with EE8 [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2715602851
Refer https://stackoverflow.com/questions/77007560/missing-jetty-servlet-12-0-0-dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2758060663
> IUC since the eeX stuff is in separate packages, we could add any or all ee specification modules.
> If we keep the ee8 name, then migrate to ee9/10 for jakarta, then the module/artifact name will be misleading.
> I would rather add the additional eeX modules to existing jetty thirdparty tha duplicate everything for each one.
Exactly that is the plan. Please refer https://issues.apache.org/jira/browse/HBASE-29224
> Phase 2:
Add Jetty 12 with EE9 to hbase-thirdparty and jersey 3. And may be some other artifacts (not sure at this point)
Next consume this version of hbase-thirdparty, move to jetty 12 with EE9, bump jakarta servlet to 5.x / 6.x, tomcat to 10.x / 11.x and migrate all the dependencies and code to jakarta namespace
Blockers?? Hadoop AuthenticationFilter dependent and related code need to be either shaded to move from javax to jakarta, or we would need to wait for hadoop for move to jakarta. (In my rough analysis, I have identified this till now, when we attempt it might be more stuff)
Test and verify everything is working as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2758052912
> > I am not sure about the name, but jetty12 wouldn't be great either.
>
> Yes hence thought to create env specific names.
IUC since the eeX stuff is in separate packages, we could add any or all ee specification modules.
If we keep the ee8 name, then migrate to ee9/10 for jakarta, then the module/artifact name will be misleading.
I would rather add the additional eeX modules to existing jetty thirdparty tha duplicate everything for each one.
As bad a jetty12 would be a bad name, at least we're not tying it to the ee spec version. Maybe jetty-new ? or Jetty-b ?
>
> > I guess that importing two different relocated jetty versions is not something that we want support, so re-using the package name is fine
>
> Yes this is a fair concern. Although, we would not want to have shaded jetty9 in our classpath if with have jetty12-eeX, but I am afraid what if hadoop timeline service or something else brings it in indirectly.?
Ideally, thirdparty netty shouldn't be brought in by the hbase client. ( I have not checked if that's true)
Anything expecting to run in the master/coprocessor JVMs shouldn also not be depending on thirdparty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2760337996
> Updated PR with both EE8 + EE9 changes (for testing purpose), will rerun UTs locally and update. Also renamed [hbase-shaded-jetty-ee8](https://issues.apache.org/jira/browse/HBASE-shaded-jetty-ee8) to [hbase-shaded-jetty-12-plus](https://issues.apache.org/jira/browse/HBASE-shaded-jetty-12-plus) for time being
I ran the UTs with the https://github.com/apache/hbase/pull/6783 and all tests passed locally. We are good with a single package for eeX.
> Do you think it would make sense to split this up, so that we have a base shaded jetty package, and separate jee8 and jee9 shaded packages ?
In HBase it may not help as our jetty-core and eeX specific imports happen together. I mean we don't seem to have an module which only depends on jetty but not eeX. We would eventually end up with including both dependencies to our module pom's.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] Add a jetty 12 module with EE8 [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2757843980
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 15s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| -1 :x: | mvninstall | 0m 18s | root in master failed. |
| -1 :x: | compile | 0m 17s | root in master failed. |
| -1 :x: | javadoc | 0m 17s | root in master failed. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 30s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 17s | root in the patch failed. |
| -1 :x: | mvninstall | 0m 18s | hbase-shaded-jetty-ee8 in the patch failed. |
| -1 :x: | compile | 0m 17s | root in the patch failed. |
| -1 :x: | compile | 0m 17s | hbase-shaded-jetty-ee8 in the patch failed. |
| -1 :x: | javac | 0m 17s | root in the patch failed. |
| -1 :x: | javac | 0m 17s | hbase-shaded-jetty-ee8 in the patch failed. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| -1 :x: | javadoc | 0m 17s | root in the patch failed. |
| -1 :x: | javadoc | 0m 17s | hbase-shaded-jetty-ee8 in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 17s | root in the patch failed. |
| -1 :x: | unit | 0m 18s | hbase-shaded-jetty-ee8 in the patch failed. |
| +0 :ok: | asflicense | 0m 34s | ASF License check generated no output? |
| | | 5m 53s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/2/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/131 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux 1ad86d6e6116 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 5bb7b54 |
| Default Java | Temurin-1.8.0_442-b06 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/2/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/2/artifact/yetus-precommit-check/output/branch-compile-root.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/2/artifact/yetus-precommit-check/output/branch-javadoc-root.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/2/artifact/yetus-precommit-check/output/patch-mvninstall-root.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/2/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-ee8.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/2/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/2/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-ee8.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/2/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/2/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-ee8.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/2/artifact/yetus-precommit-check/output/patch-javadoc-root.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/2/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-ee8.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/2/artifact/yetus-precommit-check/output/patch-unit-root.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/2/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-ee8.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/2/testReport/ |
| Max. process+thread count | 27 (vs. ulimit of 1000) |
| modules | C: . hbase-shaded-jetty-ee8 U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/2/console |
| versions | git=2.43.0 maven=3.9.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2758157573
> > As bad a jetty12 would be a bad name, at least we're not tying it to the ee spec version. Maybe jetty-new ? or Jetty-b ?
>
> I am not sure if I understand you correctly but we may need all versions of jetty to exist:
>
> * [hbase-shaded-jetty](https://issues.apache.org/jira/browse/HBASE-shaded-jetty): for <= branch-2.6
> * [hbase-shaded-jetty-ee8](https://issues.apache.org/jira/browse/HBASE-shaded-jetty-ee8): possibly for branch-2, if we decide to backport retaining javax namespace
> * [hbase-shaded-jetty-ee9](https://issues.apache.org/jira/browse/HBASE-shaded-jetty-ee9): For branch-3+ with jakarta namespace change
>
> Hence created a new module for ee8 as first step.
AFAICT ee8 and ee9 does not have to be a separate project.
IUC the different modules can co-exist because they are under different package names.
So we could maintain a single hbase-shaded-netty-whatever package, that includes ee8 for now, and we can add ee9 later (while retaining ee8 for older hbase branches).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2828881463
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 3m 50s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| -1 :x: | mvninstall | 0m 18s | root in master failed. |
| -1 :x: | compile | 0m 17s | root in master failed. |
| -1 :x: | javadoc | 0m 18s | root in master failed. |
| -0 :warning: | patch | 1m 10s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 30s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 18s | root in the patch failed. |
| -1 :x: | mvninstall | 0m 17s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | mvninstall | 0m 17s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | compile | 0m 17s | root in the patch failed. |
| -1 :x: | compile | 0m 18s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | compile | 0m 17s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| -1 :x: | javac | 0m 17s | root in the patch failed. |
| -1 :x: | javac | 0m 18s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javac | 0m 17s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 5s | The patch has no ill-formed XML file. |
| -1 :x: | javadoc | 0m 17s | root in the patch failed. |
| -1 :x: | javadoc | 0m 17s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | javadoc | 0m 18s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 17s | root in the patch failed. |
| -1 :x: | unit | 0m 18s | hbase-shaded-jetty-12-plus-core in the patch failed. |
| -1 :x: | unit | 0m 17s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. |
| +0 :ok: | asflicense | 0m 53s | ASF License check generated no output? |
| | | 10m 8s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/13/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/131 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux 442767e493b5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 5bb7b54 |
| Default Java | Temurin-1.8.0_442-b06 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/13/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/13/artifact/yetus-precommit-check/output/branch-compile-root.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/13/artifact/yetus-precommit-check/output/branch-javadoc-root.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/13/artifact/yetus-precommit-check/output/patch-mvninstall-root.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/13/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-core.txt |
| mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/13/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-jetty-12-plus-ee8.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/13/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/13/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/13/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/13/artifact/yetus-precommit-check/output/patch-compile-root.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/13/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-core.txt |
| javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/13/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-jetty-12-plus-ee8.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/13/artifact/yetus-precommit-check/output/patch-javadoc-root.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/13/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-core.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/13/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-jetty-12-plus-ee8.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/13/artifact/yetus-precommit-check/output/patch-unit-root.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/13/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-core.txt |
| unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/13/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-jetty-12-plus-ee8.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/13/testReport/ |
| Max. process+thread count | 31 (vs. ulimit of 1000) |
| modules | C: . hbase-shaded-jetty-12-plus-core hbase-shaded-jetty-12-plus-ee8 U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/13/console |
| versions | git=2.43.0 maven=3.9.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2866274757
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 0s | Docker mode activated. |
| -1 :x: | patch | 0m 3s | https://github.com/apache/hbase-thirdparty/pull/131 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/131 |
| Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-131/18/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2866238967
> Hi @stoty Should I go ahead and merge this one? Or should wait a few more days for more eyes?
Will go ahead and merge this today.? could not get any more reviews here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#discussion_r2018169177
##########
hbase-shaded-jetty-12-plus-ee9/pom.xml:
##########
@@ -0,0 +1,196 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+ <!--
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+ ON MVN COMPILE NOT WORKING
+
+ If you wondering why 'mvn compile' does not work building HBase
+ (in particular, if you are doing it for the first time), instead do
+ 'mvn package'. If you are interested in the full story, see
+ https://issues.apache.org/jira/browse/HBASE-6795.
+
+-->
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.hbase.thirdparty</groupId>
+ <artifactId>hbase-thirdparty</artifactId>
+ <version>${revision}</version>
+ <relativePath>..</relativePath>
+ </parent>
+ <artifactId>hbase-shaded-jetty-12-plus-ee9</artifactId>
+ <name>Apache HBase Relocated (Shaded) Jetty 12+ Libs: EE9</name>
+ <description>Pulls down Jetty EE9, relocates it and makes a far jar.</description>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.hbase.thirdparty</groupId>
+ <artifactId>hbase-shaded-jetty-12-plus-core</artifactId>
+ <version>${project.version}</version>
Review Comment:
I see.
I'm wary of exclude, as it tends to be fragile when module structure changes.
Can you try adding the same dependencies as core has, but with provided scope ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2760659697
> Looks good apart from the slf4j exclusions in provided. Can you attach the dependency tree for this version ?
With commit 7, fixing exclusion in provided:
```
[INFO] ----< org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-core >-----
[INFO] Building Apache HBase Relocated (Shaded) Jetty 12+ Libs: Core 4.1.11-SNAPSHOT [8/14]
[INFO] from hbase-shaded-jetty-12-plus-core/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- dependency:3.6.0:tree (default-cli) @ hbase-shaded-jetty-12-plus-core ---
[INFO] org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-core:jar:4.1.11-SNAPSHOT
[INFO] +- org.eclipse.jetty:jetty-server:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-http:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-util:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-io:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-jmx:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-util-ajax:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-security:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-session:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-ee:jar:12.0.18:compile
[INFO] \- org.eclipse.jetty:jetty-xml:jar:12.0.18:compile
[INFO]
[INFO] -----< org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-ee8 >-----
[INFO] Building Apache HBase Relocated (Shaded) Jetty 12+ Libs: EE8 4.1.11-SNAPSHOT [9/14]
[INFO] from hbase-shaded-jetty-12-plus-ee8/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- dependency:3.6.0:tree (default-cli) @ hbase-shaded-jetty-12-plus-ee8 ---
[INFO] org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-ee8:jar:4.1.11-SNAPSHOT
[INFO] +- org.eclipse.jetty.ee8:jetty-ee8-servlet:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty.ee8:jetty-ee8-security:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty.ee8:jetty-ee8-nested:jar:12.0.18:compile
[INFO] | \- org.eclipse.jetty.toolchain:jetty-servlet-api:jar:4.0.6:compile
[INFO] +- org.eclipse.jetty.ee8:jetty-ee8-webapp:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-server:jar:12.0.18:provided
[INFO] | \- org.slf4j:slf4j-api:jar:2.0.16:provided
[INFO] +- org.eclipse.jetty:jetty-http:jar:12.0.18:provided
[INFO] +- org.eclipse.jetty:jetty-util:jar:12.0.18:provided
[INFO] +- org.eclipse.jetty:jetty-io:jar:12.0.18:provided
[INFO] +- org.eclipse.jetty:jetty-jmx:jar:12.0.18:provided
[INFO] +- org.eclipse.jetty:jetty-util-ajax:jar:12.0.18:provided
[INFO] +- org.eclipse.jetty:jetty-security:jar:12.0.18:provided
[INFO] +- org.eclipse.jetty:jetty-session:jar:12.0.18:provided
[INFO] +- org.eclipse.jetty:jetty-ee:jar:12.0.18:provided
[INFO] \- org.eclipse.jetty:jetty-xml:jar:12.0.18:provided
[INFO]
[INFO] -----< org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-ee9 >-----
[INFO] Building Apache HBase Relocated (Shaded) Jetty 12+ Libs: EE9 4.1.11-SNAPSHOT [10/14]
[INFO] from hbase-shaded-jetty-12-plus-ee9/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- dependency:3.6.0:tree (default-cli) @ hbase-shaded-jetty-12-plus-ee9 ---
[INFO] org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-ee9:jar:4.1.11-SNAPSHOT
[INFO] +- org.eclipse.jetty.ee9:jetty-ee9-servlet:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty.ee9:jetty-ee9-security:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty.ee9:jetty-ee9-nested:jar:12.0.18:compile
[INFO] | \- org.eclipse.jetty.toolchain:jetty-jakarta-servlet-api:jar:5.0.2:compile
[INFO] +- org.eclipse.jetty.ee9:jetty-ee9-webapp:jar:12.0.18:compile
[INFO] +- org.eclipse.jetty:jetty-server:jar:12.0.18:provided
[INFO] | \- org.slf4j:slf4j-api:jar:2.0.16:provided
[INFO] +- org.eclipse.jetty:jetty-http:jar:12.0.18:provided
[INFO] +- org.eclipse.jetty:jetty-util:jar:12.0.18:provided
[INFO] +- org.eclipse.jetty:jetty-io:jar:12.0.18:provided
[INFO] +- org.eclipse.jetty:jetty-jmx:jar:12.0.18:provided
[INFO] +- org.eclipse.jetty:jetty-util-ajax:jar:12.0.18:provided
[INFO] +- org.eclipse.jetty:jetty-security:jar:12.0.18:provided
[INFO] +- org.eclipse.jetty:jetty-session:jar:12.0.18:provided
[INFO] +- org.eclipse.jetty:jetty-ee:jar:12.0.18:provided
[INFO] \- org.eclipse.jetty:jetty-xml:jar:12.0.18:provided
[INFO]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2760635346
we got out of sync...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#discussion_r2018530428
##########
pom.xml:
##########
@@ -139,6 +142,7 @@
<error_prone_annotations.version>2.36.0</error_prone_annotations.version>
<gson.version>2.11.0</gson.version>
<jetty.version>9.4.56.v20240826</jetty.version>
+ <jetty12.version>12.0.18</jetty12.version>
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #131:
URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2760361951
> > > My use case would be for example:
> > >
> > > * Hbase 3.0 uses ee8, so we don't need the ee10 modules
> > > * HBase 3.1 uses ee10, so we don't need the ee8 modules.
> > >
> > > Not a huge deal either way, but saves a bit on the assembly size.
> >
> >
> > Ah yes we could definitely save a few MBs here and avoid bundling redundant code. Just to be clear, we are suggesting to break into modules as below:
> >
> > * Jetty-12-plus
> > * Jetty-12-plus-EE8
> > * Jetty-12-plus-EE10 etc
> >
> > So basically fall back to the initial approach of this PR, but maybe a new module for base? Right?
>
> Right
Cool sounds good to me, should I update the PR with the suggestion? or wait sometime for what others opine? I am good either ways, simple change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org