You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "ywkaras (via GitHub)" <gi...@apache.org> on 2023/02/17 03:27:41 UTC
[GitHub] [trafficserver] ywkaras opened a new pull request, #9433: Ethread::process_event(): make sure event mutex is unlocked before freeing event.
ywkaras opened a new pull request, #9433:
URL: https://github.com/apache/trafficserver/pull/9433
Also adds important information to docs about TSMutexDestroy().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras merged pull request #9433: Ethread::process_event(): make sure event mutex is unlocked before freeing event.
Posted by "ywkaras (via GitHub)" <gi...@apache.org>.
ywkaras merged PR #9433:
URL: https://github.com/apache/trafficserver/pull/9433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on a diff in pull request #9433: Ethread::process_event(): make sure event mutex is unlocked before freeing event.
Posted by "masaori335 (via GitHub)" <gi...@apache.org>.
masaori335 commented on code in PR #9433:
URL: https://github.com/apache/trafficserver/pull/9433#discussion_r1111390954
##########
iocore/eventsystem/UnixEThread.cc:
##########
@@ -161,6 +162,7 @@ EThread::process_event(Event *e, int calling_code)
EventQueueExternal.enqueue_local(e);
}
} else if (!e->in_the_prot_queue && !e->in_the_priority_queue) {
+ MUTEX_RELEASE(lock);
Review Comment:
It looks like the `lock` is already released in line 154 for this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on a diff in pull request #9433: Ethread::process_event(): make sure event mutex is unlocked before freeing event.
Posted by "ywkaras (via GitHub)" <gi...@apache.org>.
ywkaras commented on code in PR #9433:
URL: https://github.com/apache/trafficserver/pull/9433#discussion_r1112518770
##########
iocore/eventsystem/UnixEThread.cc:
##########
@@ -161,6 +162,7 @@ EThread::process_event(Event *e, int calling_code)
EventQueueExternal.enqueue_local(e);
}
} else if (!e->in_the_prot_queue && !e->in_the_priority_queue) {
+ MUTEX_RELEASE(lock);
Review Comment:
Yes, I'll fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org