You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2014/04/03 03:03:28 UTC
svn commit: r1584237 -
/commons/proper/jcs/trunk/src/java/org/apache/commons/jcs/utils/config/OptionConverter.java
Author: sebb
Date: Thu Apr 3 01:03:28 2014
New Revision: 1584237
URL: http://svn.apache.org/r1584237
Log:
Tidy up - no need to share StringBuffer
Modified:
commons/proper/jcs/trunk/src/java/org/apache/commons/jcs/utils/config/OptionConverter.java
Modified: commons/proper/jcs/trunk/src/java/org/apache/commons/jcs/utils/config/OptionConverter.java
URL: http://svn.apache.org/viewvc/commons/proper/jcs/trunk/src/java/org/apache/commons/jcs/utils/config/OptionConverter.java?rev=1584237&r1=1584236&r2=1584237&view=diff
==============================================================================
--- commons/proper/jcs/trunk/src/java/org/apache/commons/jcs/utils/config/OptionConverter.java (original)
+++ commons/proper/jcs/trunk/src/java/org/apache/commons/jcs/utils/config/OptionConverter.java Thu Apr 3 01:03:28 2014
@@ -35,19 +35,16 @@ public class OptionConverter
private static final Log log = LogFactory.getLog( OptionConverter.class );
/** System property delimter */
- static String DELIM_START = "${";
+ private static final String DELIM_START = "${";
/** System property delimter */
- static char DELIM_STOP = '}';
+ private static final char DELIM_STOP = '}';
/** System property delimter start length */
- static int DELIM_START_LEN = 2;
+ private static final int DELIM_START_LEN = 2;
/** System property delimter end length */
- static int DELIM_STOP_LEN = 1;
-
- /** working buffer */
- static StringBuffer sbuf = new StringBuffer(); // TODO can this be changed to StringBuilder??
+ private static final int DELIM_STOP_LEN = 1;
/** No instances please. */
private OptionConverter()
@@ -385,7 +382,7 @@ public class OptionConverter
public static String substVars( String val, Properties props )
throws IllegalArgumentException
{
- sbuf.setLength( 0 );
+ StringBuilder sbuf = new StringBuilder();
int i = 0;
int j;