You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by gi...@git.apache.org on 2017/09/28 15:01:02 UTC

[GitHub] rhunwicks commented on issue #3492: PandasConnector

rhunwicks commented on issue #3492: PandasConnector
URL: https://github.com/apache/incubator-superset/pull/3492#issuecomment-332864586
 
 
   @mistercrunch I have moved the migration into `superset/migrations/versions` in order to get Travis to run. I can move it back out if you decide you want to keep it in a `contrib` directory.
   
   I have also added `lxml` and `beautifulsoup4` to `dev-reqs.txt` because `contrib.tests.connector_tests` uses them to prepare test data. `connector_tests` is probably useful for other people writing connectors as well as providing increased test coverage for `superset/connectors/sqla/models.py` so you might want to adopt some of it into core.
   
   Please let me know what you would like me to do next?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services