You are viewing a plain text version of this content. The canonical link for it is here.

Posted to hdfs-issues@hadoop.apache.org by "Jing Zhao (JIRA)" <ji...@apache.org> on 2014/04/14 23:42:15 UTC

[jira] [Commented] (HDFS-6243) HA NameNode transition to active or shutdown may leave lingering image transfer thread.

    [ https://issues.apache.org/jira/browse/HDFS-6243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968888#comment-13968888 ] 

Jing Zhao commented on HDFS-6243:
---------------------------------

The patch looks pretty good to me. So for the unit test testCheckpointCancellationDuringUpload, can we add a simple check after the cancellation to make sure that the remote NN can catch the inconsistency of the image file length and ignore the incomplete checkpoint?

> HA NameNode transition to active or shutdown may leave lingering image transfer thread.
> ---------------------------------------------------------------------------------------
>
>                 Key: HDFS-6243
>                 URL: https://issues.apache.org/jira/browse/HDFS-6243
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: ha, namenode
>    Affects Versions: 3.0.0, 2.4.0
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HDFS-6243.1.patch
>
>
> With HDFS-4816, the standby uploads the new checkpoint to the active in a background thread.  This thread may continue to execute after transitioning to active or shutting down.  This is marginally wasteful of bandwidth if the image transfer is large, and it also breaks subsequent tests on Windows since the thread continues to hold a lock on a file descriptor in the storage directory.



--
This message was sent by Atlassian JIRA
(v6.2#6252)