You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "peter-toth (via GitHub)" <gi...@apache.org> on 2023/09/11 17:10:46 UTC

[GitHub] [spark] peter-toth opened a new pull request, #42872: [SPARK-45109][SQL][CONNECT][3.4] Fix log function in Connect

peter-toth opened a new pull request, #42872:
URL: https://github.com/apache/spark/pull/42872

   ### What changes were proposed in this pull request?
   This is a follow-up PR to https://github.com/apache/spark/pull/42863, the 1 argument `log` function should also point to `ln`.
   
   ### Why are the changes needed?
   Bugfix.
   
   ### Does this PR introduce _any_ user-facing change?
   No, these Spark Connect functions haven't been released.
   
   ### How was this patch tested?
   Exsiting UTs.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng commented on pull request #42872: [SPARK-45109][SQL][CONNECT][3.4] Fix log function in Connect

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #42872:
URL: https://github.com/apache/spark/pull/42872#issuecomment-1714832708

   @dongjoon-hyun the functions https://issues.apache.org/jira/browse/SPARK-45109 was introduced in 3.5


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun closed pull request #42872: [SPARK-45109][SQL][CONNECT][3.4] Fix log function in Connect

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #42872: [SPARK-45109][SQL][CONNECT][3.4] Fix log function in Connect
URL: https://github.com/apache/spark/pull/42872


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #42872: [SPARK-45109][SQL][CONNECT][3.4] Fix log function in Connect

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42872:
URL: https://github.com/apache/spark/pull/42872#issuecomment-1715145911

   Thank you, @peter-toth and @zhengruifeng .
   Merged to branch-3.4.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] peter-toth commented on pull request #42872: [SPARK-45109][SQL][CONNECT][3.4] Fix log function in Connect

Posted by "peter-toth (via GitHub)" <gi...@apache.org>.
peter-toth commented on PR #42872:
URL: https://github.com/apache/spark/pull/42872#issuecomment-1715076698

   > Actually, [SPARK-45109](https://issues.apache.org/jira/browse/SPARK-45109) didn't land at branch-3.4 yet.
   > 
   > Since this is a first commit, shall we say it like `This is a backport ...` instead of `This is a follow-up...`, @peter-toth , in the PR description?
   
   Thanks @dongjoon-hyun, I rephrased the PR description to make it clear why we need this backport.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org