[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #7642: Web console - add enable/disable actions for middle manager workers

[GitBox <gi...@apache.org>]

surekhasaharan commented on a change in pull request #7642: Web console - add enable/disable actions for middle manager workers
URL: https://github.com/apache/incubator-druid/pull/7642#discussion_r284907247
 
 

 ##########
 File path: indexing-service/src/main/java/org/apache/druid/indexing/overlord/RemoteTaskRunner.java
 ##########
 @@ -453,6 +454,64 @@ public void unregisterListener(String listenerId)
     return ImmutableList.copyOf(pendingTaskPayloads.values());
   }
 
+  @Override
+  public void enableWorker(String host)
+  {
+    sendRequestToWorker(host, "enable");
 
 Review comment:
   looks like "enable" and "disable" strings are used at couple of places in this patch. Suggest to add an enum in `WorkerTaskRunner`  interface like
   ``` 
    enum ActionType{
       enable,
       disable
     }
   ```
   and use that instead of strings to avoid errors.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org