[GitHub] [cordova-plugin-inappbrowser] janpio commented on a change in pull request #363: feat(android, ios): add request headers support

[GitBox <gi...@apache.org>]

janpio commented on a change in pull request #363: feat(android,ios): add request headers support
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/363#discussion_r300997616
 
 

 ##########
 File path: src/android/InAppBrowser.java
 ##########
 @@ -271,7 +272,7 @@ public void run() {
                     } else {
                         ((InAppBrowserClient)inAppWebView.getWebViewClient()).waitForBeforeload = false;
                     }
-                    inAppWebView.loadUrl(url);
+                    inAppWebView.loadUrl(url, null);
 
 Review comment:
   Why all those changes to the `loadUrl` calls if we don't actually change the method signature ourselves? Couldn't we just keep these as they are and only add the `headers` in the places where we need it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org