You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by gn...@apache.org on 2024/05/23 12:25:10 UTC
(maven) branch master updated: [MNG-7902] Sort plugins in the validation report (#1510)
This is an automated email from the ASF dual-hosted git repository.
gnodet pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven.git
The following commit(s) were added to refs/heads/master by this push:
new dd9679450e [MNG-7902] Sort plugins in the validation report (#1510)
dd9679450e is described below
commit dd9679450e00d08caf4f042d92c22acd38585bd5
Author: Yueh Chun Wu <15...@users.noreply.github.com>
AuthorDate: Thu May 23 05:25:04 2024 -0700
[MNG-7902] Sort plugins in the validation report (#1510)
Co-authored-by: Yueh Chun Wu <ke...@YuehdeMBP.attlocal.net>
---
.../maven/plugin/internal/DefaultPluginValidationManager.java | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginValidationManager.java b/maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginValidationManager.java
index 0794a548f7..cf15292df8 100644
--- a/maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginValidationManager.java
+++ b/maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginValidationManager.java
@@ -23,6 +23,7 @@ import javax.inject.Singleton;
import java.nio.file.Path;
import java.nio.file.Paths;
+import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
import java.util.Collections;
@@ -222,7 +223,12 @@ public final class DefaultPluginValidationManager extends AbstractEventSpy imple
logger.warn("");
logger.warn("Plugin {} validation issues were detected in following plugin(s)", issueLocalitiesToReport);
logger.warn("");
- for (Map.Entry<String, PluginValidationIssues> entry : issuesMap.entrySet()) {
+
+ // Sorting the plugins
+ List<Map.Entry<String, PluginValidationIssues>> sortedEntries = new ArrayList<>(issuesMap.entrySet());
+ sortedEntries.sort(Map.Entry.comparingByKey(String.CASE_INSENSITIVE_ORDER));
+
+ for (Map.Entry<String, PluginValidationIssues> entry : sortedEntries) {
PluginValidationIssues issues = entry.getValue();
if (!hasAnythingToReport(issues, issueLocalitiesToReport)) {
continue;