You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/12/14 16:01:04 UTC
[GitHub] [ignite-3] sashapolo opened a new pull request, #1451: IGNITE-18413 Reorganize metastorage modules
sashapolo opened a new pull request, #1451:
URL: https://github.com/apache/ignite-3/pull/1451
https://issues.apache.org/jira/browse/IGNITE-18413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] agura commented on a diff in pull request #1451: IGNITE-18413 Reorganize metastorage modules
Posted by GitBox <gi...@apache.org>.
agura commented on code in PR #1451:
URL: https://github.com/apache/ignite-3/pull/1451#discussion_r1050237885
##########
modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/dsl/OperationType.java:
##########
@@ -15,7 +15,7 @@
* limitations under the License.
*/
-package org.apache.ignite.internal.metastorage.common;
+package org.apache.ignite.internal.metastorage.dsl;
Review Comment:
I really don't like the `dsl` name. There is still a difference between a language and an API. Really minor, but I can't be silent :)
##########
modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java:
##########
@@ -0,0 +1,125 @@
+/*
Review Comment:
What is a difference between `MetaStorageManager` and `MetaStorageService`? Also we have some conventions about a naming and what I see from this interface is a service rather than a manager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ibessonov merged pull request #1451: IGNITE-18413 Reorganize metastorage modules
Posted by GitBox <gi...@apache.org>.
ibessonov merged PR #1451:
URL: https://github.com/apache/ignite-3/pull/1451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1451: IGNITE-18413 Reorganize metastorage modules
Posted by GitBox <gi...@apache.org>.
sashapolo commented on code in PR #1451:
URL: https://github.com/apache/ignite-3/pull/1451#discussion_r1050503591
##########
modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java:
##########
@@ -0,0 +1,125 @@
+/*
Review Comment:
I agree with you, however this is how it was implemented before my changes, I simply extracted an interface. I don't want to rename this in my PR in order to reduce the amount of changes.
##########
modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/dsl/OperationType.java:
##########
@@ -15,7 +15,7 @@
* limitations under the License.
*/
-package org.apache.ignite.internal.metastorage.common;
+package org.apache.ignite.internal.metastorage.dsl;
Review Comment:
Sure, do you have a better name in mind?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org