You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/06/01 12:14:09 UTC
[GitHub] [incubator-pegasus] WHBANG opened a new pull request, #989: ci(java-client): Use GitHub action to check and format Java code style instead of jar plugin
WHBANG opened a new pull request, #989:
URL: https://github.com/apache/incubator-pegasus/pull/989
### What problem does this PR solve? <!--add issue link with summary if exists-->
https://github.com/apache/incubator-pegasus/issues/988
### What is changed and how does it work?
change java-client ci
### Checklist <!--REMOVE the items that are not applicable-->
##### Tests <!-- At least one of them must be included. -->
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code
##### Code changes
- Has exported function/method change
- Has exported variable/fields change
- Has interface methods change
- Has persistent data change
##### Side effects
- Possible performance regression
- Increased code complexity
- Breaking backward compatibility
##### Related changes
- Need to cherry-pick to the release branch
- Need to update the documentation
- Need to be included in the release note
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] foreverneverer commented on a diff in pull request #989: ci(java-client): GitHub action uses checkstyle to replace plugins for java-client code style checking during CI
Posted by GitBox <gi...@apache.org>.
foreverneverer commented on code in PR #989:
URL: https://github.com/apache/incubator-pegasus/pull/989#discussion_r885240711
##########
java-client/pom.xml:
##########
@@ -395,45 +390,6 @@
<version>0.13</version>
</plugin>
- <plugin>
- <groupId>com.diffplug.spotless</groupId>
- <artifactId>spotless-maven-plugin</artifactId>
- <version>2.12.2</version>
- <configuration>
- <formats>
- <format>
- <includes>
- <include>*.md</include>
- <include>.gitignore</include>
- </includes>
- <trimTrailingWhitespace/>
- <endWithNewline/>
- <indent>
- <tabs>true</tabs>
- <spacesPerTab>4</spacesPerTab>
- </indent>
- </format>
- </formats>
- <java>
- <excludes>
- <exclude>src/main/java/org/apache/infra/pegasus/apps/*</exclude>
- <exclude>src/main/java/org/apache/infra/pegasus/replication/*</exclude>
- </excludes>
- <googleJavaFormat>
- <version>1.7</version>
- <style>GOOGLE</style>
- </googleJavaFormat>
- </java>
- </configuration>
- <executions>
- <execution>
- <goals>
- <goal>check</goal>
- </goals>
- <phase>compile</phase>
- </execution>
- </executions>
- </plugin>
Review Comment:
if you delete the plugin, how to format code to be rigtht?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on pull request #989: ci(java-client): GitHub action uses checkstyle to replace plugins for java-client code style checking during CI
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on PR #989:
URL: https://github.com/apache/incubator-pegasus/pull/989#issuecomment-1143090938
> > Java client actions are not running normally, https://github.com/apache/incubator-pegasus/actions/runs/2412968234
>
> I've asked the ASF infra team to enable these actions, plz wait. jira: https://issues.apache.org/jira/browse/INFRA-23313
I’ve closed this issue, I'll reopen it after we decide to use which actions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on pull request #989: ci(java-client): GitHub action uses checkstyle to replace plugins for java-client code style checking during CI
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on PR #989:
URL: https://github.com/apache/incubator-pegasus/pull/989#issuecomment-1143422218
> > > Java client actions are not running normally, https://github.com/apache/incubator-pegasus/actions/runs/2412968234
> >
> >
> > I've asked the ASF infra team to enable these actions, plz wait. jira: https://issues.apache.org/jira/browse/INFRA-23313
>
> I’ve closed this issue, I'll reopen it after we decide to use which actions.
new issue to track it https://issues.apache.org/jira/browse/INFRA-23327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #989: ci(java-client): GitHub action uses checkstyle to replace plugins for java-client code style checking during CI
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #989:
URL: https://github.com/apache/incubator-pegasus/pull/989#discussion_r886353810
##########
.github/workflows/test_java-client.yml:
##########
@@ -35,9 +35,19 @@ defaults:
shell: bash
jobs:
+ google-java-format:
+ name: java-format
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2 # v2 minimum required
+ - uses: axel-op/googlejavaformat-action@v3.6.0
Review Comment:
Could you give an example to show how it work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 closed pull request #989: ci(java-client): Use GitHub action to check and format Java code style instead of jar plugin
Posted by GitBox <gi...@apache.org>.
acelyc111 closed pull request #989: ci(java-client): Use GitHub action to check and format Java code style instead of jar plugin
URL: https://github.com/apache/incubator-pegasus/pull/989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 closed pull request #989: ci(java-client): Use GitHub action to check and format Java code style instead of jar plugin
Posted by GitBox <gi...@apache.org>.
acelyc111 closed pull request #989: ci(java-client): Use GitHub action to check and format Java code style instead of jar plugin
URL: https://github.com/apache/incubator-pegasus/pull/989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on pull request #989: ci(java-client): GitHub action uses checkstyle to replace plugins for java-client code style checking during CI
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on PR #989:
URL: https://github.com/apache/incubator-pegasus/pull/989#issuecomment-1141715596
> Java client actions are not running normally, https://github.com/apache/incubator-pegasus/actions/runs/2412968234
I've asked the ASF infra team to enable these actions, plz wait.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #989: ci(java-client): GitHub action uses checkstyle to replace plugins for java-client code style checking during CI
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #989:
URL: https://github.com/apache/incubator-pegasus/pull/989#discussion_r885247900
##########
java-client/pom.xml:
##########
@@ -395,45 +390,6 @@
<version>0.13</version>
</plugin>
- <plugin>
- <groupId>com.diffplug.spotless</groupId>
- <artifactId>spotless-maven-plugin</artifactId>
- <version>2.12.2</version>
- <configuration>
- <formats>
- <format>
- <includes>
- <include>*.md</include>
- <include>.gitignore</include>
- </includes>
- <trimTrailingWhitespace/>
- <endWithNewline/>
- <indent>
- <tabs>true</tabs>
- <spacesPerTab>4</spacesPerTab>
- </indent>
- </format>
- </formats>
- <java>
- <excludes>
- <exclude>src/main/java/org/apache/infra/pegasus/apps/*</exclude>
- <exclude>src/main/java/org/apache/infra/pegasus/replication/*</exclude>
- </excludes>
- <googleJavaFormat>
- <version>1.7</version>
- <style>GOOGLE</style>
- </googleJavaFormat>
- </java>
- </configuration>
- <executions>
- <execution>
- <goals>
- <goal>check</goal>
- </goals>
- <phase>compile</phase>
- </execution>
- </executions>
- </plugin>
Review Comment:
In the role of a basic component, Pegasus java-client should better depend on less packages. I think check and format code style is not necessary to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] foreverneverer commented on a diff in pull request #989: ci(java-client): GitHub action uses checkstyle to replace plugins for java-client code style checking during CI
Posted by GitBox <gi...@apache.org>.
foreverneverer commented on code in PR #989:
URL: https://github.com/apache/incubator-pegasus/pull/989#discussion_r885294330
##########
java-client/pom.xml:
##########
@@ -395,45 +390,6 @@
<version>0.13</version>
</plugin>
- <plugin>
- <groupId>com.diffplug.spotless</groupId>
- <artifactId>spotless-maven-plugin</artifactId>
- <version>2.12.2</version>
- <configuration>
- <formats>
- <format>
- <includes>
- <include>*.md</include>
- <include>.gitignore</include>
- </includes>
- <trimTrailingWhitespace/>
- <endWithNewline/>
- <indent>
- <tabs>true</tabs>
- <spacesPerTab>4</spacesPerTab>
- </indent>
- </format>
- </formats>
- <java>
- <excludes>
- <exclude>src/main/java/org/apache/infra/pegasus/apps/*</exclude>
- <exclude>src/main/java/org/apache/infra/pegasus/replication/*</exclude>
- </excludes>
- <googleJavaFormat>
- <version>1.7</version>
- <style>GOOGLE</style>
- </googleJavaFormat>
- </java>
- </configuration>
- <executions>
- <execution>
- <goals>
- <goal>check</goal>
- </goals>
- <phase>compile</phase>
- </execution>
- </executions>
- </plugin>
Review Comment:
I write new code, and checkstyle not pass, tell me how to do can let the check pass?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on pull request #989: ci(java-client): GitHub action uses checkstyle to replace plugins for java-client code style checking during CI
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on PR #989:
URL: https://github.com/apache/incubator-pegasus/pull/989#issuecomment-1141706220
Seems java client actions are not running normally, https://github.com/apache/incubator-pegasus/actions/runs/2412968234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on pull request #989: ci(java-client): Use GitHub action to check and format Java code style instead of jar plugin
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on PR #989:
URL: https://github.com/apache/incubator-pegasus/pull/989#issuecomment-1152513475
Will be resolved by https://github.com/apache/incubator-pegasus/pull/1000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] foreverneverer commented on a diff in pull request #989: ci(java-client): GitHub action uses checkstyle to replace plugins for java-client code style checking during CI
Posted by GitBox <gi...@apache.org>.
foreverneverer commented on code in PR #989:
URL: https://github.com/apache/incubator-pegasus/pull/989#discussion_r885240711
##########
java-client/pom.xml:
##########
@@ -395,45 +390,6 @@
<version>0.13</version>
</plugin>
- <plugin>
- <groupId>com.diffplug.spotless</groupId>
- <artifactId>spotless-maven-plugin</artifactId>
- <version>2.12.2</version>
- <configuration>
- <formats>
- <format>
- <includes>
- <include>*.md</include>
- <include>.gitignore</include>
- </includes>
- <trimTrailingWhitespace/>
- <endWithNewline/>
- <indent>
- <tabs>true</tabs>
- <spacesPerTab>4</spacesPerTab>
- </indent>
- </format>
- </formats>
- <java>
- <excludes>
- <exclude>src/main/java/org/apache/infra/pegasus/apps/*</exclude>
- <exclude>src/main/java/org/apache/infra/pegasus/replication/*</exclude>
- </excludes>
- <googleJavaFormat>
- <version>1.7</version>
- <style>GOOGLE</style>
- </googleJavaFormat>
- </java>
- </configuration>
- <executions>
- <execution>
- <goals>
- <goal>check</goal>
- </goals>
- <phase>compile</phase>
- </execution>
- </executions>
- </plugin>
Review Comment:
if you delete the plugin, how to format code to match ci for user?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] foreverneverer commented on a diff in pull request #989: ci(java-client): GitHub action uses checkstyle to replace plugins for java-client code style checking during CI
Posted by GitBox <gi...@apache.org>.
foreverneverer commented on code in PR #989:
URL: https://github.com/apache/incubator-pegasus/pull/989#discussion_r885264050
##########
java-client/pom.xml:
##########
@@ -395,45 +390,6 @@
<version>0.13</version>
</plugin>
- <plugin>
- <groupId>com.diffplug.spotless</groupId>
- <artifactId>spotless-maven-plugin</artifactId>
- <version>2.12.2</version>
- <configuration>
- <formats>
- <format>
- <includes>
- <include>*.md</include>
- <include>.gitignore</include>
- </includes>
- <trimTrailingWhitespace/>
- <endWithNewline/>
- <indent>
- <tabs>true</tabs>
- <spacesPerTab>4</spacesPerTab>
- </indent>
- </format>
- </formats>
- <java>
- <excludes>
- <exclude>src/main/java/org/apache/infra/pegasus/apps/*</exclude>
- <exclude>src/main/java/org/apache/infra/pegasus/replication/*</exclude>
- </excludes>
- <googleJavaFormat>
- <version>1.7</version>
- <style>GOOGLE</style>
- </googleJavaFormat>
- </java>
- </configuration>
- <executions>
- <execution>
- <goals>
- <goal>check</goal>
- </goals>
- <phase>compile</phase>
- </execution>
- </executions>
- </plugin>
Review Comment:
> In the role of a basic component, Pegasus java-client should better depend on less packages. I think check and format code style is not necessary to it.
I see, but I want to konw how format it to accord with the ci after we code completed?
> 2\. we can configure code format plugin in idea
Maybe you should make sure it can work well and add the solution in readme.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #989: ci(java-client): GitHub action uses checkstyle to replace plugins for java-client code style checking during CI
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #989:
URL: https://github.com/apache/incubator-pegasus/pull/989#discussion_r886351917
##########
java-client/scripts/format-all.sh:
##########
@@ -0,0 +1,49 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+
+SCRIPT_DIR=$(dirname "${BASH_SOURCE[0]}")
+PROJECT_DIR=$(dirname "${SCRIPT_DIR}")
+cd "${PROJECT_DIR}" || exit 1
+
+SRC_FILES=(src/main/java/org/apache/pegasus/client/*.java
Review Comment:
Does `**/*.java` work?
##########
java-client/scripts/format-all.sh:
##########
@@ -0,0 +1,49 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+
Review Comment:
Add comments to describe how to use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] Apache9 commented on pull request #989: ci(java-client): Use GitHub action to check and format Java code style instead of jar plugin
Posted by GitBox <gi...@apache.org>.
Apache9 commented on PR #989:
URL: https://github.com/apache/incubator-pegasus/pull/989#issuecomment-1152189246
We just need to remove the spotless pluigin dependency from the dependencies section, we only need it in the plugins section.
Using another way to enforce format is another topic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #989: ci(java-client): GitHub action uses checkstyle to replace plugins for java-client code style checking during CI
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #989:
URL: https://github.com/apache/incubator-pegasus/pull/989#discussion_r885234873
##########
.gitmodules:
##########
@@ -17,4 +17,4 @@
[submodule "rdsn"]
path = rdsn
- url = https://github.com/XiaoMi/rdsn.git
+ url = https://github.com/XiaoMi/rdsn.git
Review Comment:
Add an blank line to revert this file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 closed pull request #989: ci(java-client): GitHub action uses checkstyle to replace plugins for java-client code style checking during CI
Posted by GitBox <gi...@apache.org>.
acelyc111 closed pull request #989: ci(java-client): GitHub action uses checkstyle to replace plugins for java-client code style checking during CI
URL: https://github.com/apache/incubator-pegasus/pull/989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] WHBANG commented on a diff in pull request #989: ci(java-client): GitHub action uses checkstyle to replace plugins for java-client code style checking during CI
Posted by GitBox <gi...@apache.org>.
WHBANG commented on code in PR #989:
URL: https://github.com/apache/incubator-pegasus/pull/989#discussion_r885258069
##########
java-client/pom.xml:
##########
@@ -395,45 +390,6 @@
<version>0.13</version>
</plugin>
- <plugin>
- <groupId>com.diffplug.spotless</groupId>
- <artifactId>spotless-maven-plugin</artifactId>
- <version>2.12.2</version>
- <configuration>
- <formats>
- <format>
- <includes>
- <include>*.md</include>
- <include>.gitignore</include>
- </includes>
- <trimTrailingWhitespace/>
- <endWithNewline/>
- <indent>
- <tabs>true</tabs>
- <spacesPerTab>4</spacesPerTab>
- </indent>
- </format>
- </formats>
- <java>
- <excludes>
- <exclude>src/main/java/org/apache/infra/pegasus/apps/*</exclude>
- <exclude>src/main/java/org/apache/infra/pegasus/replication/*</exclude>
- </excludes>
- <googleJavaFormat>
- <version>1.7</version>
- <style>GOOGLE</style>
- </googleJavaFormat>
- </java>
- </configuration>
- <executions>
- <execution>
- <goals>
- <goal>check</goal>
- </goals>
- <phase>compile</phase>
- </execution>
- </executions>
- </plugin>
Review Comment:
1. code style check these don't feel good to write in our logic code
2. we can configure code format plugin in ieda
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] WHBANG commented on a diff in pull request #989: ci(java-client): GitHub action uses checkstyle to replace plugins for java-client code style checking during CI
Posted by GitBox <gi...@apache.org>.
WHBANG commented on code in PR #989:
URL: https://github.com/apache/incubator-pegasus/pull/989#discussion_r885291100
##########
java-client/pom.xml:
##########
@@ -395,45 +390,6 @@
<version>0.13</version>
</plugin>
- <plugin>
- <groupId>com.diffplug.spotless</groupId>
- <artifactId>spotless-maven-plugin</artifactId>
- <version>2.12.2</version>
- <configuration>
- <formats>
- <format>
- <includes>
- <include>*.md</include>
- <include>.gitignore</include>
- </includes>
- <trimTrailingWhitespace/>
- <endWithNewline/>
- <indent>
- <tabs>true</tabs>
- <spacesPerTab>4</spacesPerTab>
- </indent>
- </format>
- </formats>
- <java>
- <excludes>
- <exclude>src/main/java/org/apache/infra/pegasus/apps/*</exclude>
- <exclude>src/main/java/org/apache/infra/pegasus/replication/*</exclude>
- </excludes>
- <googleJavaFormat>
- <version>1.7</version>
- <style>GOOGLE</style>
- </googleJavaFormat>
- </java>
- </configuration>
- <executions>
- <execution>
- <goals>
- <goal>check</goal>
- </goals>
- <phase>compile</phase>
- </execution>
- </executions>
- </plugin>
Review Comment:
ci will only check the style of the newly submitted code, not check the unmodified code；
and use checkstyle v0.6.1 to check it later，when it can work well and I will write in redme to remind everyone to use checkstyle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org