You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Shahaf <d....@daniel.shahaf.name> on 2010/09/10 00:12:41 UTC

atomic-revprop: help tracking down ra_serf failures

[ I'm only talking about the ra_serf tests in this email ]

When I build the atomic-revprop branch against serf r1408, I see that:

* diff_tests 24 29 (and many others [1]) fail with HEAD of the branch.
    (IIRC these two failures persist if I switch to serf ^/branches/0.4.x@HEAD.)
* diff_tests 24 29 fail with r983269 reverted. (test output attached)
* diff_tests pass with r983269 and r983225 reverted. [2]
* diff_tests 24 29 fail with a working copy @r983225.

Complication:

* All tests passed at the time I committed r983225, using unknown version
  of serf (possibly trunk-as-of-then).  I'm sure of this because that
  revision touches nothing except libsvn_ra_serf, and because I believe
  I did run 'make check' before committing it.

Question:

* It seems suspicious to me that a working copy at r983225 passed tests
  when that revision was youngest, but doesn't pass tests now.  Does
  anyone see from this what might be causing the failures?

Thanks,

Daniel
(if no one sees why, I'll revert and rewrite r983225 and r983269; but
I hope someone here could save me some work...)

[1] List here: http://svn.apache.org/repos/asf/subversion/branches/atomic-revprop/FAILING-TESTS
    Outputs here: http://ci.apache.org/builders/svn-slik-w2k3-x64-ra/builds/761/steps/Test%20fsfs%2Bserf/logs/faillog

[2] http://svn.apache.org/viewvc?view=revision&revision=983225
    http://svn.apache.org/viewvc?view=revision&revision=983269

Re: atomic-revprop: help tracking down ra_serf failures

Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Lieven Govaerts wrote on Fri, Sep 10, 2010 at 07:46:55 +0200:
> On Fri, Sep 10, 2010 at 2:12 AM, Daniel Shahaf <d....@daniel.shahaf.name> wrote:
> > [ I'm only talking about the ra_serf tests in this email ]
> >
> > When I build the atomic-revprop branch against serf r1408, I see that:
> >
> > * diff_tests 24 29 (and many others [1]) fail with HEAD of the branch.
> >    (IIRC these two failures persist if I switch to serf ^/branches/0.4.x@HEAD.)
> > * diff_tests 24 29 fail with r983269 reverted. (test output attached)
> 
> In this log file, the only difference I see is that the output of
> 'iota' and 'A' are in reverse order in expected versus actual output.
> 

How do you see "in a reverse order"?  This is what I see:

[[[
DIFF STDOUT (unordered):
--- EXPECTED STDOUT
+++ ACTUAL STDOUT
@@ -1,17 +1,8 @@
-Index: A
-===================================================================
---- A  (revision 2)
-+++ A  (revision 1)
-
-Property changes on: A
-___________________________________________________________________
-Deleted: dirprop
-## -1 +0,0 ##
--r2value
 Index: iota
 ===================================================================
 --- iota       (revision 2)
 +++ iota       (revision 1)
+
 Property changes on: iota
 ___________________________________________________________________
 Deleted: fileprop
]]]

which means that the entire diff for "A" has disappeared.


> Isn't this just a question of ra_serf not guaranteeing depth-first output?
> 

No.  The above paste indicates that the expected output is already
marked "unordered" and that the output for A's dirprop is missing.

> Lieven
> [..]



Re: atomic-revprop: help tracking down ra_serf failures

Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Lieven Govaerts wrote on Fri, Sep 10, 2010 at 07:46:55 +0200:
> On Fri, Sep 10, 2010 at 2:12 AM, Daniel Shahaf <d....@daniel.shahaf.name> wrote:
> > [ I'm only talking about the ra_serf tests in this email ]
> >
> > When I build the atomic-revprop branch against serf r1408, I see that:
> >
> > * diff_tests 24 29 (and many others [1]) fail with HEAD of the branch.
> >    (IIRC these two failures persist if I switch to serf ^/branches/0.4.x@HEAD.)
> > * diff_tests 24 29 fail with r983269 reverted. (test output attached)
> 
> In this log file, the only difference I see is that the output of
> 'iota' and 'A' are in reverse order in expected versus actual output.
> 

How do you see "in a reverse order"?  This is what I see:

[[[
DIFF STDOUT (unordered):
--- EXPECTED STDOUT
+++ ACTUAL STDOUT
@@ -1,17 +1,8 @@
-Index: A
-===================================================================
---- A  (revision 2)
-+++ A  (revision 1)
-
-Property changes on: A
-___________________________________________________________________
-Deleted: dirprop
-## -1 +0,0 ##
--r2value
 Index: iota
 ===================================================================
 --- iota       (revision 2)
 +++ iota       (revision 1)
+
 Property changes on: iota
 ___________________________________________________________________
 Deleted: fileprop
]]]

which means that the entire diff for "A" has disappeared.


> Isn't this just a question of ra_serf not guaranteeing depth-first output?
> 

No.  The above paste indicates that the expected output is already
marked "unordered" and that the output for A's dirprop is missing.

> Lieven
> [..]


Re: atomic-revprop: help tracking down ra_serf failures

Posted by Lieven Govaerts <sv...@mobsol.be>.
On Fri, Sep 10, 2010 at 2:12 AM, Daniel Shahaf <d....@daniel.shahaf.name> wrote:
> [ I'm only talking about the ra_serf tests in this email ]
>
> When I build the atomic-revprop branch against serf r1408, I see that:
>
> * diff_tests 24 29 (and many others [1]) fail with HEAD of the branch.
>    (IIRC these two failures persist if I switch to serf ^/branches/0.4.x@HEAD.)
> * diff_tests 24 29 fail with r983269 reverted. (test output attached)

In this log file, the only difference I see is that the output of
'iota' and 'A' are in reverse order in expected versus actual output.

Isn't this just a question of ra_serf not guaranteeing depth-first output?

Lieven
[..]