[GitHub] [helix] dasahcc commented on a change in pull request #1520: Implement job context garbage collection

[GitBox <gi...@apache.org>]

dasahcc commented on a change in pull request #1520:
URL: https://github.com/apache/helix/pull/1520#discussion_r520805630



##########
File path: helix-core/src/main/java/org/apache/helix/controller/stages/TaskGarbageCollectionStage.java
##########
@@ -93,12 +97,18 @@ public void process(ClusterEvent event) throws Exception {
           .equals(TaskUtil.WORKFLOW_CONTEXT_KW)) {
         // Find workflows that need to be purged
         workflowsToBePurged.add(entry.getKey());
+      } else if (jobConfig == null && entry.getValue() != null && entry.getValue().getId()

Review comment:
       Could this job still exist in WF context? Do we need to scan WF context and clean them up?

##########
File path: helix-core/src/main/java/org/apache/helix/controller/stages/AttributeName.java
##########
@@ -48,5 +48,7 @@
   // This attribute should only be used in TaskGarbageCollectionStage, misuse could cause race conditions.
   TO_BE_PURGED_WORKFLOWS,
   // This attribute should only be used in TaskGarbageCollectionStage, misuse could cause race conditions.
+  TO_BE_PURGED_JOBS,
+  // This attribute should only be used in TaskGarbageCollectionStage, misuse could cause race conditions.
   TO_BE_PURGED_JOBS_MAP

Review comment:
       We may differentiate the names. Otherwise, it could be confusing.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org