You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Gabriela Gibson <ga...@gmail.com> on 2013/04/24 17:51:02 UTC

[PATCH] Fix for --internal-diff cmd coredump problem

[[[
Fix --internal-diff coredump due to NULL pointer in string routine.

* subversion/libsvn_subr/config.c
   (make_string_from_option): Add test to ensure that the string passed
     to strcmp is not a NULL value.
]]]

Re: [PATCH] Fix for --internal-diff cmd coredump problem

Posted by Julian Foad <ju...@btopenworld.com>.
Gabriela Gibson wrote:
> [[[
> Fix --internal-diff coredump due to NULL pointer in string routine.
> 
> * subversion/libsvn_subr/config.c
>   (make_string_from_option): Add test to ensure that the string passed
>     to strcmp is not a NULL value.
> ]]]

Thanks, but Ben already fixed that in r1467807.

- Julian


Re: [PATCH] Fix for --internal-diff cmd coredump problem

Posted by Philip Martin <ph...@wandisco.com>.
Gabriela Gibson <ga...@gmail.com> writes:

> Index: subversion/libsvn_subr/config.c
> ===================================================================
> --- subversion/libsvn_subr/config.c	(revision 1465268)
> +++ subversion/libsvn_subr/config.c	(working copy)
> @@ -464,7 +464,7 @@ make_string_from_option(const char **valuep, svn_c
>        /* before attempting to expand an option, check for the placeholder.
>         * If none is there, there is no point in calling expand_option_value.
>         */
> -      if (strchr(opt->value, '%'))
> +      if (opt->value && strchr(opt->value, '%'))
>          {
>            apr_pool_t *tmp_pool = (x_pool ? x_pool : svn_pool_create(cfg->x_pool));
>  

We patched that a couple of weeks ago: r1467807.

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download