You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2019/01/09 15:46:58 UTC
Review Request 69701: Improved debuggability of `verify-reviews.py`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69701/
-----------------------------------------------------------
Review request for mesos and Till Toenshoff.
Bugs: MESOS-9514
https://issues.apache.org/jira/browse/MESOS-9514
Repository: mesos
Description
-------
Improves error handling in `shell()` and decodes what is returned
by `urllib.request.urlopen` when doing API calls.
Diffs
-----
support/verify-reviews.py 04ed7fe9022f0758389bdbbbb76c21e48d0cd998
Diff: https://reviews.apache.org/r/69701/diff/1/
Testing
-------
Thanks,
Armand Grillet
Re: Review Request 69701: Improved debuggability of
`verify-reviews.py`.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69701/#review211778
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Jan. 9, 2019, 3:46 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69701/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2019, 3:46 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-9514
> https://issues.apache.org/jira/browse/MESOS-9514
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improves error handling in `shell()` and decodes what is returned
> by `urllib.request.urlopen` when doing API calls.
>
>
> Diffs
> -----
>
> support/verify-reviews.py 04ed7fe9022f0758389bdbbbb76c21e48d0cd998
>
>
> Diff: https://reviews.apache.org/r/69701/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 69701: Improved debuggability of
`verify-reviews.py`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69701/#review211781
-----------------------------------------------------------
FAIL: Failed to apply the current review.
Failed command: `python.exe .\support\apply-reviews.py -n -r 69701`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2724/mesos-review-69701
Relevant logs:
- [apply-review-69701.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2724/mesos-review-69701/logs/apply-review-69701.log):
```
error: patch failed: support/verify-reviews.py:93
error: support/verify-reviews.py: patch does not apply
```
- Mesos Reviewbot Windows
On Jan. 9, 2019, 7:46 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69701/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2019, 7:46 a.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-9514
> https://issues.apache.org/jira/browse/MESOS-9514
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improves error handling in `shell()` and decodes what is returned
> by `urllib.request.urlopen` when doing API calls.
>
>
> Diffs
> -----
>
> support/verify-reviews.py 04ed7fe9022f0758389bdbbbb76c21e48d0cd998
>
>
> Diff: https://reviews.apache.org/r/69701/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 69701: Improved debuggability of
`verify-reviews.py`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69701/#review213104
-----------------------------------------------------------
Bad review!
Reviews applied: [69701, 69698]
Error:
2019-02-23 00:46:08 URL:https://reviews.apache.org/r/69698/diff/raw/ [787/787] -> "69698.patch" [1]
error: patch failed: support/verify-reviews.py:125
error: support/verify-reviews.py: patch does not apply
- Mesos Reviewbot
On Jan. 9, 2019, 7:46 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69701/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2019, 7:46 a.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-9514
> https://issues.apache.org/jira/browse/MESOS-9514
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improves error handling in `shell()` and decodes what is returned
> by `urllib.request.urlopen` when doing API calls.
>
>
> Diffs
> -----
>
> support/verify-reviews.py 04ed7fe9022f0758389bdbbbb76c21e48d0cd998
>
>
> Diff: https://reviews.apache.org/r/69701/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Armand Grillet
>
>