You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@wicket.apache.org by "Pedro Santos (JIRA)" <ji...@apache.org> on 2011/09/14 17:42:08 UTC

[jira] [Commented] (WICKET-4046) Touch pages only when they are returned from the data stores

    [ https://issues.apache.org/jira/browse/WICKET-4046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104579#comment-13104579 ] 

Pedro Santos commented on WICKET-4046:
--------------------------------------

Sure, I see the bug now. I think the bug can be solved just in PageProvider, by caching its restored page by id. Let me also propose a patch with a this bug fix plus test case.

> Touch pages only when they are returned from the data stores
> ------------------------------------------------------------
>
>                 Key: WICKET-4046
>                 URL: https://issues.apache.org/jira/browse/WICKET-4046
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5.0, 1.5.1
>            Reporter: Emond Papegaaij
>            Assignee: Martin Grigorov
>             Fix For: 1.5.1
>
>         Attachments: pageprovider-notouch.diff
>
>
> The patch for WICKET-4021 can cause an unused instance of a page to be touched. This page is then stored by the page store, rather than the page used in the request. The attached patch cleans up PageProvider, by removing the touch call and makes the RequestAdapter search for a touched page first and only then load it from the page store.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira