You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Arvind Prabhakar <ar...@apache.org> on 2011/12/15 23:29:30 UTC
Review Request: Support the specification of location of derby.log via
configuration properties for JDBC channel.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3217/
-----------------------------------------------------------
Review request for Flume and Eric Sammer.
Summary
-------
Introduced a mechanism by which JDBC channel implementation will be able to set system properties that may be needed to configure/govern any embedded database instance that it may use. Used this mechanism to set the location of derby.log file for test runs.
This addresses bug FLUME-869.
https://issues.apache.org/jira/browse/FLUME-869
Diffs
-----
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 83ccba3
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 34027ea
flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestJdbcChannelProvider.java 862be39
flume-ng-core/src/main/java/org/apache/flume/Context.java 8cac89a
Diff: https://reviews.apache.org/r/3217/diff
Testing
-------
Ran all unit tests and verified that the derby.log file is being created in the target test directory as expected.
Thanks,
Arvind
Re: Review Request: Support the specification of location of derby.log via
configuration properties for JDBC channel.
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3217/#review3933
-----------------------------------------------------------
Ship it!
lgtm
- Prasad
On 2011-12-15 22:29:30, Arvind Prabhakar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3217/
> -----------------------------------------------------------
>
> (Updated 2011-12-15 22:29:30)
>
>
> Review request for Flume and Eric Sammer.
>
>
> Summary
> -------
>
> Introduced a mechanism by which JDBC channel implementation will be able to set system properties that may be needed to configure/govern any embedded database instance that it may use. Used this mechanism to set the location of derby.log file for test runs.
>
>
> This addresses bug FLUME-869.
> https://issues.apache.org/jira/browse/FLUME-869
>
>
> Diffs
> -----
>
> flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 83ccba3
> flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 34027ea
> flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestJdbcChannelProvider.java 862be39
> flume-ng-core/src/main/java/org/apache/flume/Context.java 8cac89a
>
> Diff: https://reviews.apache.org/r/3217/diff
>
>
> Testing
> -------
>
> Ran all unit tests and verified that the derby.log file is being created in the target test directory as expected.
>
>
> Thanks,
>
> Arvind
>
>