You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by mwkang <gi...@git.apache.org> on 2016/08/05 15:51:55 UTC
[GitHub] zeppelin pull request #1290: [ZEPPELIN-708]shift positions automatica...
GitHub user mwkang opened a pull request:
https://github.com/apache/zeppelin/pull/1290
[ZEPPELIN-708]shift<enter> positions automatically to the next cell
### What is this PR for?
Add and modify shortcut function
* Shift + Enter: Run paragraph, move focus to next
* Ctrl + Enter: Run paragraph, focus stays
### What type of PR is it?
Improvement
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-708
### How should this be tested?
* unit test
* online test
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mwkang/zeppelin ZEPPELIN-708
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1290.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1290
----
commit 1de67ec67ccc3d7ceca814ffcbce951aee4e2dd2
Author: Minwoo Kang <mi...@outlook.com>
Date: 2016-08-05T14:44:11Z
Add if shift + <enter>, positions automatically to the next cell. if Ctrl + <enter>, keep focus.
commit 4a58c67509302a140beaa141e4602717bcd6d92d
Author: Minwoo Kang <mi...@outlook.com>
Date: 2016-08-05T15:30:42Z
Add test cases
commit 73de2658f6919f5b2de5c06c8981ef9eed3cb2eb
Author: Minwoo Kang <mi...@outlook.com>
Date: 2016-08-05T15:47:12Z
Update tooltip and shortcut
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1290
I handle that unnecessary persisted in note.json.
I find some problem.
While new paragraph is added in runParagraph, focus is not end of line.
It ignore space character.
But While just add paragraph, it does not ignore space character.
I think it is not relate in unnecessary persisted in note.json.
So.. I want to resolve it in another issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1290
I am not sure. But I think it is persist error.
```
Failed tests:
ParallelSchedulerTest.testRun:63 expected:<FINISHED> but was:<RUNNING>
```
Anyway.. @Leemoonsoo I change code that it does not use `paragraph.config`. Can you review this PR? Is it okay?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1290: [WIP][ZEPPELIN-708]shift positions automaticall...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1290
CI Fail msg is `[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:0.0.25:npm (npm install) on project zeppelin-web: Failed to run task: 'npm install --color=false' failed. (error code 1) -> [Help 1]`
It is not relevant this PR.
Re-trigger CI.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1290: [ZEPPELIN-708]shift positions automatica...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang closed the pull request at:
https://github.com/apache/zeppelin/pull/1290
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1290
@mwkang Just tested quickly, I will have to run more test to check the behavior in general.
There is some refactoring needed, I left some comments.
Otherwise, a more global question, do we want to change the current default behavior of run?
I would understand about adding another CTRL + ENTER shortcut to do something else.
But what we are doing here is a breaking change to how Zeppelin use to behave.
And there is also a lot of other way to run a paragraph, where we will need to decide how they react to that change too:
* Click on paragraph run button
* Click on run all paragraph button
* CTRL + enter shortcut
* SHIFT + enter shortcut
* $on('runParagraph')
* Angular display system runParagraph
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1290: [WIP][ZEPPELIN-708]shift positions autom...
Posted by mwkang <gi...@git.apache.org>.
GitHub user mwkang reopened a pull request:
https://github.com/apache/zeppelin/pull/1290
[WIP][ZEPPELIN-708]shift<enter> positions automatically to the next cell
### What is this PR for?
* Add and modify shortcut function
* Shift + Enter: Run paragraph, move focus to next
* Ctrl + Enter: Run paragraph, focus stays
* Moves the cursor to the end of the paragraph, When new paragraph is added
### What type of PR is it?
Improvement
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-708
### How should this be tested?
* unit test
* online test
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mwkang/zeppelin ZEPPELIN-708
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1290.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1290
----
commit 490beb0018d22b4783814bf5f84abc24097fccd6
Author: Minwoo Kang <mi...@outlook.com>
Date: 2016-08-05T14:44:11Z
Add if shift + <enter>, positions automatically to the next cell. if Ctrl + <enter>, keep focus.
Moves the cursor to the end of the paragraph
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1290
@mwkang Can you rebase please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1290
re-trigger CI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1290
@corneadoug
Thanks for you review. I checked them.
Before I fix it, I have several questions.
Do you mean do not change CTRL + ENTER function?
And Is this PR not useful for Zeppelin user?
Could you tell me what is my next step?
I'm not sure stop progress or continue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...
Posted by resec <gi...@git.apache.org>.
Github user resec commented on the issue:
https://github.com/apache/zeppelin/pull/1290
@mwkang I am excited to see this enhancement implemented, great thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1290: [ZEPPELIN-708]shift positions automatica...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang closed the pull request at:
https://github.com/apache/zeppelin/pull/1290
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1290
I remove `angular.element('#' + focusedParagraph + '_paragraphColumn_main').scope().goToLineEnd()`, When paragraph runs.
Because each ace editor keeps cursor position.
So.. user enter `shift+enter`, cursor move next paragraph and cursor position is with locates in latest position.
I add screen shot. It is helpful to understand what I said.
@Leemoonsoo Could you mind if I request to review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1290
@resec That is more make sense. I will change when New cell added, Cursor position is next line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1290
I am not sure it is related with this PR.
When I run it, it passed.
```
Failed tests:
ParallelSchedulerTest.testRun:63 expected:<FINISHED> but was:<RUNNING>
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1290
I am not sure what is my next step. And this PR was created very long time ago. So enviroment changed before. I think other contributor can resolve better than me. So I closed this PR.
Thanks for your patient.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1290
Thanks @mwkang for the contribution. Tested and it works well.
However, i'm not sure about passing informations like "isKeyEvent", "moveFocusToNextParagraph", etc, through `paragraph.config`.
`paragraph.config` map will be persisted and restored into note.json, and informations like "isKeyEvent", "moveFocusToNextParagraph" does not necessary to be persisted and restored.
Can we avoid passing those information using `paragraph.config`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...
Posted by resec <gi...@git.apache.org>.
Github user resec commented on the issue:
https://github.com/apache/zeppelin/pull/1290
@mwkang Just a minor suggestion, when presses <Shift + Enter> and focus moves to a new cell, is it better that the focused line is next to the [%xxx]? so users can start typing new code right away without a <Enter>. Personally I keep the same [%xxxx] within a notebook far more than changing it in most of the cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1290
@mwkang Thanks for the improvement! Tested locally and it works well as expected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1290
Could you mind if I am going to resolve that consider running paragraph is successful on new issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1290: [ZEPPELIN-708]shift positions automatica...
Posted by mwkang <gi...@git.apache.org>.
GitHub user mwkang reopened a pull request:
https://github.com/apache/zeppelin/pull/1290
[ZEPPELIN-708]shift<enter> positions automatically to the next cell
### What is this PR for?
* Add and modify shortcut function
* Shift + Enter: Run paragraph, move focus to next
* Ctrl + Enter: Run paragraph, focus stays
* Moves the cursor to the end of the paragraph, When new paragraph is added
### What type of PR is it?
Improvement
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-708
### How should this be tested?
* unit test
* online test
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mwkang/zeppelin ZEPPELIN-708
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1290.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1290
----
commit 490beb0018d22b4783814bf5f84abc24097fccd6
Author: Minwoo Kang <mi...@outlook.com>
Date: 2016-08-05T14:44:11Z
Add if shift + <enter>, positions automatically to the next cell. if Ctrl + <enter>, keep focus.
Moves the cursor to the end of the paragraph
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1290
@Leemoonsoo Yes, I agree with you.
I will change that. Thanks for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1290: [ZEPPELIN-708]shift positions automatica...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang closed the pull request at:
https://github.com/apache/zeppelin/pull/1290
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1290: [ZEPPELIN-708]shift positions automatica...
Posted by mwkang <gi...@git.apache.org>.
GitHub user mwkang reopened a pull request:
https://github.com/apache/zeppelin/pull/1290
[ZEPPELIN-708]shift<enter> positions automatically to the next cell
### What is this PR for?
Add and modify shortcut function
* Shift + Enter: Run paragraph, move focus to next
* Ctrl + Enter: Run paragraph, focus stays
### What type of PR is it?
Improvement
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-708
### How should this be tested?
* unit test
* online test
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mwkang/zeppelin ZEPPELIN-708
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1290.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1290
----
commit 1de67ec67ccc3d7ceca814ffcbce951aee4e2dd2
Author: Minwoo Kang <mi...@outlook.com>
Date: 2016-08-05T14:44:11Z
Add if shift + <enter>, positions automatically to the next cell. if Ctrl + <enter>, keep focus.
commit 4a58c67509302a140beaa141e4602717bcd6d92d
Author: Minwoo Kang <mi...@outlook.com>
Date: 2016-08-05T15:30:42Z
Add test cases
commit 73de2658f6919f5b2de5c06c8981ef9eed3cb2eb
Author: Minwoo Kang <mi...@outlook.com>
Date: 2016-08-05T15:47:12Z
Update tooltip and shortcut
commit 63e6a3a4d5cf96deb0fc245efb8a0aae14c6e601
Author: Minwoo Kang <mi...@outlook.com>
Date: 2016-08-08T13:30:04Z
Avoid passing information through paragraph.config
commit da224d353df999213c033bdd44ad569a136c0999
Author: Minwoo Kang <mi...@outlook.com>
Date: 2016-08-08T14:50:04Z
Fixed CI
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1290
There are 2 errors.
1. `ZeppelinSparkClusterTest.zRunTest:204 expected:<FINISHED> but was:<ERROR>` does not reproduce.
2. `AuthenticationIT.testGroupPermission:179->AbstractZeppelinIT.pollingWait:96 \uca29 Timeout` also does not reproduce.
I am not sure that those errors are related this PR.
@corneadoug I finished rebase onto master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1290: [WIP][ZEPPELIN-708]shift positions autom...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang closed the pull request at:
https://github.com/apache/zeppelin/pull/1290
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1290
@corneadoug Thanks for your comment. I rebased my branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1290
`[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:0.0.25:npm (npm install) on project zeppelin-web: Failed to run task: 'npm install --color=false' failed. (error code 1) -> [Help 1]` is again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1290
@mwkang If you rebase again, the Error 2. Should be fixed.
Error 1. should just be a random one
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---