[jira] [Created] (THRIFT-1840) Thrift Generated Code Causes Global Variable Leaks

["Russell Bradberry (JIRA)" <ji...@apache.org>]

Russell Bradberry created THRIFT-1840:
-----------------------------------------

             Summary: Thrift Generated Code Causes Global Variable Leaks
                 Key: THRIFT-1840
                 URL: https://issues.apache.org/jira/browse/THRIFT-1840
             Project: Thrift
          Issue Type: Bug
          Components: Node.js - Compiler
    Affects Versions: 0.9
            Reporter: Russell Bradberry


When compiling for NodeJS, the compiler creates globally scoped variables which is considered a bad practice as it can create unintended consequences. It also causes many testing frameworks to fail.

the output looks something like this:

{code}
User = module.exports.User = function(args) {
{code}

when it should be

{code}
var User = module.exports.User = function(args) {
{code}


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira