You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Brian Durand (JIRA)" <ji...@apache.org> on 2007/10/19 22:34:51 UTC
[jira] Created: (SOLR-387) Add hooks to RequestHandlers so they can
be more easily extended
Add hooks to RequestHandlers so they can be more easily extended
----------------------------------------------------------------
Key: SOLR-387
URL: https://issues.apache.org/jira/browse/SOLR-387
Project: Solr
Issue Type: Improvement
Components: search
Affects Versions: 1.2
Reporter: Brian Durand
Priority: Trivial
Fix For: 1.2
I have found a couple of instances where I need to hook code in to modify the queries sent to RequestHandler and DisMaxRequestHandler before they are executed. The structure of these classes under Solr 1.2 does not lend itself to this type of extension. I have a patch which adds an additional method:
public void addCustomBehavior (SolrQueryRequest req, SolrQueryResponse rsp, List<Query> queries, List<SortField> sortFields)
Subclasses of the request handlers can then implement this method to hook in their custom code.
This code fix would be made obsolete by SOLR-281 (Search Component Plugins)
https://issues.apache.org/jira/browse/SOLR-281
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-387) Add hooks to RequestHandlers so they can
be more easily extended
Posted by "Brian Durand (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Durand updated SOLR-387:
------------------------------
Attachment: SOLR-387-Extensible-RequestHandlers.patch
Adds a hook method that can be implemented in RequestHanlder subclasses to modify the search objects before the search is executed.
> Add hooks to RequestHandlers so they can be more easily extended
> ----------------------------------------------------------------
>
> Key: SOLR-387
> URL: https://issues.apache.org/jira/browse/SOLR-387
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.2
> Reporter: Brian Durand
> Priority: Trivial
> Fix For: 1.2
>
> Attachments: SOLR-387-Extensible-RequestHandlers.patch
>
>
> I have found a couple of instances where I need to hook code in to modify the queries sent to RequestHandler and DisMaxRequestHandler before they are executed. The structure of these classes under Solr 1.2 does not lend itself to this type of extension. I have a patch which adds an additional method:
> public void addCustomBehavior (SolrQueryRequest req, SolrQueryResponse rsp, List<Query> queries, List<SortField> sortFields)
> Subclasses of the request handlers can then implement this method to hook in their custom code.
> This code fix would be made obsolete by SOLR-281 (Search Component Plugins)
> https://issues.apache.org/jira/browse/SOLR-281
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-387) Add hooks to RequestHandlers so they
can be more easily extended
Posted by "Brian Durand (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573782#action_12573782 ]
Brian Durand commented on SOLR-387:
-----------------------------------
That's fine.
> Add hooks to RequestHandlers so they can be more easily extended
> ----------------------------------------------------------------
>
> Key: SOLR-387
> URL: https://issues.apache.org/jira/browse/SOLR-387
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.2
> Reporter: Brian Durand
> Priority: Trivial
> Attachments: SOLR-387-Extensible-RequestHandlers.patch
>
>
> I have found a couple of instances where I need to hook code in to modify the queries sent to RequestHandler and DisMaxRequestHandler before they are executed. The structure of these classes under Solr 1.2 does not lend itself to this type of extension. I have a patch which adds an additional method:
> public void addCustomBehavior (SolrQueryRequest req, SolrQueryResponse rsp, List<Query> queries, List<SortField> sortFields)
> Subclasses of the request handlers can then implement this method to hook in their custom code.
> This code fix would be made obsolete by SOLR-281 (Search Component Plugins)
> https://issues.apache.org/jira/browse/SOLR-281
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-387) Add hooks to RequestHandlers so they
can be more easily extended
Posted by "Otis Gospodnetic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573596#action_12573596 ]
Otis Gospodnetic commented on SOLR-387:
---------------------------------------
Shall we close this one as "Won't fix" then, Brian?
> Add hooks to RequestHandlers so they can be more easily extended
> ----------------------------------------------------------------
>
> Key: SOLR-387
> URL: https://issues.apache.org/jira/browse/SOLR-387
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.2
> Reporter: Brian Durand
> Priority: Trivial
> Attachments: SOLR-387-Extensible-RequestHandlers.patch
>
>
> I have found a couple of instances where I need to hook code in to modify the queries sent to RequestHandler and DisMaxRequestHandler before they are executed. The structure of these classes under Solr 1.2 does not lend itself to this type of extension. I have a patch which adds an additional method:
> public void addCustomBehavior (SolrQueryRequest req, SolrQueryResponse rsp, List<Query> queries, List<SortField> sortFields)
> Subclasses of the request handlers can then implement this method to hook in their custom code.
> This code fix would be made obsolete by SOLR-281 (Search Component Plugins)
> https://issues.apache.org/jira/browse/SOLR-281
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-387) Add hooks to RequestHandlers so they
can be more easily extended
Posted by "Otis Gospodnetic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Otis Gospodnetic resolved SOLR-387.
-----------------------------------
Resolution: Won't Fix
> Add hooks to RequestHandlers so they can be more easily extended
> ----------------------------------------------------------------
>
> Key: SOLR-387
> URL: https://issues.apache.org/jira/browse/SOLR-387
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.2
> Reporter: Brian Durand
> Priority: Trivial
> Attachments: SOLR-387-Extensible-RequestHandlers.patch
>
>
> I have found a couple of instances where I need to hook code in to modify the queries sent to RequestHandler and DisMaxRequestHandler before they are executed. The structure of these classes under Solr 1.2 does not lend itself to this type of extension. I have a patch which adds an additional method:
> public void addCustomBehavior (SolrQueryRequest req, SolrQueryResponse rsp, List<Query> queries, List<SortField> sortFields)
> Subclasses of the request handlers can then implement this method to hook in their custom code.
> This code fix would be made obsolete by SOLR-281 (Search Component Plugins)
> https://issues.apache.org/jira/browse/SOLR-281
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-387) Add hooks to RequestHandlers so they can
be more easily extended
Posted by "Mike Klaas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Klaas updated SOLR-387:
----------------------------
Fix Version/s: (was: 1.2)
It probably isn't a good idea to introduce functionality that we know will soon be obsolete.
> Add hooks to RequestHandlers so they can be more easily extended
> ----------------------------------------------------------------
>
> Key: SOLR-387
> URL: https://issues.apache.org/jira/browse/SOLR-387
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.2
> Reporter: Brian Durand
> Priority: Trivial
> Attachments: SOLR-387-Extensible-RequestHandlers.patch
>
>
> I have found a couple of instances where I need to hook code in to modify the queries sent to RequestHandler and DisMaxRequestHandler before they are executed. The structure of these classes under Solr 1.2 does not lend itself to this type of extension. I have a patch which adds an additional method:
> public void addCustomBehavior (SolrQueryRequest req, SolrQueryResponse rsp, List<Query> queries, List<SortField> sortFields)
> Subclasses of the request handlers can then implement this method to hook in their custom code.
> This code fix would be made obsolete by SOLR-281 (Search Component Plugins)
> https://issues.apache.org/jira/browse/SOLR-281
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.