[jira] [Reopened] (LUCENE-5463) Make RamUsageEstimator.(human)sizeOf(Object) a forbidden API

["Uwe Schindler (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-5463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler reopened LUCENE-5463:
-----------------------------------


There is a problem with this commit: You renamed "-check-forbidden-base" to "-check-forbidden-all", but missed to also rename the "overwrite" target in solr's common-build. The one there should also be renamed, otherwise its never executed!

By this commit we lost the common-io checks in Solr.

Also can we add a more verbose "defaultMessage" to rue.txt. This is too short and is not a real "error-like message". Something like: "This method is slow at runtime."

> Make RamUsageEstimator.(human)sizeOf(Object) a forbidden API
> ------------------------------------------------------------
>
>                 Key: LUCENE-5463
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5463
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>             Fix For: 4.8
>
>         Attachments: LUCENE-5463.patch, LUCENE-5463.patch
>
>
> We have had a few issues with {{RamUsageEstimator}} recently so I think we should consider making the {{sizeOf(Object)}} and {{humanSizeOf(Object)}} methods forbidden under src/java (however still allowed for tests as it is handy to check the size computations which are done "manually"). However, {{sizeOf(byte[])}}, {{shallowSizeOf(Class)}}, etc. remain useful so I think we should keep them allowed.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org