You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/03/14 19:41:51 UTC
[GitHub] [flink] rkhachatryan opened a new pull request #15205: [FLINK-21649] Refactor CopyOnWrite state classes
rkhachatryan opened a new pull request #15205:
URL: https://github.com/apache/flink/pull/15205
## What is the purpose of the change
Trivial refactorings to `CopyOnWriteStateMap` and
related classes to allow extension and customization.
## Verifying this change
This change is a trivial rework without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): yes
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #15205: [FLINK-21649] Refactor CopyOnWrite state classes
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #15205:
URL: https://github.com/apache/flink/pull/15205#discussion_r597606607
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/CopyOnWriteStateTableSnapshot.java
##########
@@ -41,9 +41,18 @@
/** The offset to the contiguous key groups. */
private final int keyGroupOffset;
+ public int getKeyGroupOffset() {
Review comment:
Good point. My motivation was to decouple the changes/reviews to existing backend and addition of the new one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15205: [FLINK-21649] Refactor CopyOnWrite state classes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15205:
URL: https://github.com/apache/flink/pull/15205#issuecomment-798969965
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4948f168ab3d6a78b8ddff64ca2964de42d4114d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14634",
"triggerID" : "4948f168ab3d6a78b8ddff64ca2964de42d4114d",
"triggerType" : "PUSH"
}, {
"hash" : "8087d8f7d23911e311e212464badff6c89945e1d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8087d8f7d23911e311e212464badff6c89945e1d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4948f168ab3d6a78b8ddff64ca2964de42d4114d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14634)
* 8087d8f7d23911e311e212464badff6c89945e1d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15205: [FLINK-21649] Refactor CopyOnWrite state classes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15205:
URL: https://github.com/apache/flink/pull/15205#issuecomment-798969965
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4948f168ab3d6a78b8ddff64ca2964de42d4114d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14634",
"triggerID" : "4948f168ab3d6a78b8ddff64ca2964de42d4114d",
"triggerType" : "PUSH"
}, {
"hash" : "8087d8f7d23911e311e212464badff6c89945e1d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14644",
"triggerID" : "8087d8f7d23911e311e212464badff6c89945e1d",
"triggerType" : "PUSH"
}, {
"hash" : "d215aa0c3d2c3c6b0cf171fb6a534253d3271a1c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14762",
"triggerID" : "d215aa0c3d2c3c6b0cf171fb6a534253d3271a1c",
"triggerType" : "PUSH"
}, {
"hash" : "bc5f7f22117e642036dca82219a42fd0aa86e710",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14776",
"triggerID" : "bc5f7f22117e642036dca82219a42fd0aa86e710",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bc5f7f22117e642036dca82219a42fd0aa86e710 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14776)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan removed a comment on pull request #15205: [FLINK-21649] Refactor CopyOnWrite state classes
Posted by GitBox <gi...@apache.org>.
rkhachatryan removed a comment on pull request #15205:
URL: https://github.com/apache/flink/pull/15205#issuecomment-1084764698
Obsoleted by #19305.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15205: [FLINK-21649] Refactor CopyOnWrite state classes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15205:
URL: https://github.com/apache/flink/pull/15205#issuecomment-798969965
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4948f168ab3d6a78b8ddff64ca2964de42d4114d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14634",
"triggerID" : "4948f168ab3d6a78b8ddff64ca2964de42d4114d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4948f168ab3d6a78b8ddff64ca2964de42d4114d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14634)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15205: [FLINK-21649] Refactor CopyOnWrite state classes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15205:
URL: https://github.com/apache/flink/pull/15205#issuecomment-798969965
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4948f168ab3d6a78b8ddff64ca2964de42d4114d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14634",
"triggerID" : "4948f168ab3d6a78b8ddff64ca2964de42d4114d",
"triggerType" : "PUSH"
}, {
"hash" : "8087d8f7d23911e311e212464badff6c89945e1d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14644",
"triggerID" : "8087d8f7d23911e311e212464badff6c89945e1d",
"triggerType" : "PUSH"
}, {
"hash" : "d215aa0c3d2c3c6b0cf171fb6a534253d3271a1c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14762",
"triggerID" : "d215aa0c3d2c3c6b0cf171fb6a534253d3271a1c",
"triggerType" : "PUSH"
}, {
"hash" : "bc5f7f22117e642036dca82219a42fd0aa86e710",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bc5f7f22117e642036dca82219a42fd0aa86e710",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8087d8f7d23911e311e212464badff6c89945e1d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14644)
* d215aa0c3d2c3c6b0cf171fb6a534253d3271a1c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14762)
* bc5f7f22117e642036dca82219a42fd0aa86e710 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #15205: [FLINK-21649] Refactor CopyOnWrite state classes
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15205:
URL: https://github.com/apache/flink/pull/15205#issuecomment-798969965
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4948f168ab3d6a78b8ddff64ca2964de42d4114d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4948f168ab3d6a78b8ddff64ca2964de42d4114d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4948f168ab3d6a78b8ddff64ca2964de42d4114d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15205: [FLINK-21649] Refactor CopyOnWrite state classes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15205:
URL: https://github.com/apache/flink/pull/15205#issuecomment-798969965
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4948f168ab3d6a78b8ddff64ca2964de42d4114d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14634",
"triggerID" : "4948f168ab3d6a78b8ddff64ca2964de42d4114d",
"triggerType" : "PUSH"
}, {
"hash" : "8087d8f7d23911e311e212464badff6c89945e1d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14644",
"triggerID" : "8087d8f7d23911e311e212464badff6c89945e1d",
"triggerType" : "PUSH"
}, {
"hash" : "d215aa0c3d2c3c6b0cf171fb6a534253d3271a1c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d215aa0c3d2c3c6b0cf171fb6a534253d3271a1c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8087d8f7d23911e311e212464badff6c89945e1d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14644)
* d215aa0c3d2c3c6b0cf171fb6a534253d3271a1c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] carp84 commented on a change in pull request #15205: [FLINK-21649] Refactor CopyOnWrite state classes
Posted by GitBox <gi...@apache.org>.
carp84 commented on a change in pull request #15205:
URL: https://github.com/apache/flink/pull/15205#discussion_r596552594
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/CopyOnWriteStateTableSnapshot.java
##########
@@ -41,9 +41,18 @@
/** The offset to the contiguous key groups. */
private final int keyGroupOffset;
+ public int getKeyGroupOffset() {
+ return keyGroupOffset;
+ }
+
/** Snapshots of state partitioned by key-group. */
@Nonnull private final List<CopyOnWriteStateMapSnapshot<K, N, S>> stateMapSnapshots;
+ @Nonnull
+ public List<CopyOnWriteStateMapSnapshot<K, N, S>> getStateMapSnapshots() {
Review comment:
Ditto
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/CopyOnWriteStateTableSnapshot.java
##########
@@ -41,9 +41,18 @@
/** The offset to the contiguous key groups. */
private final int keyGroupOffset;
+ public int getKeyGroupOffset() {
Review comment:
Is this some method we need to introduce in this PR? Or maybe pair with the changes including its invocation in later PR?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/CopyOnWriteStateMap.java
##########
@@ -285,6 +285,11 @@ public S get(K key, N namespace) {
}
e.stateVersion = stateMapVersion;
e.state = getStateSerializer().copy(e.state);
+ } else if (e.stateVersion < stateMapVersion) {
+ // the entry is not used by any active snapshot;
+ // if it WAS used then it should NOT be included into the next one if it takes
+ // versioning into account
+ e.stateVersion = stateMapVersion;
}
Review comment:
I believe it worth adding a test to cover this case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15205: [FLINK-21649] Refactor CopyOnWrite state classes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15205:
URL: https://github.com/apache/flink/pull/15205#issuecomment-798969965
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4948f168ab3d6a78b8ddff64ca2964de42d4114d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14634",
"triggerID" : "4948f168ab3d6a78b8ddff64ca2964de42d4114d",
"triggerType" : "PUSH"
}, {
"hash" : "8087d8f7d23911e311e212464badff6c89945e1d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14644",
"triggerID" : "8087d8f7d23911e311e212464badff6c89945e1d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4948f168ab3d6a78b8ddff64ca2964de42d4114d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14634)
* 8087d8f7d23911e311e212464badff6c89945e1d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14644)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15205: [FLINK-21649] Refactor CopyOnWrite state classes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15205:
URL: https://github.com/apache/flink/pull/15205#issuecomment-798969965
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4948f168ab3d6a78b8ddff64ca2964de42d4114d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14634",
"triggerID" : "4948f168ab3d6a78b8ddff64ca2964de42d4114d",
"triggerType" : "PUSH"
}, {
"hash" : "8087d8f7d23911e311e212464badff6c89945e1d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14644",
"triggerID" : "8087d8f7d23911e311e212464badff6c89945e1d",
"triggerType" : "PUSH"
}, {
"hash" : "d215aa0c3d2c3c6b0cf171fb6a534253d3271a1c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14762",
"triggerID" : "d215aa0c3d2c3c6b0cf171fb6a534253d3271a1c",
"triggerType" : "PUSH"
}, {
"hash" : "bc5f7f22117e642036dca82219a42fd0aa86e710",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14776",
"triggerID" : "bc5f7f22117e642036dca82219a42fd0aa86e710",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8087d8f7d23911e311e212464badff6c89945e1d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14644)
* d215aa0c3d2c3c6b0cf171fb6a534253d3271a1c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14762)
* bc5f7f22117e642036dca82219a42fd0aa86e710 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14776)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15205: [FLINK-21649] Refactor CopyOnWrite state classes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15205:
URL: https://github.com/apache/flink/pull/15205#issuecomment-798969965
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4948f168ab3d6a78b8ddff64ca2964de42d4114d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14634",
"triggerID" : "4948f168ab3d6a78b8ddff64ca2964de42d4114d",
"triggerType" : "PUSH"
}, {
"hash" : "8087d8f7d23911e311e212464badff6c89945e1d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14644",
"triggerID" : "8087d8f7d23911e311e212464badff6c89945e1d",
"triggerType" : "PUSH"
}, {
"hash" : "d215aa0c3d2c3c6b0cf171fb6a534253d3271a1c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14762",
"triggerID" : "d215aa0c3d2c3c6b0cf171fb6a534253d3271a1c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8087d8f7d23911e311e212464badff6c89945e1d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14644)
* d215aa0c3d2c3c6b0cf171fb6a534253d3271a1c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14762)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15205: [FLINK-21649] Refactor CopyOnWrite state classes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15205:
URL: https://github.com/apache/flink/pull/15205#issuecomment-798969965
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4948f168ab3d6a78b8ddff64ca2964de42d4114d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14634",
"triggerID" : "4948f168ab3d6a78b8ddff64ca2964de42d4114d",
"triggerType" : "PUSH"
}, {
"hash" : "8087d8f7d23911e311e212464badff6c89945e1d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14644",
"triggerID" : "8087d8f7d23911e311e212464badff6c89945e1d",
"triggerType" : "PUSH"
}, {
"hash" : "d215aa0c3d2c3c6b0cf171fb6a534253d3271a1c",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14762",
"triggerID" : "d215aa0c3d2c3c6b0cf171fb6a534253d3271a1c",
"triggerType" : "PUSH"
}, {
"hash" : "bc5f7f22117e642036dca82219a42fd0aa86e710",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14776",
"triggerID" : "bc5f7f22117e642036dca82219a42fd0aa86e710",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d215aa0c3d2c3c6b0cf171fb6a534253d3271a1c Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14762)
* bc5f7f22117e642036dca82219a42fd0aa86e710 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14776)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #15205: [FLINK-21649] Refactor CopyOnWrite state classes
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #15205:
URL: https://github.com/apache/flink/pull/15205#issuecomment-1084765157
Obsoleted by #19305.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan closed pull request #15205: [FLINK-21649] Refactor CopyOnWrite state classes
Posted by GitBox <gi...@apache.org>.
rkhachatryan closed pull request #15205:
URL: https://github.com/apache/flink/pull/15205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15205: [FLINK-21649] Refactor CopyOnWrite state classes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15205:
URL: https://github.com/apache/flink/pull/15205#issuecomment-798969965
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4948f168ab3d6a78b8ddff64ca2964de42d4114d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14634",
"triggerID" : "4948f168ab3d6a78b8ddff64ca2964de42d4114d",
"triggerType" : "PUSH"
}, {
"hash" : "8087d8f7d23911e311e212464badff6c89945e1d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14644",
"triggerID" : "8087d8f7d23911e311e212464badff6c89945e1d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8087d8f7d23911e311e212464badff6c89945e1d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14644)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15205: [FLINK-21649] Refactor CopyOnWrite state classes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15205:
URL: https://github.com/apache/flink/pull/15205#issuecomment-798969965
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4948f168ab3d6a78b8ddff64ca2964de42d4114d",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14634",
"triggerID" : "4948f168ab3d6a78b8ddff64ca2964de42d4114d",
"triggerType" : "PUSH"
}, {
"hash" : "8087d8f7d23911e311e212464badff6c89945e1d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14644",
"triggerID" : "8087d8f7d23911e311e212464badff6c89945e1d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4948f168ab3d6a78b8ddff64ca2964de42d4114d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14634)
* 8087d8f7d23911e311e212464badff6c89945e1d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14644)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #15205: [FLINK-21649] Refactor CopyOnWrite state classes
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15205:
URL: https://github.com/apache/flink/pull/15205#issuecomment-798967652
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 4948f168ab3d6a78b8ddff64ca2964de42d4114d (Sun Mar 14 19:45:06 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15205: [FLINK-21649] Refactor CopyOnWrite state classes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15205:
URL: https://github.com/apache/flink/pull/15205#issuecomment-798969965
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4948f168ab3d6a78b8ddff64ca2964de42d4114d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14634",
"triggerID" : "4948f168ab3d6a78b8ddff64ca2964de42d4114d",
"triggerType" : "PUSH"
}, {
"hash" : "8087d8f7d23911e311e212464badff6c89945e1d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14644",
"triggerID" : "8087d8f7d23911e311e212464badff6c89945e1d",
"triggerType" : "PUSH"
}, {
"hash" : "d215aa0c3d2c3c6b0cf171fb6a534253d3271a1c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14762",
"triggerID" : "d215aa0c3d2c3c6b0cf171fb6a534253d3271a1c",
"triggerType" : "PUSH"
}, {
"hash" : "bc5f7f22117e642036dca82219a42fd0aa86e710",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14776",
"triggerID" : "bc5f7f22117e642036dca82219a42fd0aa86e710",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bc5f7f22117e642036dca82219a42fd0aa86e710 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14776)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #15205: [FLINK-21649] Refactor CopyOnWrite state classes
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #15205:
URL: https://github.com/apache/flink/pull/15205#issuecomment-1084764698
Obsoleted by #19305.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org