You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@oozie.apache.org by Purshotam Shah <pu...@yahoo-inc.com> on 2013/09/13 20:53:24 UTC

Review Request 14129: Disabling job DAG display for workflow having action > 25

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14129/
-----------------------------------------------------------

Review request for oozie.

Summary (updated)
-----------------

Disabling job DAG display for workflow having action > 25

Repository: oozie

Description (updated)
-------

1.Disabling job DAG display for workflow having action > 25.
Job DAQ rendering happens at server side. It's a heavy operation and server goes OOM while generating DAG for workflow having more actions.

2. There are other UI fixes.
a.)Client calls to generates DAG two times, 1> while initializing panel. 2> When user clicks Job DAG tab.
Disabling the DAG generation while initializing panel. It will be called only when user clicks Job DAG panel.

Diffs (updated)
-----

http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1520065
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/util/GraphGenerator.java 1520065
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 1520065
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/graphWF_equal.xml PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/graphWF_huge_state.xml PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/oozie-console.js 1520065

Diff: https://reviews.apache.org/r/14129/diff/

Testing (updated)
-------

Added three test case.
1. If actions<25, should generate graph
2. If actions=25, should generate graph
3. If actions>25, should throw error message.

Thanks,

Purshotam Shah

Re: Review Request 14129: [OOZIE-1529]Disabling job DAG display for workflow having huge actions

Posted by Purshotam Shah <pu...@yahoo-inc.com>.


> On Sept. 13, 2013, 7:44 p.m., Rohini Palaniswamy wrote:
> > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/util/GraphGenerator.java, line 64
> > <https://reviews.apache.org/r/14129/diff/1/?file=352024#file352024line64>
> >
> >      Don't need to declare exception message as a string. Just use that in the exception constructor directly

Using it multiple places, for logging and throwing exception. So defining it helps, as I don't have to change it multiple places.


- Purshotam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14129/#review26092
-----------------------------------------------------------


On Sept. 13, 2013, 10:10 p.m., Purshotam Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14129/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2013, 10:10 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1529
>     https://issues.apache.org/jira/browse/OOZIE-1529
> 
> 
> Repository: oozie
> 
> 
> Description
> -------
> 
> 1.Disabling job DAG display for workflow having action > 25.
> Job DAQ rendering happens at server side. It's a heavy operation and server goes OOM while generating DAG for workflow having more actions.
> 
> 2. There are other UI fixes.
>   a.)Client calls to generates DAG two times, 1> while initializing panel. 2> When user clicks Job DAG tab.
>      Disabling the DAG generation while initializing panel. It will be called only when user clicks Job DAG panel. 
>   
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1520065 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/util/GraphGenerator.java 1520065 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 1520065 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/graphWF_26_state.xml PRE-CREATION 
>   http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/oozie-console.js 1520065 
> 
> Diff: https://reviews.apache.org/r/14129/diff/
> 
> 
> Testing
> -------
> 
> Added three test case.
> 1. If actions<25, should generate graph
> 2. If actions=25, should generate graph
> 3. If actions>25, should throw error message.
> 
> 
> Thanks,
> 
> Purshotam Shah
> 
>

Re: Review Request 14129: [OOZIE-1529]Disabling job DAG display for workflow having huge actions

Posted by Rohini Palaniswamy <ro...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14129/#review26092
-----------------------------------------------------------



http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java
<https://reviews.apache.org/r/14129/#comment50927>

    catch should be in a new line. Please use the formatting from
    
    https://cwiki.apache.org/confluence/pages/viewpageattachments.action?pageId=30737371



http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java
<https://reviews.apache.org/r/14129/#comment50928>

    if blocks should have { }



http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/util/GraphGenerator.java
<https://reviews.apache.org/r/14129/#comment50929>

    actionsLimit. space before and after =



http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/util/GraphGenerator.java
<https://reviews.apache.org/r/14129/#comment50930>

     Don't need to declare exception message as a string. Just use that in the exception constructor directly



http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java
<https://reviews.apache.org/r/14129/#comment50933>

    This test case is enough. Can remove the others. testWrite() will take care of those



http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java
<https://reviews.apache.org/r/14129/#comment50934>

    graphWF_<n>_actions.xml
    
    Simplify the graphWF file actions.



http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/oozie-console.js
<https://reviews.apache.org/r/14129/#comment50937>

    function alertOnDAGError()



http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/oozie-console.js
<https://reviews.apache.org/r/14129/#comment50935>

    space before and after



http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/oozie-console.js
<https://reviews.apache.org/r/14129/#comment50936>

    &token=Math.random is not required



http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/oozie-console.js
<https://reviews.apache.org/r/14129/#comment50938>

    Remove this line and fetchDAG method


- Rohini Palaniswamy


On Sept. 13, 2013, 6:57 p.m., Purshotam Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14129/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2013, 6:57 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1529
>     https://issues.apache.org/jira/browse/OOZIE-1529
> 
> 
> Repository: oozie
> 
> 
> Description
> -------
> 
> 1.Disabling job DAG display for workflow having action > 25.
> Job DAQ rendering happens at server side. It's a heavy operation and server goes OOM while generating DAG for workflow having more actions.
> 
> 2. There are other UI fixes.
>   a.)Client calls to generates DAG two times, 1> while initializing panel. 2> When user clicks Job DAG tab.
>      Disabling the DAG generation while initializing panel. It will be called only when user clicks Job DAG panel. 
>   
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1520065 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/util/GraphGenerator.java 1520065 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 1520065 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/graphWF_equal.xml PRE-CREATION 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/graphWF_huge_state.xml PRE-CREATION 
>   http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/oozie-console.js 1520065 
> 
> Diff: https://reviews.apache.org/r/14129/diff/
> 
> 
> Testing
> -------
> 
> Added three test case.
> 1. If actions<25, should generate graph
> 2. If actions=25, should generate graph
> 3. If actions>25, should throw error message.
> 
> 
> Thanks,
> 
> Purshotam Shah
> 
>

Re: Review Request 14129: [OOZIE-1529]Disabling job DAG display for workflow having huge actions

Posted by Purshotam Shah <pu...@yahoo-inc.com>.

(Updated Sept. 16, 2013, 9:39 p.m.)

Review request for oozie.

Changes
-------

Patch after code merge.

Bugs: OOZIE-1529
https://issues.apache.org/jira/browse/OOZIE-1529

Repository: oozie

Description
-------

Diffs (updated)
-----

http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1523758
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/util/GraphGenerator.java 1523758
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 1523758
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/graphWF_26_actions.xml PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/oozie-console.js 1523758

Diff: https://reviews.apache.org/r/14129/diff/

Testing
-------

Added three test case.
1. If actions<25, should generate graph
2. If actions=25, should generate graph
3. If actions>25, should throw error message.

Thanks,

Purshotam Shah

Re: Review Request 14129: [OOZIE-1529]Disabling job DAG display for workflow having huge actions

Posted by Rohini Palaniswamy <ro...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14129/#review26111
-----------------------------------------------------------

Ship it!


Ship It!

- Rohini Palaniswamy


On Sept. 13, 2013, 10:48 p.m., Purshotam Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14129/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2013, 10:48 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1529
>     https://issues.apache.org/jira/browse/OOZIE-1529
> 
> 
> Repository: oozie
> 
> 
> Description
> -------
> 
> 1.Disabling job DAG display for workflow having action > 25.
> Job DAQ rendering happens at server side. It's a heavy operation and server goes OOM while generating DAG for workflow having more actions.
> 
> 2. There are other UI fixes.
>   a.)Client calls to generates DAG two times, 1> while initializing panel. 2> When user clicks Job DAG tab.
>      Disabling the DAG generation while initializing panel. It will be called only when user clicks Job DAG panel. 
>   
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1520065 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/util/GraphGenerator.java 1520065 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 1520065 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/graphWF_26_actions.xml PRE-CREATION 
>   http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/oozie-console.js 1520065 
> 
> Diff: https://reviews.apache.org/r/14129/diff/
> 
> 
> Testing
> -------
> 
> Added three test case.
> 1. If actions<25, should generate graph
> 2. If actions=25, should generate graph
> 3. If actions>25, should throw error message.
> 
> 
> Thanks,
> 
> Purshotam Shah
> 
>

Re: Review Request 14129: [OOZIE-1529]Disabling job DAG display for workflow having huge actions

Posted by Purshotam Shah <pu...@yahoo-inc.com>.

(Updated Sept. 13, 2013, 10:48 p.m.)

Review request for oozie.

Bugs: OOZIE-1529
https://issues.apache.org/jira/browse/OOZIE-1529

Repository: oozie

Description
-------

Diffs (updated)
-----

http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1520065
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/util/GraphGenerator.java 1520065
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 1520065
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/graphWF_26_actions.xml PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/oozie-console.js 1520065

Diff: https://reviews.apache.org/r/14129/diff/

Testing
-------

Added three test case.
1. If actions<25, should generate graph
2. If actions=25, should generate graph
3. If actions>25, should throw error message.

Thanks,

Purshotam Shah

Re: Review Request 14129: [OOZIE-1529]Disabling job DAG display for workflow having huge actions

Posted by Rohini Palaniswamy <ro...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14129/#review26105
-----------------------------------------------------------



http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/util/GraphGenerator.java
<https://reviews.apache.org/r/14129/#comment50952>

    actionsLimit. state is unclear as it is not status.



http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/util/GraphGenerator.java
<https://reviews.apache.org/r/14129/#comment50955>

    Would still prefer removing this as logging the message is not recessary, when the exception will be logged.



http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/util/GraphGenerator.java
<https://reviews.apache.org/r/14129/#comment50954>

    The log statement is not required



http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/graphWF_26_state.xml
<https://reviews.apache.org/r/14129/#comment50950>

    Can you rename the file to graphWF_26_actions.xml?



http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/oozie-console.js
<https://reviews.apache.org/r/14129/#comment50956>

    than the display limit 25


- Rohini Palaniswamy


On Sept. 13, 2013, 10:10 p.m., Purshotam Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14129/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2013, 10:10 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1529
>     https://issues.apache.org/jira/browse/OOZIE-1529
> 
> 
> Repository: oozie
> 
> 
> Description
> -------
> 
> 1.Disabling job DAG display for workflow having action > 25.
> Job DAQ rendering happens at server side. It's a heavy operation and server goes OOM while generating DAG for workflow having more actions.
> 
> 2. There are other UI fixes.
>   a.)Client calls to generates DAG two times, 1> while initializing panel. 2> When user clicks Job DAG tab.
>      Disabling the DAG generation while initializing panel. It will be called only when user clicks Job DAG panel. 
>   
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1520065 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/util/GraphGenerator.java 1520065 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 1520065 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/graphWF_26_state.xml PRE-CREATION 
>   http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/oozie-console.js 1520065 
> 
> Diff: https://reviews.apache.org/r/14129/diff/
> 
> 
> Testing
> -------
> 
> Added three test case.
> 1. If actions<25, should generate graph
> 2. If actions=25, should generate graph
> 3. If actions>25, should throw error message.
> 
> 
> Thanks,
> 
> Purshotam Shah
> 
>

Re: Review Request 14129: [OOZIE-1529]Disabling job DAG display for workflow having huge actions

Posted by Purshotam Shah <pu...@yahoo-inc.com>.

(Updated Sept. 13, 2013, 10:10 p.m.)

Review request for oozie.

Bugs: OOZIE-1529
https://issues.apache.org/jira/browse/OOZIE-1529

Repository: oozie

Description
-------

Diffs (updated)
-----

http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1520065
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/util/GraphGenerator.java 1520065
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 1520065
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/graphWF_26_state.xml PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/oozie-console.js 1520065

Diff: https://reviews.apache.org/r/14129/diff/

Testing
-------

Added three test case.
1. If actions<25, should generate graph
2. If actions=25, should generate graph
3. If actions>25, should throw error message.

Thanks,

Purshotam Shah

Re: Review Request 14129: [OOZIE-1529]Disabling job DAG display for workflow having huge actions

Posted by Purshotam Shah <pu...@yahoo-inc.com>.

(Updated Sept. 13, 2013, 6:57 p.m.)

Review request for oozie.

Summary (updated)
-----------------

[OOZIE-1529]Disabling job DAG display for workflow having huge actions

Bugs: OOZIE-1529
https://issues.apache.org/jira/browse/OOZIE-1529

Repository: oozie

Description
-------

Diffs
-----

Diff: https://reviews.apache.org/r/14129/diff/

Testing
-------

Added three test case.
1. If actions<25, should generate graph
2. If actions=25, should generate graph
3. If actions>25, should throw error message.

Thanks,

Purshotam Shah