[GitHub] [geronimo-openapi] rmannibucau commented on a change in pull request #15: The AnnotationProcessor should consider '@APIResponses' annotation

[GitBox <gi...@apache.org>]

rmannibucau commented on a change in pull request #15: The AnnotationProcessor should consider '@APIResponses' annotation
URL: https://github.com/apache/geronimo-openapi/pull/15#discussion_r272885462
 
 

 ##########
 File path: geronimo-openapi-impl/src/main/java/org/apache/geronimo/microprofile/openapi/impl/processor/AnnotationProcessor.java
 ##########
 @@ -307,10 +308,17 @@ private Operation buildOperation(final OpenAPI api, final AnnotatedMethodElement
                      .filter(v -> !v.isEmpty())
                      .collect(toList()))
                 .ifPresent(operation::tags);
-
-        of(m.getAnnotationsByType(APIResponse.class)).filter(s -> s.length > 0).ifPresent(items -> {
+        
+        final Collection<APIResponse> apiResponses = Stream
 
 Review comment:
   hmm, here the getAnnotationsByType usage was supposed to catch it since it is repeatable, no? - https://docs.oracle.com/javase/8/docs/api/java/lang/reflect/Executable.html#getAnnotationsByType-java.lang.Class-.
   
   Also please add a test even if trivial, seems it is not caught by tck if previous point is not the issue you hit - bad API?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services