[GitHub] [lucene-solr] mayya-sharipova commented on pull request #1903: Fix bug in sort optimization

[GitBox <gi...@apache.org>]

mayya-sharipova commented on pull request #1903:
URL: https://github.com/apache/lucene-solr/pull/1903#issuecomment-696373592


   @jimczi  I could not reproduce an issue of duplicate documents in Lucene, and I am still not sure how it actually happens.
   
    Even as we were [incorrectly advancing](https://github.com/apache/lucene-solr/blob/master/lucene/core/src/java/org/apache/lucene/search/Weight.java#L216) only `scorerIterator`, as `filteredIterator`  is an intersection of `collectorIterator` and `scorerIterator`, a next document from `filteredIterator` must be a document > the current document of `scorerIterator`? No?
   
   There was also a question why we did not detect duplicate documents in the tests. First, they don't happen in the tests, and before I was not using `AssertingIndexSearcher`.  I've changed the tests on _doc sort to use `AssertingIndexSearcher`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org