[GitHub] [iotdb] JackieTien97 commented on a diff in pull request #5502: [IOTDB-2844] Implementation of SeriesAggregateScanOperator and AggregateOperator - Part I

[GitBox <gi...@apache.org>]

JackieTien97 commented on code in PR #5502:
URL: https://github.com/apache/iotdb/pull/5502#discussion_r852631142


##########
server/src/main/java/org/apache/iotdb/db/mpp/sql/planner/plan/node/source/SeriesAggregateScanNode.java:
##########
@@ -71,6 +73,9 @@ public class SeriesAggregateScanNode extends SourceNode implements IOutputPlanNo
   private final PartialPath seriesPath;
   private final List<AggregationType> aggregateFuncList;
 
+  // all the sensors in seriesPath's device of current query
+  private Set<String> allSensors;

Review Comment:
   It's seems that you forgot to serialize and derialize this field. After adding that, don't forget to add SeriesAggregateScanNodeSerdeTest in UT.



##########
server/src/main/java/org/apache/iotdb/db/mpp/sql/planner/plan/node/source/SeriesAggregateScanNode.java:
##########
@@ -71,6 +73,9 @@ public class SeriesAggregateScanNode extends SourceNode implements IOutputPlanNo
   private final PartialPath seriesPath;
   private final List<AggregationType> aggregateFuncList;
 
+  // all the sensors in seriesPath's device of current query
+  private Set<String> allSensors;

Review Comment:
   BTW, I find that groupByTimeParameter is not serialized and derialized, add it in this pr.



##########
tsfile/src/main/java/org/apache/iotdb/tsfile/read/common/block/column/TimeColumn.java:
##########
@@ -104,6 +104,11 @@ public Column getRegion(int positionOffset, int length) {
     return new TimeColumn(positionOffset + arrayOffset, length, values);
   }
 
+  // TODO 这里是 0 吗?
+  public long getStartTime() {
+    return values[0];

Review Comment:
   ```suggestion
       return values[arrayOffset];
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org