You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/17 10:54:39 UTC

[GitHub] [airflow] nominee1997 opened a new issue #22336: `airflow dags backfill` command doesn't propagate DagRun conf attribute if the DagRun already exists

nominee1997 opened a new issue #22336:
URL: https://github.com/apache/airflow/issues/22336


   ### Apache Airflow version
   
   2.1.4
   
   ### What happened
   
   `airflow dags backfill` command has an option to provide config for the DagRun's it will trigger (https://airflow.apache.org/docs/apache-airflow/stable/cli-and-env-variables-ref.html#Named%20Arguments_repeat10).
   
   This works correctly if there are no existing DagRun's for the execution dates in question. However, if they exist, then the existing config will not get overwritten. I think this is because in the backfill job code we check if there's an existing DagRun and use that if so. Thus we'll end up using the existing config! See https://github.com/apache/airflow/blob/81d633cc02813e44e1dfcd23dc29a06ddb0abb72/airflow/jobs/backfill_job.py#L291-L345
   
   Potential fix could be to add setting `run.conf = self.conf` before we verify and return the run?
   
   ### What you think should happen instead
   
   _No response_
   
   ### How to reproduce
   
   _No response_
   
   ### Operating System
   
   RHEL8
   
   ### Versions of Apache Airflow Providers
   
   _No response_
   
   ### Deployment
   
   Other
   
   ### Deployment details
   
   _No response_
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on issue #22336: `airflow dags backfill` command doesn't propagate DagRun conf attribute if the DagRun already exists

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #22336:
URL: https://github.com/apache/airflow/issues/22336#issuecomment-1070786712


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org