Re: [jira] [Issue Comment Edited] (CAMEL-4796) Code Clean-Up

[Johan Edstrom <se...@gmail.com>]

Babak!

Pretty awesome cleanup, thanks from all of us!

/je

On Jan 14, 2012, at 8:38 PM, Babak Vahdat (Issue Comment Edited) (JIRA) wrote:

> 
>    [ https://issues.apache.org/jira/browse/CAMEL-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186393#comment-13186393 ] 
> 
> Babak Vahdat edited comment on CAMEL-4796 at 1/15/12 3:38 AM:
> --------------------------------------------------------------
> 
> Attached the 3rd & *last* patch regarding avoidance of the raw types by the generified classes. The patch also includes:
> 
> - more utility methods by TryDefinition, ProxyHelper and ProxyBuilder (avoiding compiler warnings where there's only one single Class object parameter)
> - One checkstyle fix by ScheduledBatchPollingConsumer (CAMEL-4577)
> - fixed the deprecated usage of org.springframework.security.core.authority.SimpleGrantedAuthority in SpringSecurityAuthorizationPolicyTest
> 
> 
> Note: By the beginning of this ticket I used to see 1991 compiler warnings in total (see the Description field of this ticket), however currently I see only 346 left!
> 
>      was (Author: bvahdat):
>    Attached the 3rd & *last* patch regarding avoidance of the raw types by the generified classes. The patch also includes:
> 
> - more utility methods by OnExceptionDefinition, ProxyHelper and ProxyBuilder (avoiding compiler warnings where there's only one single Class object parameter)
> - One checkstyle fix by ScheduledBatchPollingConsumer (CAMEL-4577)
> - fixed the deprecated usage of org.springframework.security.core.authority.SimpleGrantedAuthority in SpringSecurityAuthorizationPolicyTest
> 
> 
> Note: By the beginning of this ticket I used to see 1991 compiler warnings in total (see the Description field of this ticket), however currently I see only 346 left!
> 
>> Code Clean-Up
>> -------------
>> 
>>                Key: CAMEL-4796
>>                URL: https://issues.apache.org/jira/browse/CAMEL-4796
>>            Project: Camel
>>         Issue Type: Improvement
>>   Affects Versions: 2.8.3
>>           Reporter: Babak Vahdat
>>           Assignee: Babak Vahdat
>>            Fix For: 2.9.1, 2.10.0
>> 
>>        Attachments: CAMEL-4796-@Deprecated-@Override.patch, CAMEL-4796-avoid-rawtypes-2.patch, CAMEL-4796-avoid-rawtypes-3.patch, CAMEL-4796-avoid-rawtypes.patch, CAMEL-4796-enhanced-for-loops.patch, CAMEL-4796-obsolete-super-call.patch, CAMEL-4796-organize-imports-2.patch, CAMEL-4796-organize-imports.patch, CAMEL-4796-remove-$NON-NLS$.patch, CAMEL-4796-remove-unnecessary-casts.patch
>> 
>> 
>> This ticket aims to resolve the issues already mentioned in [1], but just to name them ALL explicitly here:
>> - Removal of the unused imports
>> - Convert for loops to the enhanced one (supported since Java Tiger)
>> - Removal of the obsolete "super();" call by the Constructors (Since JDK 1.0 compilers already do it inside the byte-code for free!)
>> - Remove of all $NON-NLS$ tags
>> - Removal of the unnecessary casts
>> - Usage of the @Deprecated & @Override annotations where required (will be skipped because of the reasons Claus has already mentioned in his comment for the already provided patch)
>> - Avoidance of the raw type declarations by the generified classes *as much as possible*
>> - Removal of unused private memebers: Types, Constructors, Fields and Methods where applicable
>> - Remove the trailing whitespace on *all* lines, even on the empty ones
>> 
>> Add of missing serialVersionUID where required and default it to *1L* where serialVersionUID has been already declared should be better postponed to the major 3.0.x release as otherwise the backward-compatility would be broken on the 2.x.y release branches.
>> If you can think of other possible clean-ups as well you may like to propose for including, then please first better discuss it in [1] so that other commiters can better/faster/easier react on it.
>> I'll provide the patches *exactly in the same order* as mentioned above.
>> Right now on the trunk my used IDE (eclipse) reports 1991 warnings!
>> [1] http://camel.465427.n5.nabble.com/DISCUSS-Trunk-Code-Cleanup-td5071594.html
> 
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
> 
>