You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Sonia Garudi <sg...@us.ibm.com> on 2017/12/22 04:41:37 UTC
Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo
exist for
new OS family and user prompt for entering HDP and HDP-UTILs repo URLs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64769/
-----------------------------------------------------------
(Updated Dec. 22, 2017, 4:41 a.m.)
Review request for Ambari and Nate Cole.
Changes
-------
Changed summary
Summary (updated)
-----------------
AMBARI-22406 : UI for verifying if repo exist for new OS family and user prompt for entering HDP and HDP-UTILs repo URLs
Bugs: AMBARI-22406
https://issues.apache.org/jira/browse/AMBARI-22406
Repository: ambari
Description
-------
Includes UI changes in ambari-web to check if the repo is selected or provides prompt to the user to enter the HDP and HDP-utils repo URL's. Includes necessary validation checks for the repo urls, allows user to select the public and local repository and also provides functionality to skip validation checks.
Diffs
-----
ambari-web/app/controllers/wizard/step3_controller.js 29393e3
ambari-web/app/styles/wizard.less 7d425d9
ambari-web/app/templates/wizard/step3.hbs e00012c
ambari-web/app/utils/ajax/ajax.js 3f85dfdc
ambari-web/app/views/wizard/step3_view.js 3249b24
ambari-web/test/controllers/wizard/step3_test.js b8bc794
Diff: https://reviews.apache.org/r/64769/diff/2/
Testing
-------
Tests were successful in ambari-web
Thanks,
Sonia Garudi
Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo
exist for
new OS family and user prompt for entering HDP and HDP-UTILs repo URLs
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64769/#review194955
-----------------------------------------------------------
This has been pushed. Please close this review and associated jira.
- Nate Cole
On Jan. 8, 2018, 8:05 a.m., Sonia Garudi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64769/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2018, 8:05 a.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-22406
> https://issues.apache.org/jira/browse/AMBARI-22406
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Includes UI changes in ambari-web to check if the repo is selected or provides prompt to the user to enter the HDP and HDP-utils repo URL's. Includes necessary validation checks for the repo urls, allows user to select the public and local repository and also provides functionality to skip validation checks.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/wizard/step3_controller.js 55f4323
> ambari-web/app/messages.js 6da0368
> ambari-web/app/styles/wizard.less 4e680ca
> ambari-web/app/templates/wizard/step3.hbs ff436a8
> ambari-web/app/utils/ajax/ajax.js 483be5e
> ambari-web/app/views/wizard/step3/hostWarningPopupBody_view.js 786c4f7
> ambari-web/app/views/wizard/step3_view.js 3249b24
> ambari-web/test/controllers/wizard/step3_test.js b8bc794
>
>
> Diff: https://reviews.apache.org/r/64769/diff/5/
>
>
> Testing
> -------
>
> Tests were successful in ambari-web
>
>
> Thanks,
>
> Sonia Garudi
>
>
Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo
exist for
new OS family and user prompt for entering HDP and HDP-UTILs repo URLs
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64769/#review194954
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Jan. 8, 2018, 8:05 a.m., Sonia Garudi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64769/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2018, 8:05 a.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-22406
> https://issues.apache.org/jira/browse/AMBARI-22406
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Includes UI changes in ambari-web to check if the repo is selected or provides prompt to the user to enter the HDP and HDP-utils repo URL's. Includes necessary validation checks for the repo urls, allows user to select the public and local repository and also provides functionality to skip validation checks.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/wizard/step3_controller.js 55f4323
> ambari-web/app/messages.js 6da0368
> ambari-web/app/styles/wizard.less 4e680ca
> ambari-web/app/templates/wizard/step3.hbs ff436a8
> ambari-web/app/utils/ajax/ajax.js 483be5e
> ambari-web/app/views/wizard/step3/hostWarningPopupBody_view.js 786c4f7
> ambari-web/app/views/wizard/step3_view.js 3249b24
> ambari-web/test/controllers/wizard/step3_test.js b8bc794
>
>
> Diff: https://reviews.apache.org/r/64769/diff/5/
>
>
> Testing
> -------
>
> Tests were successful in ambari-web
>
>
> Thanks,
>
> Sonia Garudi
>
>
Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo
exist for
new OS family and user prompt for entering HDP and HDP-UTILs repo URLs
Posted by Sonia Garudi <sg...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64769/
-----------------------------------------------------------
(Updated Jan. 8, 2018, 1:05 p.m.)
Review request for Ambari and Nate Cole.
Changes
-------
Made changes for using os_family instead of os_type. Also made changes for JAVA_HOME host check warnings.
Bugs: AMBARI-22406
https://issues.apache.org/jira/browse/AMBARI-22406
Repository: ambari
Description
-------
Includes UI changes in ambari-web to check if the repo is selected or provides prompt to the user to enter the HDP and HDP-utils repo URL's. Includes necessary validation checks for the repo urls, allows user to select the public and local repository and also provides functionality to skip validation checks.
Diffs (updated)
-----
ambari-web/app/controllers/wizard/step3_controller.js 55f4323
ambari-web/app/messages.js 6da0368
ambari-web/app/styles/wizard.less 4e680ca
ambari-web/app/templates/wizard/step3.hbs ff436a8
ambari-web/app/utils/ajax/ajax.js 483be5e
ambari-web/app/views/wizard/step3/hostWarningPopupBody_view.js 786c4f7
ambari-web/app/views/wizard/step3_view.js 3249b24
ambari-web/test/controllers/wizard/step3_test.js b8bc794
Diff: https://reviews.apache.org/r/64769/diff/5/
Changes: https://reviews.apache.org/r/64769/diff/4-5/
Testing
-------
Tests were successful in ambari-web
Thanks,
Sonia Garudi
Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo
exist for
new OS family and user prompt for entering HDP and HDP-UTILs repo URLs
Posted by Sonia Garudi <sg...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64769/
-----------------------------------------------------------
(Updated Jan. 4, 2018, 12:07 p.m.)
Review request for Ambari and Nate Cole.
Changes
-------
Removed the API call for getting the os_type for the bootstrapped hosts. Changed the registration check API to include the os_type field, which is later added to the respective hosts in 'bootHosts'.
Bugs: AMBARI-22406
https://issues.apache.org/jira/browse/AMBARI-22406
Repository: ambari
Description
-------
Includes UI changes in ambari-web to check if the repo is selected or provides prompt to the user to enter the HDP and HDP-utils repo URL's. Includes necessary validation checks for the repo urls, allows user to select the public and local repository and also provides functionality to skip validation checks.
Diffs (updated)
-----
ambari-web/app/controllers/wizard/step3_controller.js 55f4323
ambari-web/app/styles/wizard.less 4e680ca
ambari-web/app/templates/wizard/step3.hbs ff436a8
ambari-web/app/utils/ajax/ajax.js 483be5e
ambari-web/app/views/wizard/step3_view.js 3249b24
ambari-web/test/controllers/wizard/step3_test.js b8bc794
Diff: https://reviews.apache.org/r/64769/diff/4/
Changes: https://reviews.apache.org/r/64769/diff/3-4/
Testing
-------
Tests were successful in ambari-web
Thanks,
Sonia Garudi
Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo
exist for
new OS family and user prompt for entering HDP and HDP-UTILs repo URLs
Posted by Sonia Garudi <sg...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64769/
-----------------------------------------------------------
(Updated Dec. 26, 2017, 12:05 p.m.)
Review request for Ambari and Nate Cole.
Changes
-------
Updated code with suggested changes
Bugs: AMBARI-22406
https://issues.apache.org/jira/browse/AMBARI-22406
Repository: ambari
Description
-------
Includes UI changes in ambari-web to check if the repo is selected or provides prompt to the user to enter the HDP and HDP-utils repo URL's. Includes necessary validation checks for the repo urls, allows user to select the public and local repository and also provides functionality to skip validation checks.
Diffs (updated)
-----
ambari-web/app/controllers/wizard/step3_controller.js 29393e3
ambari-web/app/styles/wizard.less 7d425d9
ambari-web/app/templates/wizard/step3.hbs e00012c
ambari-web/app/utils/ajax/ajax.js 3f85dfdc
ambari-web/app/views/wizard/step3_view.js 3249b24
ambari-web/test/controllers/wizard/step3_test.js b8bc794
Diff: https://reviews.apache.org/r/64769/diff/3/
Changes: https://reviews.apache.org/r/64769/diff/2-3/
Testing
-------
Tests were successful in ambari-web
Thanks,
Sonia Garudi
Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo
exist for
new OS family and user prompt for entering HDP and HDP-UTILs repo URLs
Posted by Yussuf Shaikh <yu...@us.ibm.com>.
> On Dec. 22, 2017, 2:51 p.m., Nate Cole wrote:
> > ambari-web/app/controllers/wizard/step3_controller.js
> > Lines 863-880 (patched)
> > <https://reviews.apache.org/r/64769/diff/2/?file=1925966#file1925966line863>
> >
> > I'm no UI expert, but this entire new block seems to be doing repo stuff that already is on the UI. Can you explain the gist here?
>
> Sonia Garudi wrote:
> We need each host's os type which is not available on the UI. This function makes an API call which gets information of all the bootstrapped hosts .
>
> Nate Cole wrote:
> I see. We should probably have that returned as part of host registration and read it from there instead of making another call. Is that possible in this patch?
>
> Sonia Garudi wrote:
> The os types of the bootstrapped hosts can be obtained in the registration success callback(isHostsRegisteredSuccessCallback) which would eliminate the above API call. This would involve editing the 'wizard.step3.is_hosts_registered' API call in ajax.js to include the 'Hosts/os_type' field.
> Please let me know your suggestions.
>
> Nate Cole wrote:
> That sounds reasonable instead of making another call. Can we make that an error/failure case after registration that we don't have a JAVA_HOME matching the type?
Do you want us to fail the Host Registration if java home is not found for host os_type?
We were planning to just show a message on the host check warnings popup that Host does not have proper Java Home set of its Os type and default java home will be used. This assumption is because during normal(existing) flow Amabari show warning for incorrect Java Home and does not fail registration.
- Yussuf
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64769/#review194434
-----------------------------------------------------------
On Jan. 4, 2018, 12:07 p.m., Sonia Garudi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64769/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2018, 12:07 p.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-22406
> https://issues.apache.org/jira/browse/AMBARI-22406
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Includes UI changes in ambari-web to check if the repo is selected or provides prompt to the user to enter the HDP and HDP-utils repo URL's. Includes necessary validation checks for the repo urls, allows user to select the public and local repository and also provides functionality to skip validation checks.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/wizard/step3_controller.js 55f4323
> ambari-web/app/styles/wizard.less 4e680ca
> ambari-web/app/templates/wizard/step3.hbs ff436a8
> ambari-web/app/utils/ajax/ajax.js 483be5e
> ambari-web/app/views/wizard/step3_view.js 3249b24
> ambari-web/test/controllers/wizard/step3_test.js b8bc794
>
>
> Diff: https://reviews.apache.org/r/64769/diff/4/
>
>
> Testing
> -------
>
> Tests were successful in ambari-web
>
>
> Thanks,
>
> Sonia Garudi
>
>
Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo
exist for
new OS family and user prompt for entering HDP and HDP-UTILs repo URLs
Posted by Nate Cole <nc...@hortonworks.com>.
> On Dec. 22, 2017, 9:51 a.m., Nate Cole wrote:
> > ambari-web/app/controllers/wizard/step3_controller.js
> > Lines 863-880 (patched)
> > <https://reviews.apache.org/r/64769/diff/2/?file=1925966#file1925966line863>
> >
> > I'm no UI expert, but this entire new block seems to be doing repo stuff that already is on the UI. Can you explain the gist here?
>
> Sonia Garudi wrote:
> We need each host's os type which is not available on the UI. This function makes an API call which gets information of all the bootstrapped hosts .
>
> Nate Cole wrote:
> I see. We should probably have that returned as part of host registration and read it from there instead of making another call. Is that possible in this patch?
>
> Sonia Garudi wrote:
> The os types of the bootstrapped hosts can be obtained in the registration success callback(isHostsRegisteredSuccessCallback) which would eliminate the above API call. This would involve editing the 'wizard.step3.is_hosts_registered' API call in ajax.js to include the 'Hosts/os_type' field.
> Please let me know your suggestions.
>
> Nate Cole wrote:
> That sounds reasonable instead of making another call. Can we make that an error/failure case after registration that we don't have a JAVA_HOME matching the type?
>
> Yussuf Shaikh wrote:
> Do you want us to fail the Host Registration if java home is not found for host os_type?
> We were planning to just show a message on the host check warnings popup that Host does not have proper Java Home set of its Os type and default java home will be used. This assumption is because during normal(existing) flow Amabari show warning for incorrect Java Home and does not fail registration.
No need to fail host registration. The popup informational is fine.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64769/#review194434
-----------------------------------------------------------
On Jan. 4, 2018, 7:07 a.m., Sonia Garudi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64769/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2018, 7:07 a.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-22406
> https://issues.apache.org/jira/browse/AMBARI-22406
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Includes UI changes in ambari-web to check if the repo is selected or provides prompt to the user to enter the HDP and HDP-utils repo URL's. Includes necessary validation checks for the repo urls, allows user to select the public and local repository and also provides functionality to skip validation checks.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/wizard/step3_controller.js 55f4323
> ambari-web/app/styles/wizard.less 4e680ca
> ambari-web/app/templates/wizard/step3.hbs ff436a8
> ambari-web/app/utils/ajax/ajax.js 483be5e
> ambari-web/app/views/wizard/step3_view.js 3249b24
> ambari-web/test/controllers/wizard/step3_test.js b8bc794
>
>
> Diff: https://reviews.apache.org/r/64769/diff/4/
>
>
> Testing
> -------
>
> Tests were successful in ambari-web
>
>
> Thanks,
>
> Sonia Garudi
>
>
Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo
exist for
new OS family and user prompt for entering HDP and HDP-UTILs repo URLs
Posted by Sonia Garudi <sg...@us.ibm.com>.
> On Dec. 22, 2017, 2:51 p.m., Nate Cole wrote:
> > ambari-web/app/controllers/wizard/step3_controller.js
> > Lines 968-972 (patched)
> > <https://reviews.apache.org/r/64769/diff/2/?file=1925966#file1925966line968>
> >
> > Should not rely on the name for the id. The API should be giving you the id.
>
> Sonia Garudi wrote:
> Made the required change in next diff.
>
> Nate Cole wrote:
> Ok, please resolve review issues as they are fixed in diffs with "Fixed"
I made the change to get the stackId based on repositoryVersion instead of displayName. However, the repositoryVersion is set to '2.6.2.0' irrespective of the actual version of HDP installed(not sure if its a bug). I was unable to retrieve the proper installed version of HDP on the UI using any API call. Please let me know your suggestions.
- Sonia
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64769/#review194434
-----------------------------------------------------------
On Jan. 4, 2018, 12:07 p.m., Sonia Garudi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64769/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2018, 12:07 p.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-22406
> https://issues.apache.org/jira/browse/AMBARI-22406
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Includes UI changes in ambari-web to check if the repo is selected or provides prompt to the user to enter the HDP and HDP-utils repo URL's. Includes necessary validation checks for the repo urls, allows user to select the public and local repository and also provides functionality to skip validation checks.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/wizard/step3_controller.js 55f4323
> ambari-web/app/styles/wizard.less 4e680ca
> ambari-web/app/templates/wizard/step3.hbs ff436a8
> ambari-web/app/utils/ajax/ajax.js 483be5e
> ambari-web/app/views/wizard/step3_view.js 3249b24
> ambari-web/test/controllers/wizard/step3_test.js b8bc794
>
>
> Diff: https://reviews.apache.org/r/64769/diff/4/
>
>
> Testing
> -------
>
> Tests were successful in ambari-web
>
>
> Thanks,
>
> Sonia Garudi
>
>
Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo
exist for
new OS family and user prompt for entering HDP and HDP-UTILs repo URLs
Posted by Sonia Garudi <sg...@us.ibm.com>.
> On Dec. 22, 2017, 2:51 p.m., Nate Cole wrote:
> > ambari-web/app/controllers/wizard/step3_controller.js
> > Lines 968-972 (patched)
> > <https://reviews.apache.org/r/64769/diff/2/?file=1925966#file1925966line968>
> >
> > Should not rely on the name for the id. The API should be giving you the id.
>
> Sonia Garudi wrote:
> Made the required change in next diff.
>
> Nate Cole wrote:
> Ok, please resolve review issues as they are fixed in diffs with "Fixed"
>
> Sonia Garudi wrote:
> I made the change to get the stackId based on repositoryVersion instead of displayName. However, the repositoryVersion is set to '2.6.2.0' irrespective of the actual version of HDP installed(not sure if its a bug). I was unable to retrieve the proper installed version of HDP on the UI using any API call. Please let me know your suggestions.
In the latest diff, I have reverted to the previous change(i.e. use of displayName instead of repositoryVersion to get the version_definition_id).
- Sonia
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64769/#review194434
-----------------------------------------------------------
On Jan. 8, 2018, 1:05 p.m., Sonia Garudi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64769/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2018, 1:05 p.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-22406
> https://issues.apache.org/jira/browse/AMBARI-22406
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Includes UI changes in ambari-web to check if the repo is selected or provides prompt to the user to enter the HDP and HDP-utils repo URL's. Includes necessary validation checks for the repo urls, allows user to select the public and local repository and also provides functionality to skip validation checks.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/wizard/step3_controller.js 55f4323
> ambari-web/app/messages.js 6da0368
> ambari-web/app/styles/wizard.less 4e680ca
> ambari-web/app/templates/wizard/step3.hbs ff436a8
> ambari-web/app/utils/ajax/ajax.js 483be5e
> ambari-web/app/views/wizard/step3/hostWarningPopupBody_view.js 786c4f7
> ambari-web/app/views/wizard/step3_view.js 3249b24
> ambari-web/test/controllers/wizard/step3_test.js b8bc794
>
>
> Diff: https://reviews.apache.org/r/64769/diff/5/
>
>
> Testing
> -------
>
> Tests were successful in ambari-web
>
>
> Thanks,
>
> Sonia Garudi
>
>
Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo
exist for
new OS family and user prompt for entering HDP and HDP-UTILs repo URLs
Posted by Sonia Garudi <sg...@us.ibm.com>.
> On Dec. 22, 2017, 2:51 p.m., Nate Cole wrote:
> > ambari-web/app/controllers/wizard/step3_controller.js
> > Lines 863-880 (patched)
> > <https://reviews.apache.org/r/64769/diff/2/?file=1925966#file1925966line863>
> >
> > I'm no UI expert, but this entire new block seems to be doing repo stuff that already is on the UI. Can you explain the gist here?
>
> Sonia Garudi wrote:
> We need each host's os type which is not available on the UI. This function makes an API call which gets information of all the bootstrapped hosts .
>
> Nate Cole wrote:
> I see. We should probably have that returned as part of host registration and read it from there instead of making another call. Is that possible in this patch?
The os types of the bootstrapped hosts can be obtained in the registration success callback(isHostsRegisteredSuccessCallback) which would eliminate the above API call. This would involve editing the 'wizard.step3.is_hosts_registered' API call in ajax.js to include the 'Hosts/os_type' field.
Please let me know your suggestions.
- Sonia
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64769/#review194434
-----------------------------------------------------------
On Dec. 26, 2017, 12:05 p.m., Sonia Garudi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64769/
> -----------------------------------------------------------
>
> (Updated Dec. 26, 2017, 12:05 p.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-22406
> https://issues.apache.org/jira/browse/AMBARI-22406
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Includes UI changes in ambari-web to check if the repo is selected or provides prompt to the user to enter the HDP and HDP-utils repo URL's. Includes necessary validation checks for the repo urls, allows user to select the public and local repository and also provides functionality to skip validation checks.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/wizard/step3_controller.js 29393e3
> ambari-web/app/styles/wizard.less 7d425d9
> ambari-web/app/templates/wizard/step3.hbs e00012c
> ambari-web/app/utils/ajax/ajax.js 3f85dfdc
> ambari-web/app/views/wizard/step3_view.js 3249b24
> ambari-web/test/controllers/wizard/step3_test.js b8bc794
>
>
> Diff: https://reviews.apache.org/r/64769/diff/3/
>
>
> Testing
> -------
>
> Tests were successful in ambari-web
>
>
> Thanks,
>
> Sonia Garudi
>
>
Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo
exist for
new OS family and user prompt for entering HDP and HDP-UTILs repo URLs
Posted by Sonia Garudi <sg...@us.ibm.com>.
> On Dec. 22, 2017, 2:51 p.m., Nate Cole wrote:
> > ambari-web/app/controllers/wizard/step3_controller.js
> > Lines 863-880 (patched)
> > <https://reviews.apache.org/r/64769/diff/2/?file=1925966#file1925966line863>
> >
> > I'm no UI expert, but this entire new block seems to be doing repo stuff that already is on the UI. Can you explain the gist here?
>
> Sonia Garudi wrote:
> We need each host's os type which is not available on the UI. This function makes an API call which gets information of all the bootstrapped hosts .
>
> Nate Cole wrote:
> I see. We should probably have that returned as part of host registration and read it from there instead of making another call. Is that possible in this patch?
>
> Sonia Garudi wrote:
> The os types of the bootstrapped hosts can be obtained in the registration success callback(isHostsRegisteredSuccessCallback) which would eliminate the above API call. This would involve editing the 'wizard.step3.is_hosts_registered' API call in ajax.js to include the 'Hosts/os_type' field.
> Please let me know your suggestions.
>
> Nate Cole wrote:
> That sounds reasonable instead of making another call. Can we make that an error/failure case after registration that we don't have a JAVA_HOME matching the type?
>
> Yussuf Shaikh wrote:
> Do you want us to fail the Host Registration if java home is not found for host os_type?
> We were planning to just show a message on the host check warnings popup that Host does not have proper Java Home set of its Os type and default java home will be used. This assumption is because during normal(existing) flow Amabari show warning for incorrect Java Home and does not fail registration.
>
> Nate Cole wrote:
> No need to fail host registration. The popup informational is fine.
Eliminated the API call by editing registration API to get the os_family. Also made changes to display java home host check warnings.
> On Dec. 22, 2017, 2:51 p.m., Nate Cole wrote:
> > ambari-web/app/controllers/wizard/step3_controller.js
> > Lines 968-972 (patched)
> > <https://reviews.apache.org/r/64769/diff/2/?file=1925966#file1925966line968>
> >
> > Should not rely on the name for the id. The API should be giving you the id.
>
> Sonia Garudi wrote:
> Made the required change in next diff.
>
> Nate Cole wrote:
> Ok, please resolve review issues as they are fixed in diffs with "Fixed"
>
> Sonia Garudi wrote:
> I made the change to get the stackId based on repositoryVersion instead of displayName. However, the repositoryVersion is set to '2.6.2.0' irrespective of the actual version of HDP installed(not sure if its a bug). I was unable to retrieve the proper installed version of HDP on the UI using any API call. Please let me know your suggestions.
>
> Sonia Garudi wrote:
> In the latest diff, I have reverted to the previous change(i.e. use of displayName instead of repositoryVersion to get the version_definition_id).
Do you have any suggestions for getting the proper installed version of HDP? Or should we continue using the displayName?
If possible could you merge this patch, as we can include these changes in the further patches.
- Sonia
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64769/#review194434
-----------------------------------------------------------
On Jan. 8, 2018, 1:05 p.m., Sonia Garudi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64769/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2018, 1:05 p.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-22406
> https://issues.apache.org/jira/browse/AMBARI-22406
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Includes UI changes in ambari-web to check if the repo is selected or provides prompt to the user to enter the HDP and HDP-utils repo URL's. Includes necessary validation checks for the repo urls, allows user to select the public and local repository and also provides functionality to skip validation checks.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/wizard/step3_controller.js 55f4323
> ambari-web/app/messages.js 6da0368
> ambari-web/app/styles/wizard.less 4e680ca
> ambari-web/app/templates/wizard/step3.hbs ff436a8
> ambari-web/app/utils/ajax/ajax.js 483be5e
> ambari-web/app/views/wizard/step3/hostWarningPopupBody_view.js 786c4f7
> ambari-web/app/views/wizard/step3_view.js 3249b24
> ambari-web/test/controllers/wizard/step3_test.js b8bc794
>
>
> Diff: https://reviews.apache.org/r/64769/diff/5/
>
>
> Testing
> -------
>
> Tests were successful in ambari-web
>
>
> Thanks,
>
> Sonia Garudi
>
>
Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo
exist for
new OS family and user prompt for entering HDP and HDP-UTILs repo URLs
Posted by Nate Cole <nc...@hortonworks.com>.
> On Dec. 22, 2017, 9:51 a.m., Nate Cole wrote:
> > ambari-web/app/controllers/wizard/step3_controller.js
> > Lines 863-880 (patched)
> > <https://reviews.apache.org/r/64769/diff/2/?file=1925966#file1925966line863>
> >
> > I'm no UI expert, but this entire new block seems to be doing repo stuff that already is on the UI. Can you explain the gist here?
>
> Sonia Garudi wrote:
> We need each host's os type which is not available on the UI. This function makes an API call which gets information of all the bootstrapped hosts .
>
> Nate Cole wrote:
> I see. We should probably have that returned as part of host registration and read it from there instead of making another call. Is that possible in this patch?
>
> Sonia Garudi wrote:
> The os types of the bootstrapped hosts can be obtained in the registration success callback(isHostsRegisteredSuccessCallback) which would eliminate the above API call. This would involve editing the 'wizard.step3.is_hosts_registered' API call in ajax.js to include the 'Hosts/os_type' field.
> Please let me know your suggestions.
That sounds reasonable instead of making another call. Can we make that an error/failure case after registration that we don't have a JAVA_HOME matching the type?
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64769/#review194434
-----------------------------------------------------------
On Jan. 4, 2018, 7:07 a.m., Sonia Garudi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64769/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2018, 7:07 a.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-22406
> https://issues.apache.org/jira/browse/AMBARI-22406
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Includes UI changes in ambari-web to check if the repo is selected or provides prompt to the user to enter the HDP and HDP-utils repo URL's. Includes necessary validation checks for the repo urls, allows user to select the public and local repository and also provides functionality to skip validation checks.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/wizard/step3_controller.js 55f4323
> ambari-web/app/styles/wizard.less 4e680ca
> ambari-web/app/templates/wizard/step3.hbs ff436a8
> ambari-web/app/utils/ajax/ajax.js 483be5e
> ambari-web/app/views/wizard/step3_view.js 3249b24
> ambari-web/test/controllers/wizard/step3_test.js b8bc794
>
>
> Diff: https://reviews.apache.org/r/64769/diff/4/
>
>
> Testing
> -------
>
> Tests were successful in ambari-web
>
>
> Thanks,
>
> Sonia Garudi
>
>
Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo
exist for
new OS family and user prompt for entering HDP and HDP-UTILs repo URLs
Posted by Nate Cole <nc...@hortonworks.com>.
> On Dec. 22, 2017, 9:51 a.m., Nate Cole wrote:
> > ambari-web/app/controllers/wizard/step3_controller.js
> > Lines 863-880 (patched)
> > <https://reviews.apache.org/r/64769/diff/2/?file=1925966#file1925966line863>
> >
> > I'm no UI expert, but this entire new block seems to be doing repo stuff that already is on the UI. Can you explain the gist here?
>
> Sonia Garudi wrote:
> We need each host's os type which is not available on the UI. This function makes an API call which gets information of all the bootstrapped hosts .
I see. We should probably have that returned as part of host registration and read it from there instead of making another call. Is that possible in this patch?
> On Dec. 22, 2017, 9:51 a.m., Nate Cole wrote:
> > ambari-web/app/controllers/wizard/step3_controller.js
> > Lines 968-972 (patched)
> > <https://reviews.apache.org/r/64769/diff/2/?file=1925966#file1925966line968>
> >
> > Should not rely on the name for the id. The API should be giving you the id.
>
> Sonia Garudi wrote:
> Made the required change in next diff.
Ok, please resolve review issues as they are fixed in diffs with "Fixed"
> On Dec. 22, 2017, 9:51 a.m., Nate Cole wrote:
> > ambari-web/app/controllers/wizard/step3_controller.js
> > Lines 1192 (patched)
> > <https://reviews.apache.org/r/64769/diff/2/?file=1925966#file1925966line1192>
> >
> > ftp? I think it's fine to be only http or https.
>
> Sonia Garudi wrote:
> Made the required change in next diff.
Ok, please resolve review issues as they are fixed in diffs with "Fixed"
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64769/#review194434
-----------------------------------------------------------
On Dec. 26, 2017, 7:05 a.m., Sonia Garudi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64769/
> -----------------------------------------------------------
>
> (Updated Dec. 26, 2017, 7:05 a.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-22406
> https://issues.apache.org/jira/browse/AMBARI-22406
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Includes UI changes in ambari-web to check if the repo is selected or provides prompt to the user to enter the HDP and HDP-utils repo URL's. Includes necessary validation checks for the repo urls, allows user to select the public and local repository and also provides functionality to skip validation checks.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/wizard/step3_controller.js 29393e3
> ambari-web/app/styles/wizard.less 7d425d9
> ambari-web/app/templates/wizard/step3.hbs e00012c
> ambari-web/app/utils/ajax/ajax.js 3f85dfdc
> ambari-web/app/views/wizard/step3_view.js 3249b24
> ambari-web/test/controllers/wizard/step3_test.js b8bc794
>
>
> Diff: https://reviews.apache.org/r/64769/diff/3/
>
>
> Testing
> -------
>
> Tests were successful in ambari-web
>
>
> Thanks,
>
> Sonia Garudi
>
>
Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo
exist for
new OS family and user prompt for entering HDP and HDP-UTILs repo URLs
Posted by Sonia Garudi <sg...@us.ibm.com>.
> On Dec. 22, 2017, 2:51 p.m., Nate Cole wrote:
> > ambari-web/app/controllers/wizard/step3_controller.js
> > Lines 863-880 (patched)
> > <https://reviews.apache.org/r/64769/diff/2/?file=1925966#file1925966line863>
> >
> > I'm no UI expert, but this entire new block seems to be doing repo stuff that already is on the UI. Can you explain the gist here?
We need each host's os type which is not available on the UI. This function makes an API call which gets information of all the bootstrapped hosts .
> On Dec. 22, 2017, 2:51 p.m., Nate Cole wrote:
> > ambari-web/app/controllers/wizard/step3_controller.js
> > Lines 968-972 (patched)
> > <https://reviews.apache.org/r/64769/diff/2/?file=1925966#file1925966line968>
> >
> > Should not rely on the name for the id. The API should be giving you the id.
Made the required change in next diff.
> On Dec. 22, 2017, 2:51 p.m., Nate Cole wrote:
> > ambari-web/app/controllers/wizard/step3_controller.js
> > Lines 1192 (patched)
> > <https://reviews.apache.org/r/64769/diff/2/?file=1925966#file1925966line1192>
> >
> > ftp? I think it's fine to be only http or https.
Made the required change in next diff.
- Sonia
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64769/#review194434
-----------------------------------------------------------
On Dec. 22, 2017, 4:41 a.m., Sonia Garudi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64769/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2017, 4:41 a.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-22406
> https://issues.apache.org/jira/browse/AMBARI-22406
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Includes UI changes in ambari-web to check if the repo is selected or provides prompt to the user to enter the HDP and HDP-utils repo URL's. Includes necessary validation checks for the repo urls, allows user to select the public and local repository and also provides functionality to skip validation checks.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/wizard/step3_controller.js 29393e3
> ambari-web/app/styles/wizard.less 7d425d9
> ambari-web/app/templates/wizard/step3.hbs e00012c
> ambari-web/app/utils/ajax/ajax.js 3f85dfdc
> ambari-web/app/views/wizard/step3_view.js 3249b24
> ambari-web/test/controllers/wizard/step3_test.js b8bc794
>
>
> Diff: https://reviews.apache.org/r/64769/diff/2/
>
>
> Testing
> -------
>
> Tests were successful in ambari-web
>
>
> Thanks,
>
> Sonia Garudi
>
>
Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo
exist for
new OS family and user prompt for entering HDP and HDP-UTILs repo URLs
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64769/#review194434
-----------------------------------------------------------
ambari-web/app/controllers/wizard/step3_controller.js
Lines 863-880 (patched)
<https://reviews.apache.org/r/64769/#comment273200>
I'm no UI expert, but this entire new block seems to be doing repo stuff that already is on the UI. Can you explain the gist here?
ambari-web/app/controllers/wizard/step3_controller.js
Lines 968-972 (patched)
<https://reviews.apache.org/r/64769/#comment273198>
Should not rely on the name for the id. The API should be giving you the id.
ambari-web/app/controllers/wizard/step3_controller.js
Lines 1192 (patched)
<https://reviews.apache.org/r/64769/#comment273199>
ftp? I think it's fine to be only http or https.
- Nate Cole
On Dec. 21, 2017, 11:41 p.m., Sonia Garudi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64769/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2017, 11:41 p.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-22406
> https://issues.apache.org/jira/browse/AMBARI-22406
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Includes UI changes in ambari-web to check if the repo is selected or provides prompt to the user to enter the HDP and HDP-utils repo URL's. Includes necessary validation checks for the repo urls, allows user to select the public and local repository and also provides functionality to skip validation checks.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/wizard/step3_controller.js 29393e3
> ambari-web/app/styles/wizard.less 7d425d9
> ambari-web/app/templates/wizard/step3.hbs e00012c
> ambari-web/app/utils/ajax/ajax.js 3f85dfdc
> ambari-web/app/views/wizard/step3_view.js 3249b24
> ambari-web/test/controllers/wizard/step3_test.js b8bc794
>
>
> Diff: https://reviews.apache.org/r/64769/diff/2/
>
>
> Testing
> -------
>
> Tests were successful in ambari-web
>
>
> Thanks,
>
> Sonia Garudi
>
>