You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2018/01/29 03:59:43 UTC

[GitHub] spark pull request #20373: [SPARK-23159][PYTHON] Update cloudpickle to match...

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20373#discussion_r164332636
  
    --- Diff: python/pyspark/cloudpickle.py ---
    @@ -1019,18 +948,40 @@ def __reduce__(cls):
             return cls.__name__
     
     
    -def _fill_function(func, globals, defaults, dict, module, closure_values):
    -    """ Fills in the rest of function data into the skeleton function object
    -        that were created via _make_skel_func().
    +def _fill_function(*args):
    +    """Fills in the rest of function data into the skeleton function object
    +
    +    The skeleton itself is create by _make_skel_func().
    --- End diff --
    
    Yea, I think we need this.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org