You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2016/03/04 00:28:45 UTC
Review Request 44368: Dropping bulkLoad() from Storage
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44368/
-----------------------------------------------------------
Review request for Aurora, Joshua Cohen and Zameer Manji.
Bugs: AURORA-1324
https://issues.apache.org/jira/browse/AURORA-1324
Repository: aurora
Description
-------
This has proven useless and will become even more so with the upcoming MVStore switch in AURORA-1627. Undo log is not honored in MVStore at all per http://www.h2database.com/html/mvstore.html#logStructured
Master:
```
Benchmark (updateCount) Mode Cnt Score Error Units
SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 1 thrpt 5 4.833 ± 0.313 ops/s
SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 5 thrpt 5 0.945 ± 0.040 ops/s
SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 10 thrpt 5 0.461 ± 0.054 ops/s
```
This patch:
```
Benchmark (updateCount) Mode Cnt Score Error Units
SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 1 thrpt 5 4.876 ± 0.403 ops/s
SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 5 thrpt 5 0.942 ± 0.032 ops/s
SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 10 thrpt 5 0.436 ± 0.040 ops/s
```
Diffs
-----
src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java dc1ef82bce9e8e243974f8b97165f4417d870a7e
src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 293b88f462183cc85b02aaf875e887d21f4552c5
src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java de4ada431634fb171fab109f1923da810b361205
src/main/java/org/apache/aurora/scheduler/storage/Storage.java 578bb37de8853c4228e76b31f601430b7170946a
src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java c0f8d352a56edffffe9ce96e4dfeb75dab6b97a6
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 243c8a03e72f070538e072afbd3a69f9517f8c26
src/test/java/org/apache/aurora/scheduler/app/local/FakeNonVolatileStorage.java 0768ec37bbc6c3c101aa04a953a36a4af7b25963
src/test/java/org/apache/aurora/scheduler/storage/db/DbStorageTest.java 420d444061ba50678fb77fd454a3fe02a8ba189a
src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 7382eca281eeab17d407ed140f16d6a633d8ad72
Diff: https://reviews.apache.org/r/44368/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Maxim Khutornenko
Re: Review Request 44368: Dropping bulkLoad() from Storage
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44368/#review121958
-----------------------------------------------------------
Ship it!
Ship It!
- Joshua Cohen
On March 3, 2016, 11:28 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44368/
> -----------------------------------------------------------
>
> (Updated March 3, 2016, 11:28 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Zameer Manji.
>
>
> Bugs: AURORA-1324
> https://issues.apache.org/jira/browse/AURORA-1324
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This has proven useless and will become even more so with the upcoming MVStore switch in AURORA-1627. Undo log is not honored in MVStore at all per http://www.h2database.com/html/mvstore.html#logStructured
>
> Master:
> ```
> Benchmark (updateCount) Mode Cnt Score Error Units
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 1 thrpt 5 4.833 ± 0.313 ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 5 thrpt 5 0.945 ± 0.040 ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 10 thrpt 5 0.461 ± 0.054 ops/s
> ```
>
> This patch:
> ```
> Benchmark (updateCount) Mode Cnt Score Error Units
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 1 thrpt 5 4.876 ± 0.403 ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 5 thrpt 5 0.942 ± 0.032 ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 10 thrpt 5 0.436 ± 0.040 ops/s
> ```
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java dc1ef82bce9e8e243974f8b97165f4417d870a7e
> src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 293b88f462183cc85b02aaf875e887d21f4552c5
> src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java de4ada431634fb171fab109f1923da810b361205
> src/main/java/org/apache/aurora/scheduler/storage/Storage.java 578bb37de8853c4228e76b31f601430b7170946a
> src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java c0f8d352a56edffffe9ce96e4dfeb75dab6b97a6
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 243c8a03e72f070538e072afbd3a69f9517f8c26
> src/test/java/org/apache/aurora/scheduler/app/local/FakeNonVolatileStorage.java 0768ec37bbc6c3c101aa04a953a36a4af7b25963
> src/test/java/org/apache/aurora/scheduler/storage/db/DbStorageTest.java 420d444061ba50678fb77fd454a3fe02a8ba189a
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 7382eca281eeab17d407ed140f16d6a633d8ad72
>
> Diff: https://reviews.apache.org/r/44368/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 44368: Dropping bulkLoad() from Storage
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44368/#review121963
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On March 3, 2016, 3:28 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44368/
> -----------------------------------------------------------
>
> (Updated March 3, 2016, 3:28 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Zameer Manji.
>
>
> Bugs: AURORA-1324
> https://issues.apache.org/jira/browse/AURORA-1324
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This has proven useless and will become even more so with the upcoming MVStore switch in AURORA-1627. Undo log is not honored in MVStore at all per http://www.h2database.com/html/mvstore.html#logStructured
>
> Master:
> ```
> Benchmark (updateCount) Mode Cnt Score Error Units
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 1 thrpt 5 4.833 ± 0.313 ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 5 thrpt 5 0.945 ± 0.040 ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 10 thrpt 5 0.461 ± 0.054 ops/s
> ```
>
> This patch:
> ```
> Benchmark (updateCount) Mode Cnt Score Error Units
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 1 thrpt 5 4.876 ± 0.403 ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 5 thrpt 5 0.942 ± 0.032 ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 10 thrpt 5 0.436 ± 0.040 ops/s
> ```
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java dc1ef82bce9e8e243974f8b97165f4417d870a7e
> src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 293b88f462183cc85b02aaf875e887d21f4552c5
> src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java de4ada431634fb171fab109f1923da810b361205
> src/main/java/org/apache/aurora/scheduler/storage/Storage.java 578bb37de8853c4228e76b31f601430b7170946a
> src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java c0f8d352a56edffffe9ce96e4dfeb75dab6b97a6
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 243c8a03e72f070538e072afbd3a69f9517f8c26
> src/test/java/org/apache/aurora/scheduler/app/local/FakeNonVolatileStorage.java 0768ec37bbc6c3c101aa04a953a36a4af7b25963
> src/test/java/org/apache/aurora/scheduler/storage/db/DbStorageTest.java 420d444061ba50678fb77fd454a3fe02a8ba189a
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 7382eca281eeab17d407ed140f16d6a633d8ad72
>
> Diff: https://reviews.apache.org/r/44368/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 44368: Dropping bulkLoad() from Storage
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44368/#review121962
-----------------------------------------------------------
Ship it!
Master (98a2bc1) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 3, 2016, 11:28 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44368/
> -----------------------------------------------------------
>
> (Updated March 3, 2016, 11:28 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Zameer Manji.
>
>
> Bugs: AURORA-1324
> https://issues.apache.org/jira/browse/AURORA-1324
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This has proven useless and will become even more so with the upcoming MVStore switch in AURORA-1627. Undo log is not honored in MVStore at all per http://www.h2database.com/html/mvstore.html#logStructured
>
> Master:
> ```
> Benchmark (updateCount) Mode Cnt Score Error Units
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 1 thrpt 5 4.833 ± 0.313 ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 5 thrpt 5 0.945 ± 0.040 ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 10 thrpt 5 0.461 ± 0.054 ops/s
> ```
>
> This patch:
> ```
> Benchmark (updateCount) Mode Cnt Score Error Units
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 1 thrpt 5 4.876 ± 0.403 ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 5 thrpt 5 0.942 ± 0.032 ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 10 thrpt 5 0.436 ± 0.040 ops/s
> ```
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java dc1ef82bce9e8e243974f8b97165f4417d870a7e
> src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 293b88f462183cc85b02aaf875e887d21f4552c5
> src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java de4ada431634fb171fab109f1923da810b361205
> src/main/java/org/apache/aurora/scheduler/storage/Storage.java 578bb37de8853c4228e76b31f601430b7170946a
> src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java c0f8d352a56edffffe9ce96e4dfeb75dab6b97a6
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 243c8a03e72f070538e072afbd3a69f9517f8c26
> src/test/java/org/apache/aurora/scheduler/app/local/FakeNonVolatileStorage.java 0768ec37bbc6c3c101aa04a953a36a4af7b25963
> src/test/java/org/apache/aurora/scheduler/storage/db/DbStorageTest.java 420d444061ba50678fb77fd454a3fe02a8ba189a
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 7382eca281eeab17d407ed140f16d6a633d8ad72
>
> Diff: https://reviews.apache.org/r/44368/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 44368: Dropping bulkLoad() from Storage
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44368/#review121959
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On March 3, 2016, 3:28 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44368/
> -----------------------------------------------------------
>
> (Updated March 3, 2016, 3:28 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Zameer Manji.
>
>
> Bugs: AURORA-1324
> https://issues.apache.org/jira/browse/AURORA-1324
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This has proven useless and will become even more so with the upcoming MVStore switch in AURORA-1627. Undo log is not honored in MVStore at all per http://www.h2database.com/html/mvstore.html#logStructured
>
> Master:
> ```
> Benchmark (updateCount) Mode Cnt Score Error Units
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 1 thrpt 5 4.833 ± 0.313 ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 5 thrpt 5 0.945 ± 0.040 ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 10 thrpt 5 0.461 ± 0.054 ops/s
> ```
>
> This patch:
> ```
> Benchmark (updateCount) Mode Cnt Score Error Units
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 1 thrpt 5 4.876 ± 0.403 ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 5 thrpt 5 0.942 ± 0.032 ops/s
> SnapshotBenchmarks.RestoreSnapshotWithUpdatesBenchmark.run 10 thrpt 5 0.436 ± 0.040 ops/s
> ```
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java dc1ef82bce9e8e243974f8b97165f4417d870a7e
> src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 293b88f462183cc85b02aaf875e887d21f4552c5
> src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java de4ada431634fb171fab109f1923da810b361205
> src/main/java/org/apache/aurora/scheduler/storage/Storage.java 578bb37de8853c4228e76b31f601430b7170946a
> src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java c0f8d352a56edffffe9ce96e4dfeb75dab6b97a6
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 243c8a03e72f070538e072afbd3a69f9517f8c26
> src/test/java/org/apache/aurora/scheduler/app/local/FakeNonVolatileStorage.java 0768ec37bbc6c3c101aa04a953a36a4af7b25963
> src/test/java/org/apache/aurora/scheduler/storage/db/DbStorageTest.java 420d444061ba50678fb77fd454a3fe02a8ba189a
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 7382eca281eeab17d407ed140f16d6a633d8ad72
>
> Diff: https://reviews.apache.org/r/44368/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>