You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Daniel Dai (JIRA)" <ji...@apache.org> on 2010/01/29 02:31:34 UTC
[jira] Created: (PIG-1210) fieldsToRead send the same fields more
than once in some cases
fieldsToRead send the same fields more than once in some cases
--------------------------------------------------------------
Key: PIG-1210
URL: https://issues.apache.org/jira/browse/PIG-1210
Project: Pig
Issue Type: Bug
Affects Versions: 0.6.0
Reporter: Daniel Dai
Assignee: Daniel Dai
Fix For: 0.7.0
This bug will happen if the following condition meet:
1. LoadFunc is susceptible to duplicated fields in fieldsToRead. The only LoadFunc we notice now is Zebra.
2. The first item in FOREACH statement contains reference to the same input more than once.
For example, the following script will be affected:
a = load '11' using org.apache.hadoop.zebra.pig.TableLoader('a0');
b = foreach a generate a0+a0;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1210) fieldsToRead send the same fields more
than once in some cases
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806303#action_12806303 ]
Hadoop QA commented on PIG-1210:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12431740/PIG-1210-1.patch
against trunk revision 904241.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/183/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/183/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/183/console
This message is automatically generated.
> fieldsToRead send the same fields more than once in some cases
> --------------------------------------------------------------
>
> Key: PIG-1210
> URL: https://issues.apache.org/jira/browse/PIG-1210
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.6.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.6.0
>
> Attachments: PIG-1210-1.patch
>
>
> This bug will happen if the following condition meet:
> 1. LoadFunc is susceptible to duplicated fields in fieldsToRead. The only LoadFunc we notice now is Zebra.
> 2. The first item in FOREACH statement contains reference to the same input more than once.
> For example, the following script will be affected:
> a = load '11' using org.apache.hadoop.zebra.pig.TableLoader('a0');
> b = foreach a generate a0+a0;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1210) fieldsToRead send the same fields more
than once in some cases
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1210:
----------------------------
Status: Patch Available (was: Open)
Attach patch with test case.
> fieldsToRead send the same fields more than once in some cases
> --------------------------------------------------------------
>
> Key: PIG-1210
> URL: https://issues.apache.org/jira/browse/PIG-1210
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.6.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.6.0
>
> Attachments: PIG-1210-1.patch, PIG-1210-2.patch
>
>
> This bug will happen if the following condition meet:
> 1. LoadFunc is susceptible to duplicated fields in fieldsToRead. The only LoadFunc we notice now is Zebra.
> 2. The first item in FOREACH statement contains reference to the same input more than once.
> For example, the following script will be affected:
> a = load '11' using org.apache.hadoop.zebra.pig.TableLoader('a0');
> b = foreach a generate a0+a0;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1210) fieldsToRead send the same fields more
than once in some cases
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806610#action_12806610 ]
Daniel Dai commented on PIG-1210:
---------------------------------
List is the data structure needed for the construct of RequiredFields. Yes, we could Set, but we need to check if any of our code assume the order within the list, since if we use Set, we lose the order. We can think about that in the new logical plan.
> fieldsToRead send the same fields more than once in some cases
> --------------------------------------------------------------
>
> Key: PIG-1210
> URL: https://issues.apache.org/jira/browse/PIG-1210
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.6.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.6.0
>
> Attachments: PIG-1210-1.patch, PIG-1210-2.patch
>
>
> This bug will happen if the following condition meet:
> 1. LoadFunc is susceptible to duplicated fields in fieldsToRead. The only LoadFunc we notice now is Zebra.
> 2. The first item in FOREACH statement contains reference to the same input more than once.
> For example, the following script will be affected:
> a = load '11' using org.apache.hadoop.zebra.pig.TableLoader('a0');
> b = foreach a generate a0+a0;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1210) fieldsToRead send the same fields more
than once in some cases
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806557#action_12806557 ]
Daniel Dai commented on PIG-1210:
---------------------------------
Test failure is due to "java.lang.IllegalArgumentException: port out of range:-1". Should be an temporal one.
> fieldsToRead send the same fields more than once in some cases
> --------------------------------------------------------------
>
> Key: PIG-1210
> URL: https://issues.apache.org/jira/browse/PIG-1210
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.6.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.6.0
>
> Attachments: PIG-1210-1.patch, PIG-1210-2.patch
>
>
> This bug will happen if the following condition meet:
> 1. LoadFunc is susceptible to duplicated fields in fieldsToRead. The only LoadFunc we notice now is Zebra.
> 2. The first item in FOREACH statement contains reference to the same input more than once.
> For example, the following script will be affected:
> a = load '11' using org.apache.hadoop.zebra.pig.TableLoader('a0');
> b = foreach a generate a0+a0;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1210) fieldsToRead send the same fields more
than once in some cases
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1210:
----------------------------
Fix Version/s: (was: 0.7.0)
0.6.0
Status: Patch Available (was: Open)
> fieldsToRead send the same fields more than once in some cases
> --------------------------------------------------------------
>
> Key: PIG-1210
> URL: https://issues.apache.org/jira/browse/PIG-1210
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.6.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.6.0
>
> Attachments: PIG-1210-1.patch
>
>
> This bug will happen if the following condition meet:
> 1. LoadFunc is susceptible to duplicated fields in fieldsToRead. The only LoadFunc we notice now is Zebra.
> 2. The first item in FOREACH statement contains reference to the same input more than once.
> For example, the following script will be affected:
> a = load '11' using org.apache.hadoop.zebra.pig.TableLoader('a0');
> b = foreach a generate a0+a0;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1210) fieldsToRead send the same fields more
than once in some cases
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1210:
----------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Patch committed to both trunk and 0.6 branch.
> fieldsToRead send the same fields more than once in some cases
> --------------------------------------------------------------
>
> Key: PIG-1210
> URL: https://issues.apache.org/jira/browse/PIG-1210
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.6.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.6.0
>
> Attachments: PIG-1210-1.patch, PIG-1210-2.patch
>
>
> This bug will happen if the following condition meet:
> 1. LoadFunc is susceptible to duplicated fields in fieldsToRead. The only LoadFunc we notice now is Zebra.
> 2. The first item in FOREACH statement contains reference to the same input more than once.
> For example, the following script will be affected:
> a = load '11' using org.apache.hadoop.zebra.pig.TableLoader('a0');
> b = foreach a generate a0+a0;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1210) fieldsToRead send the same fields more
than once in some cases
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1210:
----------------------------
Attachment: PIG-1210-2.patch
> fieldsToRead send the same fields more than once in some cases
> --------------------------------------------------------------
>
> Key: PIG-1210
> URL: https://issues.apache.org/jira/browse/PIG-1210
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.6.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.6.0
>
> Attachments: PIG-1210-1.patch, PIG-1210-2.patch
>
>
> This bug will happen if the following condition meet:
> 1. LoadFunc is susceptible to duplicated fields in fieldsToRead. The only LoadFunc we notice now is Zebra.
> 2. The first item in FOREACH statement contains reference to the same input more than once.
> For example, the following script will be affected:
> a = load '11' using org.apache.hadoop.zebra.pig.TableLoader('a0');
> b = foreach a generate a0+a0;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1210) fieldsToRead send the same fields more
than once in some cases
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1210:
----------------------------
Attachment: PIG-1210-1.patch
> fieldsToRead send the same fields more than once in some cases
> --------------------------------------------------------------
>
> Key: PIG-1210
> URL: https://issues.apache.org/jira/browse/PIG-1210
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.6.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.6.0
>
> Attachments: PIG-1210-1.patch
>
>
> This bug will happen if the following condition meet:
> 1. LoadFunc is susceptible to duplicated fields in fieldsToRead. The only LoadFunc we notice now is Zebra.
> 2. The first item in FOREACH statement contains reference to the same input more than once.
> For example, the following script will be affected:
> a = load '11' using org.apache.hadoop.zebra.pig.TableLoader('a0');
> b = foreach a generate a0+a0;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1210) fieldsToRead send the same fields more
than once in some cases
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806553#action_12806553 ]
Hadoop QA commented on PIG-1210:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12431790/PIG-1210-2.patch
against trunk revision 904241.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/184/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/184/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/184/console
This message is automatically generated.
> fieldsToRead send the same fields more than once in some cases
> --------------------------------------------------------------
>
> Key: PIG-1210
> URL: https://issues.apache.org/jira/browse/PIG-1210
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.6.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.6.0
>
> Attachments: PIG-1210-1.patch, PIG-1210-2.patch
>
>
> This bug will happen if the following condition meet:
> 1. LoadFunc is susceptible to duplicated fields in fieldsToRead. The only LoadFunc we notice now is Zebra.
> 2. The first item in FOREACH statement contains reference to the same input more than once.
> For example, the following script will be affected:
> a = load '11' using org.apache.hadoop.zebra.pig.TableLoader('a0');
> b = foreach a generate a0+a0;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1210) fieldsToRead send the same fields more
than once in some cases
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806607#action_12806607 ]
Olga Natkovich commented on PIG-1210:
-------------------------------------
+1. The changes looks good.
I am wondering why we are using listed instead of set in this case but that's a bigger question outside of this patch.
> fieldsToRead send the same fields more than once in some cases
> --------------------------------------------------------------
>
> Key: PIG-1210
> URL: https://issues.apache.org/jira/browse/PIG-1210
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.6.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.6.0
>
> Attachments: PIG-1210-1.patch, PIG-1210-2.patch
>
>
> This bug will happen if the following condition meet:
> 1. LoadFunc is susceptible to duplicated fields in fieldsToRead. The only LoadFunc we notice now is Zebra.
> 2. The first item in FOREACH statement contains reference to the same input more than once.
> For example, the following script will be affected:
> a = load '11' using org.apache.hadoop.zebra.pig.TableLoader('a0');
> b = foreach a generate a0+a0;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1210) fieldsToRead send the same fields more
than once in some cases
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1210:
----------------------------
Status: Open (was: Patch Available)
> fieldsToRead send the same fields more than once in some cases
> --------------------------------------------------------------
>
> Key: PIG-1210
> URL: https://issues.apache.org/jira/browse/PIG-1210
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.6.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.6.0
>
> Attachments: PIG-1210-1.patch, PIG-1210-2.patch
>
>
> This bug will happen if the following condition meet:
> 1. LoadFunc is susceptible to duplicated fields in fieldsToRead. The only LoadFunc we notice now is Zebra.
> 2. The first item in FOREACH statement contains reference to the same input more than once.
> For example, the following script will be affected:
> a = load '11' using org.apache.hadoop.zebra.pig.TableLoader('a0');
> b = foreach a generate a0+a0;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.