You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/11/21 00:24:06 UTC
[GitHub] [trafficserver] ywkaras opened a new pull request #7347: Allow for regex_remap of pristine URL.
ywkaras opened a new pull request #7347:
URL: https://github.com/apache/trafficserver/pull/7347
Adds a new optional pparam "pristine" to the regex_remap core plugin. When present, this pparam causes
regex_remap to match on the pristine URL, and to use the pristine URL for $ substitutions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #7347: Allow for regex_remap of pristine URL.
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7347:
URL: https://github.com/apache/trafficserver/pull/7347#issuecomment-763833497
Cherry-picked to v9.0.x branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras merged pull request #7347: Allow for regex_remap of pristine URL.
Posted by GitBox <gi...@apache.org>.
ywkaras merged pull request #7347:
URL: https://github.com/apache/trafficserver/pull/7347
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7347: Allow for regex_remap of pristine URL.
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7347:
URL: https://github.com/apache/trafficserver/pull/7347#issuecomment-735865009
> for args would be better to use --pristine with optional arg?
> --pristine the same as --pristine=true OR --pristine=false to explicitly state default behavior?
> Do we have any conventions for these args?
>
> Otherwise the changes themselves look good.
Hmm do you mean @param=--pristine , or does the remap.config syntax allow for using -- before a parameter instead of @param? None of the current regex_remap parameters us -- as a prefix. The boolean parameters all use a "no-" prefix for false. https://docs.trafficserver.apache.org/en/latest/admin-guide/plugins/regex_remap.en.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7347: Allow for regex_remap of pristine URL.
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7347:
URL: https://github.com/apache/trafficserver/pull/7347#issuecomment-731472865
Doc changes pending.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org