You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/02/15 15:34:50 UTC

[GitHub] [arrow] kszucs opened a new pull request #9499: [CI]: Use docker buildkit's inline cache to reuse build cache across different hosts

kszucs opened a new pull request #9499:
URL: https://github.com/apache/arrow/pull/9499


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kszucs commented on pull request #9499: ARROW-11641: [CI] Use docker buildkit's inline cache to reuse build cache across different hosts

Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #9499:
URL: https://github.com/apache/arrow/pull/9499#issuecomment-779790215


   Thanks! The build failures are unrelated, merging.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #9499: ARROW-11641: [CI] Use docker buildkit's inline cache to reuse build cache across different hosts

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9499:
URL: https://github.com/apache/arrow/pull/9499#issuecomment-779668937


   https://issues.apache.org/jira/browse/ARROW-11641


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #9499: [CI]: Use docker buildkit's inline cache to reuse build cache across different hosts

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9499:
URL: https://github.com/apache/arrow/pull/9499#issuecomment-779298151


   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   Could you open an issue for this pull request on JIRA?
   https://issues.apache.org/jira/browse/ARROW
   
   Then could you also rename pull request title in the following format?
   
       ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] removed a comment on pull request #9499: ARROW-11641: [CI] Use docker buildkit's inline cache to reuse build cache across different hosts

Posted by GitBox <gi...@apache.org>.
github-actions[bot] removed a comment on pull request #9499:
URL: https://github.com/apache/arrow/pull/9499#issuecomment-779298151


   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   Could you open an issue for this pull request on JIRA?
   https://issues.apache.org/jira/browse/ARROW
   
   Then could you also rename pull request title in the following format?
   
       ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on a change in pull request #9499: [CI]: Use docker buildkit's inline cache to reuse build cache across different hosts

Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #9499:
URL: https://github.com/apache/arrow/pull/9499#discussion_r576588893



##########
File path: dev/archery/archery/cli.py
##########
@@ -767,6 +767,12 @@ def docker_compose(obj, src, dry_run):
               envvar='ARCHERY_USE_DOCKER_CLI',
               help="Use docker CLI directly for building instead of calling "
                    "docker-compose. This may help to reuse cached layers.")
+@click.option('--using-docker-buildx', default=False, is_flag=True,
+              envvar='ARCHERY_USE_DOCKER_BUILDX',
+              help="Use builx with docker CLI directly for building instead "

Review comment:
       ```suggestion
                 help="Use buildx with docker CLI directly for building instead "
   ```

##########
File path: dev/archery/archery/cli.py
##########
@@ -817,6 +825,12 @@ def docker_compose_build(obj, image, *, force_pull, using_docker_cli,
               envvar='ARCHERY_USE_DOCKER_CLI',
               help="Use docker CLI directly for building instead of calling "
                    "docker-compose. This may help to reuse cached layers.")
+@click.option('--using-docker-buildx', default=False, is_flag=True,
+              envvar='ARCHERY_USE_DOCKER_BUILDX',
+              help="Use builx with docker CLI directly for building instead "

Review comment:
       ```suggestion
                 help="Use buildx with docker CLI directly for building instead "
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kszucs closed pull request #9499: ARROW-11641: [CI] Use docker buildkit's inline cache to reuse build cache across different hosts

Posted by GitBox <gi...@apache.org>.
kszucs closed pull request #9499:
URL: https://github.com/apache/arrow/pull/9499


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org